Re: [PATCH v2 1/4] scripts/ci/setup: ninja missing from build-environment

[Lucas Mateus Martins Araujo e Castro]

On 15/09/2022 12:54, Thomas Huth wrote:


On 14/09/2022 13.41, Lucas Mateus Castro(alqotel) wrote:

From: "Lucas Mateus Castro (alqotel)" 

ninja-build is missing from the RHEL environment, so a system prepared
with that script would still fail to compile QEMU.
Tested on a Fedora 36

Signed-off-by: Lucas Mateus Castro (alqotel) 


---
  scripts/ci/setup/build-environment.yml | 1 +
  1 file changed, 1 insertion(+)

diff --git a/scripts/ci/setup/build-environment.yml 
b/scripts/ci/setup/build-environment.yml

index 232525b91d..6df3e61d94 100644
--- a/scripts/ci/setup/build-environment.yml
+++ b/scripts/ci/setup/build-environment.yml
@@ -150,6 +150,7 @@
    - libepoxy-devel
    - libgcrypt-devel
    - lzo-devel
+  - ninja-build
    - make
    - mesa-libEGL-devel
    - nettle-devel


Looks like the list used to be sorted alphabetically, so maybe you should
sort it in some lines later?

D'oh, I'll send a v3 fixing that.


And I wonder why this hasn't been noticed before ... Cleber, was this in 
use

after all?

  Thomas



--
Lucas Mateus M. Araujo e Castro
Instituto de Pesquisas ELDORADO

Departamento Computação Embarcada
Analista de Software Junior
Aviso Legal - Disclaimer 

Re: [PATCH v2 1/4] scripts/ci/setup: ninja missing from build-environment

[Thomas Huth]

On 14/09/2022 13.41, Lucas Mateus Castro(alqotel) wrote:

From: "Lucas Mateus Castro (alqotel)" 

ninja-build is missing from the RHEL environment, so a system prepared
with that script would still fail to compile QEMU.
Tested on a Fedora 36

Signed-off-by: Lucas Mateus Castro (alqotel) 
---
  scripts/ci/setup/build-environment.yml | 1 +
  1 file changed, 1 insertion(+)

diff --git a/scripts/ci/setup/build-environment.yml 
b/scripts/ci/setup/build-environment.yml
index 232525b91d..6df3e61d94 100644
--- a/scripts/ci/setup/build-environment.yml
+++ b/scripts/ci/setup/build-environment.yml
@@ -150,6 +150,7 @@
- libepoxy-devel
- libgcrypt-devel
- lzo-devel
+  - ninja-build
- make
- mesa-libEGL-devel
- nettle-devel


Looks like the list used to be sorted alphabetically, so maybe you should 
sort it in some lines later?


And I wonder why this hasn't been noticed before ... Cleber, was this in use 
after all?


 Thomas