Re: [PATCH v2 fixed 10/16] util/mmap-alloc: Factor out populating of memory to mmap_populate()

2020-02-19 Thread Peter Xu
On Wed, Feb 12, 2020 at 02:42:48PM +0100, David Hildenbrand wrote:
> We want to populate memory within a reserved memory region. Let's factor
> that out.
> 
> Reviewed-by: Richard Henderson 
> Acked-by: Murilo Opsfelder Araujo 
> Cc: Igor Kotrasinski 
> Cc: "Michael S. Tsirkin" 
> Cc: Greg Kurz 
> Cc: Murilo Opsfelder Araujo 
> Cc: Eduardo Habkost 
> Cc: "Dr. David Alan Gilbert" 
> Cc: Igor Mammedov 
> Signed-off-by: David Hildenbrand 

The naming could be a bit misleading IMO, because we didn't populate
the memory and it's still serviced on demand.  However I don't have a
quick and better name of that either...

Reviewed-by: Peter Xu 

-- 
Peter Xu




Re: [PATCH v2 fixed 10/16] util/mmap-alloc: Factor out populating of memory to mmap_populate()

2020-02-24 Thread David Hildenbrand
On 19.02.20 23:49, Peter Xu wrote:
> On Wed, Feb 12, 2020 at 02:42:48PM +0100, David Hildenbrand wrote:
>> We want to populate memory within a reserved memory region. Let's factor
>> that out.
>>
>> Reviewed-by: Richard Henderson 
>> Acked-by: Murilo Opsfelder Araujo 
>> Cc: Igor Kotrasinski 
>> Cc: "Michael S. Tsirkin" 
>> Cc: Greg Kurz 
>> Cc: Murilo Opsfelder Araujo 
>> Cc: Eduardo Habkost 
>> Cc: "Dr. David Alan Gilbert" 
>> Cc: Igor Mammedov 
>> Signed-off-by: David Hildenbrand 
> 
> The naming could be a bit misleading IMO, because we didn't populate
> the memory and it's still serviced on demand.  However I don't have a
> quick and better name of that either...

Right, depends I would say. With enable_mlock it would get serviced
right away. I also didn't find a better matching name ...

Thanks!

> 
> Reviewed-by: Peter Xu 
> 
-- 
Thanks,

David / dhildenb