Re: [PATCH v3 3/6] migration: Remove 'blk/-b' option from migrate commands
On Thu, May 02, 2024 at 01:35:06PM +, Dr. David Alan Gilbert wrote:
> * Markus Armbruster (arm...@redhat.com) wrote:
> > Fabiano Rosas writes:
> >
> > > The block migration is considered obsolete and has been deprecated in
> > > 8.2. Remove the migrate command option that enables it. This only
> > > affects the QMP and HMP commands, the feature can still be accessed by
> > > setting the migration 'block' capability. The whole feature will be
> > > removed in a future patch.
> > >
> > > Deprecation commit 8846b5bfca ("migration: migrate 'blk' command
> > > option is deprecated.").
> > >
> > > Reviewed-by: Markus Armbruster
> > > Signed-off-by: Fabiano Rosas
> >
> > [...]
> >
> > > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > > index 7978302949..ebca2cdced 100644
> > > --- a/hmp-commands.hx
> > > +++ b/hmp-commands.hx
> > > @@ -909,21 +909,17 @@ ERST
> > >
> > > {
> > > .name = "migrate",
> > > -.args_type = "detach:-d,blk:-b,resume:-r,uri:s",
> > > -.params = "[-d] [-b] [-r] uri",
> > > +.args_type = "detach:-d,resume:-r,uri:s",
> > > +.params = "[-d] [-r] uri",
> > > .help = "migrate to URI (using -d to not wait for
> > > completion)"
> > > - "\n\t\t\t -b for migration without shared storage with"
> > > - " full copy of disk\n\t\t\t -r to resume a paused
> > > migration",
> > > + "\n\t\t\t -r to resume a paused migration",
> > > .cmd= hmp_migrate,
> > > },
> > >
> > >
> > > SRST
> > > -``migrate [-d] [-b]`` *uri*
> > > +``migrate [-d]`` *uri*
> > >Migrate to *uri* (using -d to not wait for completion).
> > > -
> > > - ``-b``
> > > -for migration with full copy of disk
> > > ERST
> >
> > Not this patch's fault, but here goes anyway: -r is undocumented here.
>
> Probably one for Peter I guess.
Yes, and I'll send a patch! :-D
--
Peter Xu
Re: [PATCH v3 3/6] migration: Remove 'blk/-b' option from migrate commands
* Markus Armbruster (arm...@redhat.com) wrote:
> Fabiano Rosas writes:
>
> > The block migration is considered obsolete and has been deprecated in
> > 8.2. Remove the migrate command option that enables it. This only
> > affects the QMP and HMP commands, the feature can still be accessed by
> > setting the migration 'block' capability. The whole feature will be
> > removed in a future patch.
> >
> > Deprecation commit 8846b5bfca ("migration: migrate 'blk' command
> > option is deprecated.").
> >
> > Reviewed-by: Markus Armbruster
> > Signed-off-by: Fabiano Rosas
>
> [...]
>
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index 7978302949..ebca2cdced 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -909,21 +909,17 @@ ERST
> >
> > {
> > .name = "migrate",
> > -.args_type = "detach:-d,blk:-b,resume:-r,uri:s",
> > -.params = "[-d] [-b] [-r] uri",
> > +.args_type = "detach:-d,resume:-r,uri:s",
> > +.params = "[-d] [-r] uri",
> > .help = "migrate to URI (using -d to not wait for
> > completion)"
> > - "\n\t\t\t -b for migration without shared storage with"
> > - " full copy of disk\n\t\t\t -r to resume a paused
> > migration",
> > + "\n\t\t\t -r to resume a paused migration",
> > .cmd= hmp_migrate,
> > },
> >
> >
> > SRST
> > -``migrate [-d] [-b]`` *uri*
> > +``migrate [-d]`` *uri*
> >Migrate to *uri* (using -d to not wait for completion).
> > -
> > - ``-b``
> > -for migration with full copy of disk
> > ERST
>
> Not this patch's fault, but here goes anyway: -r is undocumented here.
Probably one for Peter I guess.
Dave
> >
> > {
>
> [...]
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
Re: [PATCH v3 3/6] migration: Remove 'blk/-b' option from migrate commands
Fabiano Rosas writes:
> The block migration is considered obsolete and has been deprecated in
> 8.2. Remove the migrate command option that enables it. This only
> affects the QMP and HMP commands, the feature can still be accessed by
> setting the migration 'block' capability. The whole feature will be
> removed in a future patch.
>
> Deprecation commit 8846b5bfca ("migration: migrate 'blk' command
> option is deprecated.").
>
> Reviewed-by: Markus Armbruster
> Signed-off-by: Fabiano Rosas
[...]
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 7978302949..ebca2cdced 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -909,21 +909,17 @@ ERST
>
> {
> .name = "migrate",
> -.args_type = "detach:-d,blk:-b,resume:-r,uri:s",
> -.params = "[-d] [-b] [-r] uri",
> +.args_type = "detach:-d,resume:-r,uri:s",
> +.params = "[-d] [-r] uri",
> .help = "migrate to URI (using -d to not wait for completion)"
> - "\n\t\t\t -b for migration without shared storage with"
> - " full copy of disk\n\t\t\t -r to resume a paused
> migration",
> + "\n\t\t\t -r to resume a paused migration",
> .cmd= hmp_migrate,
> },
>
>
> SRST
> -``migrate [-d] [-b]`` *uri*
> +``migrate [-d]`` *uri*
>Migrate to *uri* (using -d to not wait for completion).
> -
> - ``-b``
> -for migration with full copy of disk
> ERST
Not this patch's fault, but here goes anyway: -r is undocumented here.
>
> {
[...]
