Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
On Sun, Aug 2, 2020 at 11:51 PM Bin Meng wrote: > > Hi Alistair, > > On Wed, Jul 29, 2020 at 1:10 PM Bin Meng wrote: > > > > Hi Alistair, > > > > On Wed, Jul 29, 2020 at 1:05 PM Alistair Francis > > wrote: > > > > > > On Tue, Jul 28, 2020 at 9:51 PM Bin Meng wrote: > > > > > > > > Hi Alistair, > > > > > > > > On Wed, Jul 29, 2020 at 2:26 AM Alistair Francis > > > > wrote: > > > > > > > > > > On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > > > > > > > > > > > Hi Alistair, > > > > > > > > > > > > On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis > > > > > > wrote: > > > > > > > > > > > > > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng > > > > > > > wrote: > > > > > > > > > > > > > > > > Hi Alistair, > > > > > > > > > > > > > > > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > From: Bin Meng > > > > > > > > > > > > > > > > > > > > > > Update virt and sifive_u machines to use the opensbi > > > > > > > > > > > fw_dynamic bios > > > > > > > > > > > image built for the generic FDT platform. > > > > > > > > > > > > > > > > > > > > > > Remove the out-of-date no longer used bios images. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Bin Meng > > > > > > > > > > > Reviewed-by: Anup Patel > > > > > > > > > > > Reviewed-by: Alistair Francis > > > > > > > > > > > > > > > > > > > > This patch seems to break 32-bit Linux boots on the > > > > > > > > > > sifive_u and virt machines. > > > > > > > > > > > > > > > > > > > > > > > > > > > > It looks only Linux boot on sifive_u is broken. On our side, > > > > > > > > > we have > > > > > > > > > been using VxWorks to test 32-bit OpenSBI on sifive_u so this > > > > > > > > > issue > > > > > > > > > gets unnoticed. I will take a look. > > > > > > > > > > > > > > > > I've figured out the issue of 32-bit Linux booting failure on > > > > > > > > sifive_u. A patch has been sent to Linux upstream: > > > > > > > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > > > > > > > > > > > > > Thanks for that. What change in QEMU causes this failure though? > > > > > > > > > > > > > > > > > > > There is nothing wrong in QEMU. > > > > > > > > > > There is. This patch causes a regression for 32-bit Linux boot on the > > > > > sifive_u. Your v5 has not addressed this. > > > > > > > > The 32-bit Linux boot failure was fixed by: > > > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > > > > > > > What additional issue did you see? > > > > > > > > > > > > > > With this patch, the Linux boot stops here: > > > > > > > > > > OpenSBI v0.8 > > > > >_ _ > > > > > / __ \ / | _ \_ _| > > > > > | | | |_ __ ___ _ __ | (___ | |_) || | > > > > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > > > > | |__| | |_) | __/ | | |) | |_) || |_ > > > > > \/| .__/ \___|_| |_|_/|/_| > > > > > | | > > > > > |_| > > > > > > > > > > Platform Name : SiFive HiFive Unleashed A00 > > > > > Platform Features : timer,mfdeleg > > > > > Platform HART Count : 4 > > > > > Boot HART ID: 3 > > > > > Boot HART ISA : rv64imafdcsu > > > > > > > > This is a 64-bit hardware. > > > > > > You are right. It's not 32-bit, that was my mistake. I'm used to my > > > first test being 32-bit, but in this case it's not. > > > > > > It looks like this commit instead breaks the sifive_u for 64-bit with > > > the 5.3 kernel. > > > > > > > > > > > > BOOT HART Features : pmp,scounteren,mcounteren > > > > > BOOT HART PMP Count : 16 > > > > > Firmware Base : 0x8000 > > > > > Firmware Size : 116 KB > > > > > Runtime SBI Version : 0.2 > > > > > > > > > > MIDELEG : 0x0222 > > > > > MEDELEG : 0xb109 > > > > > PMP0: 0x8000-0x8001 (A) > > > > > PMP1: 0x-0x (A,R,W,X) > > > > > [0.00] OF: fdt: Ignoring memory range 0x8000 - 0x8020 > > > > > [0.00] Linux version 5.3.0 (oe-user@oe-host) (gcc version > > > > > > > > It seems that you are using quite an old kernel. Can you please try > > > > the latest version? > > > > > > It is an old kernel, but old kernels should still keep working (or we > > > should at least know why they don't) > > > > > > > > > > > > 9.2.0 (GCC)) #1 SMP Thu Sep 19 18:34:52 UTC 2019 > > > > > [0.00] earlycon: sbi0 at I/O port 0x0 (options '') > > > > > [0.00] printk: bootconsole [sbi0] enabled > > > > > [0.00] initrd not found or empty - disabling initrd > > > > > [0.00] Zone ranges: > > > > > [0.00] DMA32[mem 0x8020-0xbfff] > > > > > [0.00] Normal
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
Hi Alistair, On Wed, Jul 29, 2020 at 1:10 PM Bin Meng wrote: > > Hi Alistair, > > On Wed, Jul 29, 2020 at 1:05 PM Alistair Francis wrote: > > > > On Tue, Jul 28, 2020 at 9:51 PM Bin Meng wrote: > > > > > > Hi Alistair, > > > > > > On Wed, Jul 29, 2020 at 2:26 AM Alistair Francis > > > wrote: > > > > > > > > On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > > > > > > > > > Hi Alistair, > > > > > > > > > > On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis > > > > > wrote: > > > > > > > > > > > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > > > > > > > > > > > > > Hi Alistair, > > > > > > > > > > > > > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng > > > > > > > wrote: > > > > > > > > > > > > > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > From: Bin Meng > > > > > > > > > > > > > > > > > > > > Update virt and sifive_u machines to use the opensbi > > > > > > > > > > fw_dynamic bios > > > > > > > > > > image built for the generic FDT platform. > > > > > > > > > > > > > > > > > > > > Remove the out-of-date no longer used bios images. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Bin Meng > > > > > > > > > > Reviewed-by: Anup Patel > > > > > > > > > > Reviewed-by: Alistair Francis > > > > > > > > > > > > > > > > > > This patch seems to break 32-bit Linux boots on the sifive_u > > > > > > > > > and virt machines. > > > > > > > > > > > > > > > > > > > > > > > > > It looks only Linux boot on sifive_u is broken. On our side, we > > > > > > > > have > > > > > > > > been using VxWorks to test 32-bit OpenSBI on sifive_u so this > > > > > > > > issue > > > > > > > > gets unnoticed. I will take a look. > > > > > > > > > > > > > > I've figured out the issue of 32-bit Linux booting failure on > > > > > > > sifive_u. A patch has been sent to Linux upstream: > > > > > > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > > > > > > > > > > > Thanks for that. What change in QEMU causes this failure though? > > > > > > > > > > > > > > > > There is nothing wrong in QEMU. > > > > > > > > There is. This patch causes a regression for 32-bit Linux boot on the > > > > sifive_u. Your v5 has not addressed this. > > > > > > The 32-bit Linux boot failure was fixed by: > > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > > > > > What additional issue did you see? > > > > > > > > > > > With this patch, the Linux boot stops here: > > > > > > > > OpenSBI v0.8 > > > >_ _ > > > > / __ \ / | _ \_ _| > > > > | | | |_ __ ___ _ __ | (___ | |_) || | > > > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > > > | |__| | |_) | __/ | | |) | |_) || |_ > > > > \/| .__/ \___|_| |_|_/|/_| > > > > | | > > > > |_| > > > > > > > > Platform Name : SiFive HiFive Unleashed A00 > > > > Platform Features : timer,mfdeleg > > > > Platform HART Count : 4 > > > > Boot HART ID: 3 > > > > Boot HART ISA : rv64imafdcsu > > > > > > This is a 64-bit hardware. > > > > You are right. It's not 32-bit, that was my mistake. I'm used to my > > first test being 32-bit, but in this case it's not. > > > > It looks like this commit instead breaks the sifive_u for 64-bit with > > the 5.3 kernel. > > > > > > > > > BOOT HART Features : pmp,scounteren,mcounteren > > > > BOOT HART PMP Count : 16 > > > > Firmware Base : 0x8000 > > > > Firmware Size : 116 KB > > > > Runtime SBI Version : 0.2 > > > > > > > > MIDELEG : 0x0222 > > > > MEDELEG : 0xb109 > > > > PMP0: 0x8000-0x8001 (A) > > > > PMP1: 0x-0x (A,R,W,X) > > > > [0.00] OF: fdt: Ignoring memory range 0x8000 - 0x8020 > > > > [0.00] Linux version 5.3.0 (oe-user@oe-host) (gcc version > > > > > > It seems that you are using quite an old kernel. Can you please try > > > the latest version? > > > > It is an old kernel, but old kernels should still keep working (or we > > should at least know why they don't) > > > > > > > > > 9.2.0 (GCC)) #1 SMP Thu Sep 19 18:34:52 UTC 2019 > > > > [0.00] earlycon: sbi0 at I/O port 0x0 (options '') > > > > [0.00] printk: bootconsole [sbi0] enabled > > > > [0.00] initrd not found or empty - disabling initrd > > > > [0.00] Zone ranges: > > > > [0.00] DMA32[mem 0x8020-0xbfff] > > > > [0.00] Normal empty > > > > [0.00] Movable zone start for each node > > > > [0.00] Early memory node ranges > > > > [0.00] node 0: [mem 0x8020-0xbfff] > > > > [0.00] Initmem setup node 0 [mem > > > > 0x8020-0xbfff] > > > > [0.00] OF: fdt: Invalid
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
Hi Alistair, On Wed, Jul 29, 2020 at 1:05 PM Alistair Francis wrote: > > On Tue, Jul 28, 2020 at 9:51 PM Bin Meng wrote: > > > > Hi Alistair, > > > > On Wed, Jul 29, 2020 at 2:26 AM Alistair Francis > > wrote: > > > > > > On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > > > > > > > Hi Alistair, > > > > > > > > On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis > > > > wrote: > > > > > > > > > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > > > > > > > > > > > Hi Alistair, > > > > > > > > > > > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > > > > > > > > > > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > > > > > > wrote: > > > > > > > > > > > > > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > From: Bin Meng > > > > > > > > > > > > > > > > > > Update virt and sifive_u machines to use the opensbi > > > > > > > > > fw_dynamic bios > > > > > > > > > image built for the generic FDT platform. > > > > > > > > > > > > > > > > > > Remove the out-of-date no longer used bios images. > > > > > > > > > > > > > > > > > > Signed-off-by: Bin Meng > > > > > > > > > Reviewed-by: Anup Patel > > > > > > > > > Reviewed-by: Alistair Francis > > > > > > > > > > > > > > > > This patch seems to break 32-bit Linux boots on the sifive_u > > > > > > > > and virt machines. > > > > > > > > > > > > > > > > > > > > > > It looks only Linux boot on sifive_u is broken. On our side, we > > > > > > > have > > > > > > > been using VxWorks to test 32-bit OpenSBI on sifive_u so this > > > > > > > issue > > > > > > > gets unnoticed. I will take a look. > > > > > > > > > > > > I've figured out the issue of 32-bit Linux booting failure on > > > > > > sifive_u. A patch has been sent to Linux upstream: > > > > > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > > > > > > > > > Thanks for that. What change in QEMU causes this failure though? > > > > > > > > > > > > > There is nothing wrong in QEMU. > > > > > > There is. This patch causes a regression for 32-bit Linux boot on the > > > sifive_u. Your v5 has not addressed this. > > > > The 32-bit Linux boot failure was fixed by: > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > > > What additional issue did you see? > > > > > > > > With this patch, the Linux boot stops here: > > > > > > OpenSBI v0.8 > > >_ _ > > > / __ \ / | _ \_ _| > > > | | | |_ __ ___ _ __ | (___ | |_) || | > > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > > | |__| | |_) | __/ | | |) | |_) || |_ > > > \/| .__/ \___|_| |_|_/|/_| > > > | | > > > |_| > > > > > > Platform Name : SiFive HiFive Unleashed A00 > > > Platform Features : timer,mfdeleg > > > Platform HART Count : 4 > > > Boot HART ID: 3 > > > Boot HART ISA : rv64imafdcsu > > > > This is a 64-bit hardware. > > You are right. It's not 32-bit, that was my mistake. I'm used to my > first test being 32-bit, but in this case it's not. > > It looks like this commit instead breaks the sifive_u for 64-bit with > the 5.3 kernel. > > > > > > BOOT HART Features : pmp,scounteren,mcounteren > > > BOOT HART PMP Count : 16 > > > Firmware Base : 0x8000 > > > Firmware Size : 116 KB > > > Runtime SBI Version : 0.2 > > > > > > MIDELEG : 0x0222 > > > MEDELEG : 0xb109 > > > PMP0: 0x8000-0x8001 (A) > > > PMP1: 0x-0x (A,R,W,X) > > > [0.00] OF: fdt: Ignoring memory range 0x8000 - 0x8020 > > > [0.00] Linux version 5.3.0 (oe-user@oe-host) (gcc version > > > > It seems that you are using quite an old kernel. Can you please try > > the latest version? > > It is an old kernel, but old kernels should still keep working (or we > should at least know why they don't) > > > > > > 9.2.0 (GCC)) #1 SMP Thu Sep 19 18:34:52 UTC 2019 > > > [0.00] earlycon: sbi0 at I/O port 0x0 (options '') > > > [0.00] printk: bootconsole [sbi0] enabled > > > [0.00] initrd not found or empty - disabling initrd > > > [0.00] Zone ranges: > > > [0.00] DMA32[mem 0x8020-0xbfff] > > > [0.00] Normal empty > > > [0.00] Movable zone start for each node > > > [0.00] Early memory node ranges > > > [0.00] node 0: [mem 0x8020-0xbfff] > > > [0.00] Initmem setup node 0 [mem > > > 0x8020-0xbfff] > > > [0.00] OF: fdt: Invalid device tree blob header > > > [0.00] software IO TLB: mapped [mem 0xbb1fe000-0xbf1fe000] (64MB) > > > > > > Without this patch I can boot all the way to looking for a rootFS. > > > > > > Please don't send new versions of patches without addresses regressions. > > > > The patches were sent after addressing all regressions you
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
On Tue, Jul 28, 2020 at 9:51 PM Bin Meng wrote: > > Hi Alistair, > > On Wed, Jul 29, 2020 at 2:26 AM Alistair Francis wrote: > > > > On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > > > > > Hi Alistair, > > > > > > On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis > > > wrote: > > > > > > > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > > > > > > > > > Hi Alistair, > > > > > > > > > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > > > > > > > > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > > > > > wrote: > > > > > > > > > > > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng > > > > > > > wrote: > > > > > > > > > > > > > > > > From: Bin Meng > > > > > > > > > > > > > > > > Update virt and sifive_u machines to use the opensbi fw_dynamic > > > > > > > > bios > > > > > > > > image built for the generic FDT platform. > > > > > > > > > > > > > > > > Remove the out-of-date no longer used bios images. > > > > > > > > > > > > > > > > Signed-off-by: Bin Meng > > > > > > > > Reviewed-by: Anup Patel > > > > > > > > Reviewed-by: Alistair Francis > > > > > > > > > > > > > > This patch seems to break 32-bit Linux boots on the sifive_u and > > > > > > > virt machines. > > > > > > > > > > > > > > > > > > > It looks only Linux boot on sifive_u is broken. On our side, we have > > > > > > been using VxWorks to test 32-bit OpenSBI on sifive_u so this issue > > > > > > gets unnoticed. I will take a look. > > > > > > > > > > I've figured out the issue of 32-bit Linux booting failure on > > > > > sifive_u. A patch has been sent to Linux upstream: > > > > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > > > > > > > Thanks for that. What change in QEMU causes this failure though? > > > > > > > > > > There is nothing wrong in QEMU. > > > > There is. This patch causes a regression for 32-bit Linux boot on the > > sifive_u. Your v5 has not addressed this. > > The 32-bit Linux boot failure was fixed by: > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > What additional issue did you see? > > > > > With this patch, the Linux boot stops here: > > > > OpenSBI v0.8 > >_ _ > > / __ \ / | _ \_ _| > > | | | |_ __ ___ _ __ | (___ | |_) || | > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > | |__| | |_) | __/ | | |) | |_) || |_ > > \/| .__/ \___|_| |_|_/|/_| > > | | > > |_| > > > > Platform Name : SiFive HiFive Unleashed A00 > > Platform Features : timer,mfdeleg > > Platform HART Count : 4 > > Boot HART ID: 3 > > Boot HART ISA : rv64imafdcsu > > This is a 64-bit hardware. You are right. It's not 32-bit, that was my mistake. I'm used to my first test being 32-bit, but in this case it's not. It looks like this commit instead breaks the sifive_u for 64-bit with the 5.3 kernel. > > > BOOT HART Features : pmp,scounteren,mcounteren > > BOOT HART PMP Count : 16 > > Firmware Base : 0x8000 > > Firmware Size : 116 KB > > Runtime SBI Version : 0.2 > > > > MIDELEG : 0x0222 > > MEDELEG : 0xb109 > > PMP0: 0x8000-0x8001 (A) > > PMP1: 0x-0x (A,R,W,X) > > [0.00] OF: fdt: Ignoring memory range 0x8000 - 0x8020 > > [0.00] Linux version 5.3.0 (oe-user@oe-host) (gcc version > > It seems that you are using quite an old kernel. Can you please try > the latest version? It is an old kernel, but old kernels should still keep working (or we should at least know why they don't) > > > 9.2.0 (GCC)) #1 SMP Thu Sep 19 18:34:52 UTC 2019 > > [0.00] earlycon: sbi0 at I/O port 0x0 (options '') > > [0.00] printk: bootconsole [sbi0] enabled > > [0.00] initrd not found or empty - disabling initrd > > [0.00] Zone ranges: > > [0.00] DMA32[mem 0x8020-0xbfff] > > [0.00] Normal empty > > [0.00] Movable zone start for each node > > [0.00] Early memory node ranges > > [0.00] node 0: [mem 0x8020-0xbfff] > > [0.00] Initmem setup node 0 [mem > > 0x8020-0xbfff] > > [0.00] OF: fdt: Invalid device tree blob header > > [0.00] software IO TLB: mapped [mem 0xbb1fe000-0xbf1fe000] (64MB) > > > > Without this patch I can boot all the way to looking for a rootFS. > > > > Please don't send new versions of patches without addresses regressions. > > The patches were sent after addressing all regressions you reported > (well the 32-bit Linux booting issue is actually not a QEMU > regression, but one that exists in the Linux kernel side for a long > time). Yep, that is my mistake. Sorry about the confusion. > > I just tested 64-bit Linux boot on both virt and sifive_u, and they > both can boot all the way to looking for a root fs. Can you test with older kernels? If
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
Hi Alistair, On Wed, Jul 29, 2020 at 2:26 AM Alistair Francis wrote: > > On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > > > Hi Alistair, > > > > On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis > > wrote: > > > > > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > > > > > > > Hi Alistair, > > > > > > > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > > > > > > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > > > > wrote: > > > > > > > > > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote: > > > > > > > > > > > > > > From: Bin Meng > > > > > > > > > > > > > > Update virt and sifive_u machines to use the opensbi fw_dynamic > > > > > > > bios > > > > > > > image built for the generic FDT platform. > > > > > > > > > > > > > > Remove the out-of-date no longer used bios images. > > > > > > > > > > > > > > Signed-off-by: Bin Meng > > > > > > > Reviewed-by: Anup Patel > > > > > > > Reviewed-by: Alistair Francis > > > > > > > > > > > > This patch seems to break 32-bit Linux boots on the sifive_u and > > > > > > virt machines. > > > > > > > > > > > > > > > > It looks only Linux boot on sifive_u is broken. On our side, we have > > > > > been using VxWorks to test 32-bit OpenSBI on sifive_u so this issue > > > > > gets unnoticed. I will take a look. > > > > > > > > I've figured out the issue of 32-bit Linux booting failure on > > > > sifive_u. A patch has been sent to Linux upstream: > > > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > > > > > Thanks for that. What change in QEMU causes this failure though? > > > > > > > There is nothing wrong in QEMU. > > There is. This patch causes a regression for 32-bit Linux boot on the > sifive_u. Your v5 has not addressed this. The 32-bit Linux boot failure was fixed by: http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html What additional issue did you see? > > With this patch, the Linux boot stops here: > > OpenSBI v0.8 >_ _ > / __ \ / | _ \_ _| > | | | |_ __ ___ _ __ | (___ | |_) || | > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > | |__| | |_) | __/ | | |) | |_) || |_ > \/| .__/ \___|_| |_|_/|/_| > | | > |_| > > Platform Name : SiFive HiFive Unleashed A00 > Platform Features : timer,mfdeleg > Platform HART Count : 4 > Boot HART ID: 3 > Boot HART ISA : rv64imafdcsu This is a 64-bit hardware. > BOOT HART Features : pmp,scounteren,mcounteren > BOOT HART PMP Count : 16 > Firmware Base : 0x8000 > Firmware Size : 116 KB > Runtime SBI Version : 0.2 > > MIDELEG : 0x0222 > MEDELEG : 0xb109 > PMP0: 0x8000-0x8001 (A) > PMP1: 0x-0x (A,R,W,X) > [0.00] OF: fdt: Ignoring memory range 0x8000 - 0x8020 > [0.00] Linux version 5.3.0 (oe-user@oe-host) (gcc version It seems that you are using quite an old kernel. Can you please try the latest version? > 9.2.0 (GCC)) #1 SMP Thu Sep 19 18:34:52 UTC 2019 > [0.00] earlycon: sbi0 at I/O port 0x0 (options '') > [0.00] printk: bootconsole [sbi0] enabled > [0.00] initrd not found or empty - disabling initrd > [0.00] Zone ranges: > [0.00] DMA32[mem 0x8020-0xbfff] > [0.00] Normal empty > [0.00] Movable zone start for each node > [0.00] Early memory node ranges > [0.00] node 0: [mem 0x8020-0xbfff] > [0.00] Initmem setup node 0 [mem > 0x8020-0xbfff] > [0.00] OF: fdt: Invalid device tree blob header > [0.00] software IO TLB: mapped [mem 0xbb1fe000-0xbf1fe000] (64MB) > > Without this patch I can boot all the way to looking for a rootFS. > > Please don't send new versions of patches without addresses regressions. The patches were sent after addressing all regressions you reported (well the 32-bit Linux booting issue is actually not a QEMU regression, but one that exists in the Linux kernel side for a long time). I just tested 64-bit Linux boot on both virt and sifive_u, and they both can boot all the way to looking for a root fs. Regards, Bin
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
On Tue, Jul 28, 2020 at 8:46 AM Bin Meng wrote: > > Hi Alistair, > > On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis > wrote: > > > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > > > > > Hi Alistair, > > > > > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > > > > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > > > wrote: > > > > > > > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote: > > > > > > > > > > > > From: Bin Meng > > > > > > > > > > > > Update virt and sifive_u machines to use the opensbi fw_dynamic bios > > > > > > image built for the generic FDT platform. > > > > > > > > > > > > Remove the out-of-date no longer used bios images. > > > > > > > > > > > > Signed-off-by: Bin Meng > > > > > > Reviewed-by: Anup Patel > > > > > > Reviewed-by: Alistair Francis > > > > > > > > > > This patch seems to break 32-bit Linux boots on the sifive_u and virt > > > > > machines. > > > > > > > > > > > > > It looks only Linux boot on sifive_u is broken. On our side, we have > > > > been using VxWorks to test 32-bit OpenSBI on sifive_u so this issue > > > > gets unnoticed. I will take a look. > > > > > > I've figured out the issue of 32-bit Linux booting failure on > > > sifive_u. A patch has been sent to Linux upstream: > > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > > > Thanks for that. What change in QEMU causes this failure though? > > > > There is nothing wrong in QEMU. There is. This patch causes a regression for 32-bit Linux boot on the sifive_u. Your v5 has not addressed this. With this patch, the Linux boot stops here: OpenSBI v0.8 _ _ / __ \ / | _ \_ _| | | | |_ __ ___ _ __ | (___ | |_) || | | | | | '_ \ / _ \ '_ \ \___ \| _ < | | | |__| | |_) | __/ | | |) | |_) || |_ \/| .__/ \___|_| |_|_/|/_| | | |_| Platform Name : SiFive HiFive Unleashed A00 Platform Features : timer,mfdeleg Platform HART Count : 4 Boot HART ID: 3 Boot HART ISA : rv64imafdcsu BOOT HART Features : pmp,scounteren,mcounteren BOOT HART PMP Count : 16 Firmware Base : 0x8000 Firmware Size : 116 KB Runtime SBI Version : 0.2 MIDELEG : 0x0222 MEDELEG : 0xb109 PMP0: 0x8000-0x8001 (A) PMP1: 0x-0x (A,R,W,X) [0.00] OF: fdt: Ignoring memory range 0x8000 - 0x8020 [0.00] Linux version 5.3.0 (oe-user@oe-host) (gcc version 9.2.0 (GCC)) #1 SMP Thu Sep 19 18:34:52 UTC 2019 [0.00] earlycon: sbi0 at I/O port 0x0 (options '') [0.00] printk: bootconsole [sbi0] enabled [0.00] initrd not found or empty - disabling initrd [0.00] Zone ranges: [0.00] DMA32[mem 0x8020-0xbfff] [0.00] Normal empty [0.00] Movable zone start for each node [0.00] Early memory node ranges [0.00] node 0: [mem 0x8020-0xbfff] [0.00] Initmem setup node 0 [mem 0x8020-0xbfff] [0.00] OF: fdt: Invalid device tree blob header [0.00] software IO TLB: mapped [mem 0xbb1fe000-0xbf1fe000] (64MB) Without this patch I can boot all the way to looking for a rootFS. Please don't send new versions of patches without addresses regressions. Alistair > > > There are lots of people not running the latest Linux from master that > > this will cause breakages for. > > It's just that the 32-bit Linux defconfig has never been validated by > people with 'sifive_u' machine. I bet people only validated the 32-bit > kernel with the 'virt' machine. > > Regards, > Bin
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
Hi Alistair, On Tue, Jul 28, 2020 at 11:39 PM Alistair Francis wrote: > > On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > > > Hi Alistair, > > > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > > wrote: > > > > > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote: > > > > > > > > > > From: Bin Meng > > > > > > > > > > Update virt and sifive_u machines to use the opensbi fw_dynamic bios > > > > > image built for the generic FDT platform. > > > > > > > > > > Remove the out-of-date no longer used bios images. > > > > > > > > > > Signed-off-by: Bin Meng > > > > > Reviewed-by: Anup Patel > > > > > Reviewed-by: Alistair Francis > > > > > > > > This patch seems to break 32-bit Linux boots on the sifive_u and virt > > > > machines. > > > > > > > > > > It looks only Linux boot on sifive_u is broken. On our side, we have > > > been using VxWorks to test 32-bit OpenSBI on sifive_u so this issue > > > gets unnoticed. I will take a look. > > > > I've figured out the issue of 32-bit Linux booting failure on > > sifive_u. A patch has been sent to Linux upstream: > > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html > > Thanks for that. What change in QEMU causes this failure though? > There is nothing wrong in QEMU. > There are lots of people not running the latest Linux from master that > this will cause breakages for. It's just that the 32-bit Linux defconfig has never been validated by people with 'sifive_u' machine. I bet people only validated the 32-bit kernel with the 'virt' machine. Regards, Bin
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
On Wed, Jul 15, 2020 at 9:55 PM Bin Meng wrote: > > Hi Alistair, > > On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis > > wrote: > > > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote: > > > > > > > > From: Bin Meng > > > > > > > > Update virt and sifive_u machines to use the opensbi fw_dynamic bios > > > > image built for the generic FDT platform. > > > > > > > > Remove the out-of-date no longer used bios images. > > > > > > > > Signed-off-by: Bin Meng > > > > Reviewed-by: Anup Patel > > > > Reviewed-by: Alistair Francis > > > > > > This patch seems to break 32-bit Linux boots on the sifive_u and virt > > > machines. > > > > > > > It looks only Linux boot on sifive_u is broken. On our side, we have > > been using VxWorks to test 32-bit OpenSBI on sifive_u so this issue > > gets unnoticed. I will take a look. > > I've figured out the issue of 32-bit Linux booting failure on > sifive_u. A patch has been sent to Linux upstream: > http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html Thanks for that. What change in QEMU causes this failure though? There are lots of people not running the latest Linux from master that this will cause breakages for. Alistair > > Regards, > Bin
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
Hi Alistair, On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis wrote: > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote: > > > > > > From: Bin Meng > > > > > > Update virt and sifive_u machines to use the opensbi fw_dynamic bios > > > image built for the generic FDT platform. > > > > > > Remove the out-of-date no longer used bios images. > > > > > > Signed-off-by: Bin Meng > > > Reviewed-by: Anup Patel > > > Reviewed-by: Alistair Francis > > > > This patch seems to break 32-bit Linux boots on the sifive_u and virt > > machines. > > > > It looks only Linux boot on sifive_u is broken. On our side, we have > been using VxWorks to test 32-bit OpenSBI on sifive_u so this issue > gets unnoticed. I will take a look. I've figured out the issue of 32-bit Linux booting failure on sifive_u. A patch has been sent to Linux upstream: http://lists.infradead.org/pipermail/linux-riscv/2020-July/001213.html Regards, Bin
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis wrote: > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote: > > > > From: Bin Meng > > > > Update virt and sifive_u machines to use the opensbi fw_dynamic bios > > image built for the generic FDT platform. > > > > Remove the out-of-date no longer used bios images. > > > > Signed-off-by: Bin Meng > > Reviewed-by: Anup Patel > > Reviewed-by: Alistair Francis > > This patch seems to break 32-bit Linux boots on the sifive_u and virt > machines. > It looks only Linux boot on sifive_u is broken. On our side, we have been using VxWorks to test 32-bit OpenSBI on sifive_u so this issue gets unnoticed. I will take a look. Regards, Bin
Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u
On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote:
>
> From: Bin Meng
>
> Update virt and sifive_u machines to use the opensbi fw_dynamic bios
> image built for the generic FDT platform.
>
> Remove the out-of-date no longer used bios images.
>
> Signed-off-by: Bin Meng
> Reviewed-by: Anup Patel
> Reviewed-by: Alistair Francis
This patch seems to break 32-bit Linux boots on the sifive_u and virt machines.
Alistair
>
> ---
>
> Changes in v4:
> - Remove old binaries in the Makefile for `make install` bisection
>
> Changes in v3:
> - Change to fw_dynamic.bin for virt & sifive_u
>
> Makefile | 4 +---
> hw/riscv/sifive_u.c| 4 ++--
> hw/riscv/virt.c| 4 ++--
> pc-bios/opensbi-riscv32-generic-fw_dynamic.bin | Bin 0 -> 62144 bytes
> pc-bios/opensbi-riscv32-sifive_u-fw_jump.bin | Bin 49520 -> 0 bytes
> pc-bios/opensbi-riscv32-virt-fw_jump.bin | Bin 49504 -> 0 bytes
> pc-bios/opensbi-riscv64-generic-fw_dynamic.bin | Bin 0 -> 70792 bytes
> pc-bios/opensbi-riscv64-sifive_u-fw_jump.bin | Bin 57936 -> 0 bytes
> pc-bios/opensbi-riscv64-virt-fw_jump.bin | Bin 57920 -> 0 bytes
> 9 files changed, 5 insertions(+), 7 deletions(-)
> create mode 100644 pc-bios/opensbi-riscv32-generic-fw_dynamic.bin
> delete mode 100644 pc-bios/opensbi-riscv32-sifive_u-fw_jump.bin
> delete mode 100644 pc-bios/opensbi-riscv32-virt-fw_jump.bin
> create mode 100644 pc-bios/opensbi-riscv64-generic-fw_dynamic.bin
> delete mode 100644 pc-bios/opensbi-riscv64-sifive_u-fw_jump.bin
> delete mode 100644 pc-bios/opensbi-riscv64-virt-fw_jump.bin
>
> diff --git a/Makefile b/Makefile
> index b1b8a5a..f06b3ae 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -840,9 +840,7 @@ palcode-clipper \
> u-boot.e500 u-boot-sam460-20100605.bin \
> qemu_vga.ndrv \
> edk2-licenses.txt \
> -hppa-firmware.img \
> -opensbi-riscv32-sifive_u-fw_jump.bin opensbi-riscv32-virt-fw_jump.bin \
> -opensbi-riscv64-sifive_u-fw_jump.bin opensbi-riscv64-virt-fw_jump.bin
> +hppa-firmware.img
>
>
> DESCS=50-edk2-i386-secure.json 50-edk2-x86_64-secure.json \
> diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
> index b434fd3..dc46f64 100644
> --- a/hw/riscv/sifive_u.c
> +++ b/hw/riscv/sifive_u.c
> @@ -60,9 +60,9 @@
> #include
>
> #if defined(TARGET_RISCV32)
> -# define BIOS_FILENAME "opensbi-riscv32-sifive_u-fw_jump.bin"
> +# define BIOS_FILENAME "opensbi-riscv32-generic-fw_dynamic.bin"
> #else
> -# define BIOS_FILENAME "opensbi-riscv64-sifive_u-fw_jump.bin"
> +# define BIOS_FILENAME "opensbi-riscv64-generic-fw_dynamic.bin"
> #endif
>
> static const struct MemmapEntry {
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index 85e17fe..5ca49c5 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -43,9 +43,9 @@
> #include "hw/pci-host/gpex.h"
>
> #if defined(TARGET_RISCV32)
> -# define BIOS_FILENAME "opensbi-riscv32-virt-fw_jump.bin"
> +# define BIOS_FILENAME "opensbi-riscv32-generic-fw_dynamic.bin"
> #else
> -# define BIOS_FILENAME "opensbi-riscv64-virt-fw_jump.bin"
> +# define BIOS_FILENAME "opensbi-riscv64-generic-fw_dynamic.bin"
> #endif
>
> static const struct MemmapEntry {
> diff --git a/pc-bios/opensbi-riscv32-generic-fw_dynamic.bin
> b/pc-bios/opensbi-riscv32-generic-fw_dynamic.bin
> new file mode 100644
> index 000..23b4dfb
> Binary files /dev/null and b/pc-bios/opensbi-riscv32-generic-fw_dynamic.bin
> differ
> diff --git a/pc-bios/opensbi-riscv32-sifive_u-fw_jump.bin
> b/pc-bios/opensbi-riscv32-sifive_u-fw_jump.bin
> deleted file mode 100644
> index 3e0da54..000
> Binary files a/pc-bios/opensbi-riscv32-sifive_u-fw_jump.bin and /dev/null
> differ
> diff --git a/pc-bios/opensbi-riscv32-virt-fw_jump.bin
> b/pc-bios/opensbi-riscv32-virt-fw_jump.bin
> deleted file mode 100644
> index bc56ed6..000
> Binary files a/pc-bios/opensbi-riscv32-virt-fw_jump.bin and /dev/null differ
> diff --git a/pc-bios/opensbi-riscv64-generic-fw_dynamic.bin
> b/pc-bios/opensbi-riscv64-generic-fw_dynamic.bin
> new file mode 100644
> index 000..16c0cf4
> Binary files /dev/null and b/pc-bios/opensbi-riscv64-generic-fw_dynamic.bin
> differ
> diff --git a/pc-bios/opensbi-riscv64-sifive_u-fw_jump.bin
> b/pc-bios/opensbi-riscv64-sifive_u-fw_jump.bin
> deleted file mode 100644
> index 1acee86..000
> Binary files a/pc-bios/opensbi-riscv64-sifive_u-fw_jump.bin and /dev/null
> differ
> diff --git a/pc-bios/opensbi-riscv64-virt-fw_jump.bin
> b/pc-bios/opensbi-riscv64-virt-fw_jump.bin
> deleted file mode 100644
> index c62f2b4..000
> Binary files a/pc-bios/opensbi-riscv64-virt-fw_jump.bin and /dev/null differ
> --
> 2.7.4
>
>
