Re: [PULL 0/1] xen queue
On Fri, 24 Mar 2023 at 13:47, Anthony PERARD wrote: > > On Thu, Mar 23, 2023 at 10:01:59AM +, Anthony PERARD wrote: > > The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12: > > > > Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into > > staging (2023-03-22 17:58:12 +) > > > > are available in the Git repository at: > > > > https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git > > tags/pull-xen-20230323 > > > > for you to fetch changes up to f75e4f2234e7339c16c1dba048bf131a2a948f84: > > > > accel/xen: Fix DM state change notification in dm_restrict mode > > (2023-03-23 09:56:54 +) > > > > > > Xen queue > > > > - fix guest creation when -xen-domid-restrict is used > > Hi Peter, > > I'd like to cancel this pull request. I've got another patch to add to > it. Is that fine? If I don't have any reply, I'll create a new PR later > today and consider this one cancel. That's fine. I had been holding off on it until I could combine it with another, to save on the CI resources... -- PMM
Re: [PULL 0/1] xen queue
On Thu, Mar 23, 2023 at 10:01:59AM +, Anthony PERARD wrote: > The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12: > > Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into > staging (2023-03-22 17:58:12 +) > > are available in the Git repository at: > > https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git > tags/pull-xen-20230323 > > for you to fetch changes up to f75e4f2234e7339c16c1dba048bf131a2a948f84: > > accel/xen: Fix DM state change notification in dm_restrict mode (2023-03-23 > 09:56:54 +) > > > Xen queue > > - fix guest creation when -xen-domid-restrict is used Hi Peter, I'd like to cancel this pull request. I've got another patch to add to it. Is that fine? If I don't have any reply, I'll create a new PR later today and consider this one cancel. Cheers, -- Anthony PERARD
Re: [PULL 0/1] xen queue 2022-09-27
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature
Re: [PULL 0/1] xen queue 2021-03-23
On Tue, 23 Mar 2021 at 12:04, Anthony PERARD wrote: > > The following changes since commit 5ca634afcf83215a9a54ca6e66032325b5ffb5f6: > > Merge remote-tracking branch 'remotes/philmd/tags/sdmmc-20210322' into > staging (2021-03-22 18:50:25 +) > > are available in the Git repository at: > > https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git > tags/pull-xen-20210323 > > for you to fetch changes up to b807ca3fa0ca29ec015adcf4045e716337cd3635: > > xen-block: Fix removal of backend instance via xenstore (2021-03-23 > 11:18:20 +) > > > Xen patch > > - Fix Xen backend block detach via xenstore. > > > Anthony PERARD (1): > xen-block: Fix removal of backend instance via xenstore Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0 for any user-visible changes. -- PMM
Re: [PULL 0/1] xen queue 2021-03-23
On Tue, Mar 23, 2021 at 05:09:45AM -0700, no-re...@patchew.org wrote: > ERROR: Author email address is mangled by the mailing list > #2: > Author: Anthony PERARD via The actual commit in the pull request is fine. I didn't work around the email issue when sending pull request, but I've worked around it when sending patch series. Cheers, -- Anthony PERARD
Re: [PULL 0/1] xen queue 2021-03-23
Patchew URL: https://patchew.org/QEMU/20210323120439.563855-1-anthony.per...@citrix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210323120439.563855-1-anthony.per...@citrix.com Subject: [PULL 0/1] xen queue 2021-03-23 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210323120439.563855-1-anthony.per...@citrix.com -> patchew/20210323120439.563855-1-anthony.per...@citrix.com Switched to a new branch 'test' 9752a37 xen-block: Fix removal of backend instance via xenstore === OUTPUT BEGIN === ERROR: Author email address is mangled by the mailing list #2: Author: Anthony PERARD via total: 1 errors, 0 warnings, 15 lines checked Commit 9752a379e990 (xen-block: Fix removal of backend instance via xenstore) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210323120439.563855-1-anthony.per...@citrix.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PULL 0/1] xen queue 2020-11-02
On Mon, 2 Nov 2020 at 14:51, Anthony PERARD wrote: > > The following changes since commit 2c6605389c1f76973d92b69b85d40d94b8f1092c: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20201101.0' > into staging (2020-11-02 09:54:00 +) > > are available in the Git repository at: > > https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git > tags/pull-xen-20201102 > > for you to fetch changes up to 045b1d4dbb44da67f1f86efa75b02843c0e951ef: > > xen: rework pci_piix3_xen_ide_unplug (2020-11-02 11:56:55 +) > > > xen patch > > - Rework Xen disk unplug to work with newer command line > options. > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM
Re: [PULL 0/1] xen queue 2020-08-04
On Tue, 4 Aug 2020 at 10:26, Anthony PERARD wrote: > > The following changes since commit 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200803' into staging (2020-08-03 > 20:34:26 +0100) > > are available in the Git repository at: > > https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git > tags/pull-xen-20200804 > > for you to fetch changes up to 8e0ef068942e4152f0d23e76ca1f5e35dc4456f7: > > accel/xen: Fix xen_enabled() behavior on target-agnostic objects > (2020-08-04 10:21:35 +0100) > > > xen patch > > Bug fix. > > > Philippe Mathieu-Daudé (1): > accel/xen: Fix xen_enabled() behavior on target-agnostic objects Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
Re: [PULL 0/1] xen queue 2020-08-03
On Mon, 3 Aug 2020 at 17:53, Anthony PERARD wrote: > > xen patches > > bug fix > > > Philippe Mathieu-Daudé (1): > accel/xen: Fix xen_enabled() behavior on target-agnostic objects This fails to compile, all hosts :-( LINKavr-softmmu/qemu-system-avr ../migration/savevm.o: In function `qemu_loadvm_section_start_full': /home/petmay01/linaro/qemu-for-merges/migration/savevm.c:2320: undefined reference to `xen_enabled' collect2: error: ld returned 1 exit status [ditto other softmmu link attempts] Similar but different on OSX: LINKaarch64-softmmu/qemu-system-aarch64 Undefined symbols for architecture x86_64: "_xen_enabled", referenced from: _msix_is_masked in msix.o _msix_write_config in msix.o _msix_handle_mask_update in msix.o _msix_init in msix.o _msix_notify in msix.o _msix_reset in msix.o _msix_set_vector_notifiers in msix.o ... ld: symbol(s) not found for architecture x86_64 Fails in all the BSD VM builds as well, so I don't think this is related to incremental vs from-clean builds. I think the failure here is only on builds where CONFIG_XEN is not set by configure (which for my merge build setup appears to be all of them, I think). In that case when we build a target-agnostic object it gets an external reference to the xen_enabled() function, but because Xen is disabled we don't compile accel/xen/ and so there is no actual implementation of the function in the link. This doesn't happen for KVM because there the CONFIG_KVM_IS_POSSIBLE version of kvm_enabled() is a #define: #define kvm_enabled() (kvm_allowed) and we provide both the "real" version of the 'bool kvm_allowed' in accel/kvm/kvm-all.c and also the stub version in accel/stubs/kvm-stub.c which will be used in configurations thta don't build accel/kvm. I think then that the fix for this build failure is to either: (1) add a stub version of xen_allowed() to accel/stubs/xen-stub.c (which would always return false) (2) follow KVM more closely, and have xen_allowed() be a #define to (xen_allowed), with a (non-static) bool xen_allowed in accel/xen/xen-all.c and another one in accel/stubs/xen-stub.c thanks -- PMM
