Re: [PULL 0/4] Python queue for 5.0 soft freeze
On 3/20/20 5:14 PM, Peter Maydell wrote: On Fri, 20 Mar 2020 at 16:11, Philippe Mathieu-Daudé wrote: On 3/20/20 4:59 PM, Peter Maydell wrote: On Wed, 18 Mar 2020 at 01:12, Eduardo Habkost wrote: The following changes since commit d649689a8ecb2e276cc20d3af6d416e3c299cb17: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-03-17 18:33:05 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/python-next-pull-request for you to fetch changes up to f4abfc6cb037da951e7977a67171f361fc6d21d7: MAINTAINERS: add simplebench (2020-03-17 21:09:26 -0400) Python queue for 5.0 soft freeze * Add scripts/simplebench (Vladimir Sementsov-Ogievskiy) Applied, thanks. I guess there was a mis understanding with Eduardo, he was going to resend this pullrequest due to: ERROR: please use python3 interpreter Ah, sorry. I'd read the replies to this thread as meaning that those things were OK to fix as followup patches rather than requiring a respin of the pull. As you noticed, scripts/simplebench/bench_block_job.py is not run in our tests, so no need to hold the other pull requests, we'll fix later. Thanks, Phil.
Re: [PULL 0/4] Python queue for 5.0 soft freeze
On Fri, 20 Mar 2020 at 16:11, Philippe Mathieu-Daudé wrote: > > On 3/20/20 4:59 PM, Peter Maydell wrote: > > On Wed, 18 Mar 2020 at 01:12, Eduardo Habkost wrote: > >> > >> The following changes since commit > >> d649689a8ecb2e276cc20d3af6d416e3c299cb17: > >> > >>Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > >> staging (2020-03-17 18:33:05 +) > >> > >> are available in the Git repository at: > >> > >>git://github.com/ehabkost/qemu.git tags/python-next-pull-request > >> > >> for you to fetch changes up to f4abfc6cb037da951e7977a67171f361fc6d21d7: > >> > >>MAINTAINERS: add simplebench (2020-03-17 21:09:26 -0400) > >> > >> > >> Python queue for 5.0 soft freeze > >> > >> * Add scripts/simplebench (Vladimir Sementsov-Ogievskiy) > >> > > > > > > Applied, thanks. > > I guess there was a mis understanding with Eduardo, he was going to > resend this pullrequest due to: > > ERROR: please use python3 interpreter Ah, sorry. I'd read the replies to this thread as meaning that those things were OK to fix as followup patches rather than requiring a respin of the pull. thanks -- PMM
Re: [PULL 0/4] Python queue for 5.0 soft freeze
On 3/20/20 4:59 PM, Peter Maydell wrote: On Wed, 18 Mar 2020 at 01:12, Eduardo Habkost wrote: The following changes since commit d649689a8ecb2e276cc20d3af6d416e3c299cb17: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-03-17 18:33:05 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/python-next-pull-request for you to fetch changes up to f4abfc6cb037da951e7977a67171f361fc6d21d7: MAINTAINERS: add simplebench (2020-03-17 21:09:26 -0400) Python queue for 5.0 soft freeze * Add scripts/simplebench (Vladimir Sementsov-Ogievskiy) Applied, thanks. I guess there was a mis understanding with Eduardo, he was going to resend this pullrequest due to: ERROR: please use python3 interpreter #21: FILE: scripts/simplebench/bench_block_job.py:1: +#!/usr/bin/env python This was replied on the series cover: https://www.mail-archive.com/qemu-devel@nongnu.org/msg690373.html Can we apply Vladimir directly patch as a build-fix on top of the merge commit 3d0ac346? https://www.mail-archive.com/qemu-devel@nongnu.org/msg690385.html Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM
Re: [PULL 0/4] Python queue for 5.0 soft freeze
On Wed, 18 Mar 2020 at 01:12, Eduardo Habkost wrote: > > The following changes since commit d649689a8ecb2e276cc20d3af6d416e3c299cb17: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2020-03-17 18:33:05 +) > > are available in the Git repository at: > > git://github.com/ehabkost/qemu.git tags/python-next-pull-request > > for you to fetch changes up to f4abfc6cb037da951e7977a67171f361fc6d21d7: > > MAINTAINERS: add simplebench (2020-03-17 21:09:26 -0400) > > > Python queue for 5.0 soft freeze > > * Add scripts/simplebench (Vladimir Sementsov-Ogievskiy) > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM
Re: [PULL 0/4] Python queue for 5.0 soft freeze
сре, 18. мар 2020. у 17:13 Eduardo Habkost је написао/ла: > > On Wed, Mar 18, 2020 at 10:59:22AM +0300, Vladimir Sementsov-Ogievskiy wrote: > > 18.03.2020 7:12, no-re...@patchew.org wrote: > > > Patchew URL: > > > https://patchew.org/QEMU/20200318011217.2102748-1-ehabk...@redhat.com/ > > > > > > > > > > > > Hi, > > > > > > This series seems to have some coding style problems. See output below for > > > more information: > > > > > > Subject: [PULL 0/4] Python queue for 5.0 soft freeze > > > Message-id: 20200318011217.2102748-1-ehabk...@redhat.com > > > Type: series > > > > > > === TEST SCRIPT BEGIN === > > > #!/bin/bash > > > git rev-parse base > /dev/null || exit 0 > > > git config --local diff.renamelimit 0 > > > git config --local diff.renames True > > > git config --local diff.algorithm histogram > > > ./scripts/checkpatch.pl --mailback base.. > > > === TEST SCRIPT END === > > > > > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > > > Switched to a new branch 'test' > > > 1b4f6f3 MAINTAINERS: add simplebench > > > 57b42b6 scripts/simplebench: add example usage of simplebench > > > 99ea4d7 scripts/simplebench: add qemu/bench_block_job.py > > > 196f97d scripts/simplebench: add simplebench.py > > > > > > === OUTPUT BEGIN === > > > 1/4 Checking commit 196f97d8566d (scripts/simplebench: add simplebench.py) > > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > > > #16: > > > new file mode 100644 > > > > > > ERROR: please use python3 interpreter > > > #21: FILE: scripts/simplebench/simplebench.py:1: > > > +#!/usr/bin/env python > > > > Hmm, yes, we need to fix it. > > > > Should I resend? > > > > Just send that as follow up bug fixes. No need to resend the > whole series. > Vladimir, you can send as follow-up fixes those changes in output format that we both agree are needed for nicer output. Thanks, Aleksandar > -- > Eduardo > >
Re: [PULL 0/4] Python queue for 5.0 soft freeze
On Wed, Mar 18, 2020 at 10:59:22AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 18.03.2020 7:12, no-re...@patchew.org wrote: > > Patchew URL: > > https://patchew.org/QEMU/20200318011217.2102748-1-ehabk...@redhat.com/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more information: > > > > Subject: [PULL 0/4] Python queue for 5.0 soft freeze > > Message-id: 20200318011217.2102748-1-ehabk...@redhat.com > > Type: series > > > > === TEST SCRIPT BEGIN === > > #!/bin/bash > > git rev-parse base > /dev/null || exit 0 > > git config --local diff.renamelimit 0 > > git config --local diff.renames True > > git config --local diff.algorithm histogram > > ./scripts/checkpatch.pl --mailback base.. > > === TEST SCRIPT END === > > > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > > Switched to a new branch 'test' > > 1b4f6f3 MAINTAINERS: add simplebench > > 57b42b6 scripts/simplebench: add example usage of simplebench > > 99ea4d7 scripts/simplebench: add qemu/bench_block_job.py > > 196f97d scripts/simplebench: add simplebench.py > > > > === OUTPUT BEGIN === > > 1/4 Checking commit 196f97d8566d (scripts/simplebench: add simplebench.py) > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > > #16: > > new file mode 100644 > > > > ERROR: please use python3 interpreter > > #21: FILE: scripts/simplebench/simplebench.py:1: > > +#!/usr/bin/env python > > Hmm, yes, we need to fix it. > > Should I resend? > Just send that as follow up bug fixes. No need to resend the whole series. -- Eduardo
Re: [PULL 0/4] Python queue for 5.0 soft freeze
18.03.2020 7:12, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200318011217.2102748-1-ehabk...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/4] Python queue for 5.0 soft freeze Message-id: 20200318011217.2102748-1-ehabk...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 1b4f6f3 MAINTAINERS: add simplebench 57b42b6 scripts/simplebench: add example usage of simplebench 99ea4d7 scripts/simplebench: add qemu/bench_block_job.py 196f97d scripts/simplebench: add simplebench.py === OUTPUT BEGIN === 1/4 Checking commit 196f97d8566d (scripts/simplebench: add simplebench.py) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 ERROR: please use python3 interpreter #21: FILE: scripts/simplebench/simplebench.py:1: +#!/usr/bin/env python Hmm, yes, we need to fix it. Should I resend? total: 1 errors, 1 warnings, 128 lines checked Patch 1/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/4 Checking commit 99ea4d73bba8 (scripts/simplebench: add qemu/bench_block_job.py) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100755 ERROR: please use python3 interpreter #21: FILE: scripts/simplebench/bench_block_job.py:1: +#!/usr/bin/env python and here. total: 1 errors, 1 warnings, 119 lines checked Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/4 Checking commit 57b42b691f7b (scripts/simplebench: add example usage of simplebench) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 80 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit 1b4f6f3850f4 (MAINTAINERS: add simplebench) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200318011217.2102748-1-ehabk...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com -- Best regards, Vladimir
Re: [PULL 0/4] Python queue for 5.0 soft freeze
Patchew URL: https://patchew.org/QEMU/20200318011217.2102748-1-ehabk...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/4] Python queue for 5.0 soft freeze Message-id: 20200318011217.2102748-1-ehabk...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 1b4f6f3 MAINTAINERS: add simplebench 57b42b6 scripts/simplebench: add example usage of simplebench 99ea4d7 scripts/simplebench: add qemu/bench_block_job.py 196f97d scripts/simplebench: add simplebench.py === OUTPUT BEGIN === 1/4 Checking commit 196f97d8566d (scripts/simplebench: add simplebench.py) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 ERROR: please use python3 interpreter #21: FILE: scripts/simplebench/simplebench.py:1: +#!/usr/bin/env python total: 1 errors, 1 warnings, 128 lines checked Patch 1/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/4 Checking commit 99ea4d73bba8 (scripts/simplebench: add qemu/bench_block_job.py) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100755 ERROR: please use python3 interpreter #21: FILE: scripts/simplebench/bench_block_job.py:1: +#!/usr/bin/env python total: 1 errors, 1 warnings, 119 lines checked Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/4 Checking commit 57b42b691f7b (scripts/simplebench: add example usage of simplebench) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 80 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit 1b4f6f3850f4 (MAINTAINERS: add simplebench) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200318011217.2102748-1-ehabk...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
