Re: [PULL 0/5] tcg patch queue
On 5/23/24 09:15, Richard Henderson wrote: The following changes since commit 7e1c0047015ffbd408e1aa4a5ec1abe4751dbf7e: Merge tag 'migration-20240522-pull-request' ofhttps://gitlab.com/farosas/qemu into staging (2024-05-22 15:32:25 -0700) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240523 for you to fetch changes up to bfd43cccab9fb77b8405ca556fc2f2ed3b2920a3: accel/tcg: Init tb size and icount before plugin_gen_tb_end (2024-05-22 19:05:26 -0700) tcg: Introduce TCG_TARGET_HAS_tst_vec accel/tcg: Init tb size and icount before plugin_gen_tb_end Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/9.1 as appropriate. r~
Re: [PULL 0/5] tcg patch queue
On 1/19/23 23:41, Thomas Huth wrote:
On 16/01/2023 23.36, Richard Henderson wrote:
The following changes since commit fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
tests/qtest/qom-test: Do not print tested properties by default (2023-01-16 15:00:57
+)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230116
for you to fetch changes up to 61710a7e23a63546da0071ea32adb96476fa5d07:
accel/tcg: Split out cpu_exec_{setjmp,loop} (2023-01-16 10:14:12 -1000)
- Reorg cpu_tb_exec around setjmp.
- Use __attribute__((target)) for buffer_is_zero.
- Add perfmap and jitdump for perf support.
Ilya Leoshkevich (3):
linux-user: Clean up when exiting due to a signal
accel/tcg: Add debuginfo support
tcg: add perfmap and jitdump
Richard Henderson (2):
util/bufferiszero: Use __attribute__((target)) for avx2/avx512
accel/tcg: Split out cpu_exec_{setjmp,loop}
Hi Richard, hi Ilya,
with the recent QEMU master branch (commit 701ed34), I'm now seeing failures in
Travis:
https://app.travis-ci.com/github/huth/qemu/jobs/593786529#L14411
Everything was still fine a couple of days ago (commit fb7e799):
https://app.travis-ci.com/github/huth/qemu/builds/259755664
... so it seems this is likely related to this pull request. Could you please
have a look?
Thankfully our s390x.ci.qemu.org has the same version gcc installed, and I was able to
reproduce this. But only once -- it's irregular and very low frequency.
The code generated by gcc is correct and easy to inspect, since cpu_exec_setjmp is now
quite small:
000f3250 :
f3250: eb 6f f0 30 00 24 stmg%r6,%r15,48(%r15)
f3256: a7 39 00 00 lghi%r3,0
f325a: e3 f0 ff 58 ff 71 lay %r15,-168(%r15)
// Save cpu to stack+160.
f3260: e3 20 f0 a0 00 24 stg %r2,160(%r15)
f3266: 41 20 20 f0 la %r2,240(%r2)
f326a: c0 e5 ff fb 10 eb brasl %r14,55440 <__sigsetjmp@plt>
f3270: ec 26 00 0d 00 7e cijne %r2,0,f328a
// Reload cpu for cpu_exec_loop().
f3276: e3 20 f0 a0 00 04 lg %r2,160(%r15)
f327c: c0 e5 ff ff fb ee brasl %r14,f2a58
f3282: eb 6f f0 d8 00 04 lmg %r6,%r15,216(%r15)
f3288: 07 fe br %r14
// Load tls pointer and current_cpu
address.
f328a: b2 4f 00 10 ear %r1,%a0
f328e: c0 20 00 0a 35 9d larl%r2,239dc8
f3294: eb 11 00 20 00 0d sllg%r1,%r1,32
f329a: e3 20 20 00 00 04 lg %r2,0(%r2)
f32a0: b2 4f 00 11 ear %r1,%a1
// Reload cpu for comparison
f32a4: e3 30 f0 a0 00 04 lg %r3,160(%r15)
// cpu == current_cpu
f32aa: e3 32 10 00 00 20 cg %r3,0(%r2,%r1)
f32b0: a7 84 00 12 je f32d4
...
The only way I can imagine that this comparison fails is if we have corrupted the stack in
some way. I have not been able to induce failure under any sort of debugging, and I can't
imagine where irregular corruption would have come from.
r~
r~
Re: [PULL 0/5] tcg patch queue
Thomas Huth writes:
> On 20/01/2023 11.53, Ilya Leoshkevich wrote:
>> On Fri, 2023-01-20 at 10:41 +0100, Thomas Huth wrote:
>>> On 16/01/2023 23.36, Richard Henderson wrote:
The following changes since commit
fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
tests/qtest/qom-test: Do not print tested properties by default
(2023-01-16 15:00:57 +)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230116
for you to fetch changes up to
61710a7e23a63546da0071ea32adb96476fa5d07:
accel/tcg: Split out cpu_exec_{setjmp,loop} (2023-01-16 10:14:12
-1000)
- Reorg cpu_tb_exec around setjmp.
- Use __attribute__((target)) for buffer_is_zero.
- Add perfmap and jitdump for perf support.
Ilya Leoshkevich (3):
linux-user: Clean up when exiting due to a signal
accel/tcg: Add debuginfo support
tcg: add perfmap and jitdump
Richard Henderson (2):
util/bufferiszero: Use __attribute__((target)) for
avx2/avx512
accel/tcg: Split out cpu_exec_{setjmp,loop}
>>>
>>> Hi Richard, hi Ilya,
>>>
>>> with the recent QEMU master branch (commit 701ed34), I'm now seeing
>>> failures
>>> in Travis:
>>>
>>> https://app.travis-ci.com/github/huth/qemu/jobs/593786529#L14411
>>>
>>> Everything was still fine a couple of days ago (commit fb7e799):
>>>
>>> https://app.travis-ci.com/github/huth/qemu/builds/259755664
>>>
>>> ... so it seems this is likely related to this pull request. Could
>>> you
>>> please have a look?
>>>
>>> Thanks,
>>> Thomas
>>>
>> I would expect this to be (temporarily) fixed by [1], but we
>> probably
>> don't set GITLAB_CI in Travis. Would it make sense to set it? It looks
>> as if this variable is currently used only to skip certain tests.
>> If not, then maybe split it into QEMU_CI, GITLAB_CI and TRAVIS_CI?
>> https://lists.gnu.org/archive/html/qemu-devel/2023-01/msg04438.html
>
> Ah, ok, so this test has issues in gitlab, too!
*sigh* yeah the test is flaky but this is a subtly different failure
mode. All the gitlab failures I saw where the test triggering the abort
rather than the assert catch we have here.
>
> For Travis, I think we should either check the CI or TRAVIS
> environment variables:
>
>
> https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
>
> Thomas
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Re: [PULL 0/5] tcg patch queue
On 20/01/2023 11.53, Ilya Leoshkevich wrote:
On Fri, 2023-01-20 at 10:41 +0100, Thomas Huth wrote:
On 16/01/2023 23.36, Richard Henderson wrote:
The following changes since commit
fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
tests/qtest/qom-test: Do not print tested properties by default
(2023-01-16 15:00:57 +)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230116
for you to fetch changes up to
61710a7e23a63546da0071ea32adb96476fa5d07:
accel/tcg: Split out cpu_exec_{setjmp,loop} (2023-01-16 10:14:12
-1000)
- Reorg cpu_tb_exec around setjmp.
- Use __attribute__((target)) for buffer_is_zero.
- Add perfmap and jitdump for perf support.
Ilya Leoshkevich (3):
linux-user: Clean up when exiting due to a signal
accel/tcg: Add debuginfo support
tcg: add perfmap and jitdump
Richard Henderson (2):
util/bufferiszero: Use __attribute__((target)) for
avx2/avx512
accel/tcg: Split out cpu_exec_{setjmp,loop}
Hi Richard, hi Ilya,
with the recent QEMU master branch (commit 701ed34), I'm now seeing
failures
in Travis:
https://app.travis-ci.com/github/huth/qemu/jobs/593786529#L14411
Everything was still fine a couple of days ago (commit fb7e799):
https://app.travis-ci.com/github/huth/qemu/builds/259755664
... so it seems this is likely related to this pull request. Could
you
please have a look?
Thanks,
Thomas
I would expect this to be (temporarily) fixed by [1], but we probably
don't set GITLAB_CI in Travis. Would it make sense to set it? It looks
as if this variable is currently used only to skip certain tests.
If not, then maybe split it into QEMU_CI, GITLAB_CI and TRAVIS_CI?
https://lists.gnu.org/archive/html/qemu-devel/2023-01/msg04438.html
Ah, ok, so this test has issues in gitlab, too!
For Travis, I think we should either check the CI or TRAVIS environment
variables:
https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
Thomas
Re: [PULL 0/5] tcg patch queue
On Fri, 2023-01-20 at 10:41 +0100, Thomas Huth wrote:
> On 16/01/2023 23.36, Richard Henderson wrote:
> > The following changes since commit
> > fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
> >
> > tests/qtest/qom-test: Do not print tested properties by default
> > (2023-01-16 15:00:57 +)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230116
> >
> > for you to fetch changes up to
> > 61710a7e23a63546da0071ea32adb96476fa5d07:
> >
> > accel/tcg: Split out cpu_exec_{setjmp,loop} (2023-01-16 10:14:12
> > -1000)
> >
> >
> > - Reorg cpu_tb_exec around setjmp.
> > - Use __attribute__((target)) for buffer_is_zero.
> > - Add perfmap and jitdump for perf support.
> >
> >
> > Ilya Leoshkevich (3):
> > linux-user: Clean up when exiting due to a signal
> > accel/tcg: Add debuginfo support
> > tcg: add perfmap and jitdump
> >
> > Richard Henderson (2):
> > util/bufferiszero: Use __attribute__((target)) for
> > avx2/avx512
> > accel/tcg: Split out cpu_exec_{setjmp,loop}
>
> Hi Richard, hi Ilya,
>
> with the recent QEMU master branch (commit 701ed34), I'm now seeing
> failures
> in Travis:
>
> https://app.travis-ci.com/github/huth/qemu/jobs/593786529#L14411
>
> Everything was still fine a couple of days ago (commit fb7e799):
>
> https://app.travis-ci.com/github/huth/qemu/builds/259755664
>
> ... so it seems this is likely related to this pull request. Could
> you
> please have a look?
>
> Thanks,
> Thomas
>
I would expect this to be (temporarily) fixed by [1], but we probably
don't set GITLAB_CI in Travis. Would it make sense to set it? It looks
as if this variable is currently used only to skip certain tests.
If not, then maybe split it into QEMU_CI, GITLAB_CI and TRAVIS_CI?
https://lists.gnu.org/archive/html/qemu-devel/2023-01/msg04438.html
Re: [PULL 0/5] tcg patch queue
Thomas Huth writes:
> On 16/01/2023 23.36, Richard Henderson wrote:
>> The following changes since commit fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
>>tests/qtest/qom-test: Do not print tested properties by default
>> (2023-01-16 15:00:57 +)
>> are available in the Git repository at:
>>https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230116
>> for you to fetch changes up to
>> 61710a7e23a63546da0071ea32adb96476fa5d07:
>>accel/tcg: Split out cpu_exec_{setjmp,loop} (2023-01-16 10:14:12
>> -1000)
>>
>> - Reorg cpu_tb_exec around setjmp.
>> - Use __attribute__((target)) for buffer_is_zero.
>> - Add perfmap and jitdump for perf support.
>>
>> Ilya Leoshkevich (3):
>>linux-user: Clean up when exiting due to a signal
>>accel/tcg: Add debuginfo support
>>tcg: add perfmap and jitdump
>> Richard Henderson (2):
>>util/bufferiszero: Use __attribute__((target)) for avx2/avx512
>>accel/tcg: Split out cpu_exec_{setjmp,loop}
>
> Hi Richard, hi Ilya,
>
> with the recent QEMU master branch (commit 701ed34), I'm now seeing
> failures in Travis:
>
> https://app.travis-ci.com/github/huth/qemu/jobs/593786529#L14411
>
> Everything was still fine a couple of days ago (commit fb7e799):
>
> https://app.travis-ci.com/github/huth/qemu/builds/259755664
>
> ... so it seems this is likely related to this pull request. Could you
> please have a look?
Hmm maybe the code motion has revealed another form of the compiler bug.
I guess these bugs don't die, they just refract.
>
> Thanks,
> Thomas
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Re: [PULL 0/5] tcg patch queue
On 16/01/2023 23.36, Richard Henderson wrote:
The following changes since commit fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
tests/qtest/qom-test: Do not print tested properties by default (2023-01-16
15:00:57 +)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230116
for you to fetch changes up to 61710a7e23a63546da0071ea32adb96476fa5d07:
accel/tcg: Split out cpu_exec_{setjmp,loop} (2023-01-16 10:14:12 -1000)
- Reorg cpu_tb_exec around setjmp.
- Use __attribute__((target)) for buffer_is_zero.
- Add perfmap and jitdump for perf support.
Ilya Leoshkevich (3):
linux-user: Clean up when exiting due to a signal
accel/tcg: Add debuginfo support
tcg: add perfmap and jitdump
Richard Henderson (2):
util/bufferiszero: Use __attribute__((target)) for avx2/avx512
accel/tcg: Split out cpu_exec_{setjmp,loop}
Hi Richard, hi Ilya,
with the recent QEMU master branch (commit 701ed34), I'm now seeing failures
in Travis:
https://app.travis-ci.com/github/huth/qemu/jobs/593786529#L14411
Everything was still fine a couple of days ago (commit fb7e799):
https://app.travis-ci.com/github/huth/qemu/builds/259755664
... so it seems this is likely related to this pull request. Could you
please have a look?
Thanks,
Thomas
Re: [PULL 0/5] tcg patch queue
On Mon, 16 Jan 2023 at 22:36, Richard Henderson
wrote:
>
> The following changes since commit fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
>
> tests/qtest/qom-test: Do not print tested properties by default (2023-01-16
> 15:00:57 +)
>
> are available in the Git repository at:
>
> https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230116
>
> for you to fetch changes up to 61710a7e23a63546da0071ea32adb96476fa5d07:
>
> accel/tcg: Split out cpu_exec_{setjmp,loop} (2023-01-16 10:14:12 -1000)
>
>
> - Reorg cpu_tb_exec around setjmp.
> - Use __attribute__((target)) for buffer_is_zero.
> - Add perfmap and jitdump for perf support.
>
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.0
for any user-visible changes.
-- PMM
Re: [PULL 0/5] tcg patch queue
On Sat, 1 May 2021 at 19:51, Richard Henderson wrote: > > The following changes since commit 8f860d2633baf9c2b6261f703f86e394c6bc22ca: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-04-30' > into staging (2021-04-30 16:02:00 +0100) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210501 > > for you to fetch changes up to af93ccacc772019298be4c3e47251cdaa60d0c21: > > decodetree: Extend argument set syntax to allow types (2021-05-01 11:45:35 > -0700) > > > Include cleanups. > Decodetree enhancements for power10. Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1 for any user-visible changes. -- PMM
Re: [PULL 0/5] tcg patch queue
Patchew URL:
https://patchew.org/QEMU/20210501185116.1338875-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210501185116.1338875-1-richard.hender...@linaro.org
Subject: [PULL 0/5] tcg patch queue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/20210501185116.1338875-1-richard.hender...@linaro.org ->
patchew/20210501185116.1338875-1-richard.hender...@linaro.org
Switched to a new branch 'test'
3f52d0d decodetree: Extend argument set syntax to allow types
2f170a4 decodetree: Add support for 64-bit instructions
6567eed decodetree: More use of f-strings
95caca8 decodetree: Introduce whex and whexC helpers
b9a64b1 exec: Remove accel/tcg/ from include paths
=== OUTPUT BEGIN ===
1/5 Checking commit b9a64b13ad89 (exec: Remove accel/tcg/ from include paths)
2/5 Checking commit 95caca818e08 (decodetree: Introduce whex and whexC helpers)
ERROR: line over 90 characters
#52: FILE: scripts/decodetree.py:495:
+output(ind, f'if ((insn & {whexC(innermask)}) ==
{whexC(innerbits)}) {{\n')
WARNING: line over 80 characters
#53: FILE: scripts/decodetree.py:496:
+output(ind, f'/* {str_match_bits(p.fixedbits,
p.fixedmask)} */\n')
total: 1 errors, 1 warnings, 136 lines checked
Patch 2/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/5 Checking commit 6567eed04461 (decodetree: More use of f-strings)
4/5 Checking commit 2f170a408195 (decodetree: Add support for 64-bit
instructions)
WARNING: line over 80 characters
#75: FILE: scripts/decodetree.py:236:
+ret = f'deposit{bitop_width}({ret}, {pos}, {bitop_width -
pos}, {ext})'
total: 0 errors, 1 warnings, 63 lines checked
Patch 4/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/5 Checking commit 3f52d0d96c42 (decodetree: Extend argument set syntax to
allow types)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#156:
new file mode 100644
total: 0 errors, 1 warnings, 121 lines checked
Patch 5/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210501185116.1338875-1-richard.hender...@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [PULL 0/5] tcg patch queue for 6.0
On Wed, 24 Mar 2021 at 01:43, Richard Henderson wrote: > > The following changes since commit 266469947161aa10b1d36843580d369d5aa38589: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-03-23' > into staging (2021-03-23 22:28:58 +) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-tcg-20210323 > > for you to fetch changes up to 44b99a6d5f24afcd8476d0d2701e1ca4ab9b35c1: > > exec: Build page-vary-common.c with -fno-lto (2021-03-23 19:36:47 -0600) > > > Workaround for macos mprotect > Workaround for target_page vs -flto > > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0 for any user-visible changes. -- PMM
Re: [PULL 0/5] tcg patch queue
On Thu, 3 Sep 2020 at 22:41, Richard Henderson wrote: > > The following changes since commit 3dd23a4fb8fd72d2220a90a809f213999ffe7f3a: > > Merge remote-tracking branch 'remotes/legoater/tags/pull-aspeed-20200901' > into staging (2020-09-03 14:12:48 +0100) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-tcg-20200903 > > for you to fetch changes up to fe4b0b5bfa96c38ad1cad0689a86cca9f307e353: > > tcg: Implement 256-bit dup for tcg_gen_gvec_dup_mem (2020-09-03 13:13:58 > -0700) > > > Improve inlining in cputlb.c. > Fix vector abs fallback. > Only set parallel_cpus for SMP. > Add vector dupm for 256-bit elements. > > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM
Re: [PULL 0/5] tcg patch queue
On Tue, 17 Mar 2020 at 19:00, Richard Henderson wrote: > > The following changes since commit 40c67636f67c2a89745f2e698522fe917326a952: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20200317-pull-request' into staging (2020-03-17 > 14:00:56 +) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-tcg-20200317 > > for you to fetch changes up to 0270bd503e3699b7202200a2d693ad1feb57473f: > > tcg: Remove tcg-runtime-gvec.c DO_CMP0 (2020-03-17 08:41:07 -0700) > > > Fix tcg/i386 bug vs sari_vec. > Fix tcg-runtime-gvec.c vs i386 without avx. > > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM
Re: [PULL 0/5] tcg patch queue
Patchew URL: https://patchew.org/QEMU/20200317190013.25036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/5] tcg patch queue Message-id: 20200317190013.25036-1-richard.hender...@linaro.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 83eaadd tcg: Remove tcg-runtime-gvec.c DO_CMP0 e0008a5 tcg: Tidy tcg-runtime-gvec.c DUP* 8e7d6d3 tcg: Tidy tcg-runtime-gvec.c types 44bd3c5 tcg: Remove CONFIG_VECTOR16 f410c29 tcg/i386: Bound shift count expanding sari_vec === OUTPUT BEGIN === 1/5 Checking commit f410c296b774 (tcg/i386: Bound shift count expanding sari_vec) 2/5 Checking commit 44bd3c5fbbdb (tcg: Remove CONFIG_VECTOR16) 3/5 Checking commit 8e7d6d39c529 (tcg: Tidy tcg-runtime-gvec.c types) ERROR: spaces required around that '&' (ctx:WxO) #442: FILE: accel/tcg/tcg-runtime-gvec.c:510: +*(uint64_t *)(d + i) = *(uint64_t *)(a + i) &~ *(uint64_t *)(b + i); ^ ERROR: space prohibited after that '~' (ctx:OxW) #442: FILE: accel/tcg/tcg-runtime-gvec.c:510: +*(uint64_t *)(d + i) = *(uint64_t *)(a + i) &~ *(uint64_t *)(b + i); ^ ERROR: spaces required around that '|' (ctx:WxO) #453: FILE: accel/tcg/tcg-runtime-gvec.c:521: +*(uint64_t *)(d + i) = *(uint64_t *)(a + i) |~ *(uint64_t *)(b + i); ^ ERROR: space prohibited after that '~' (ctx:OxW) #453: FILE: accel/tcg/tcg-runtime-gvec.c:521: +*(uint64_t *)(d + i) = *(uint64_t *)(a + i) |~ *(uint64_t *)(b + i); ^ ERROR: spaces required around that '==' (ctx:WxB) #677: FILE: accel/tcg/tcg-runtime-gvec.c:897: +DO_CMP1(gvec_eq##SZ, uint##SZ##_t, ==)\ ^ ERROR: spaces required around that '!=' (ctx:WxB) #678: FILE: accel/tcg/tcg-runtime-gvec.c:898: +DO_CMP1(gvec_ne##SZ, uint##SZ##_t, !=)\ ^ ERROR: spaces required around that '<' (ctx:WxB) #679: FILE: accel/tcg/tcg-runtime-gvec.c:899: +DO_CMP1(gvec_lt##SZ, int##SZ##_t, <) \ ^ ERROR: spaces required around that '<=' (ctx:WxB) #680: FILE: accel/tcg/tcg-runtime-gvec.c:900: +DO_CMP1(gvec_le##SZ, int##SZ##_t, <=) \ ^ ERROR: spaces required around that '<' (ctx:WxB) #681: FILE: accel/tcg/tcg-runtime-gvec.c:901: +DO_CMP1(gvec_ltu##SZ, uint##SZ##_t, <)\ ^ ERROR: spaces required around that '<=' (ctx:WxB) #682: FILE: accel/tcg/tcg-runtime-gvec.c:902: +DO_CMP1(gvec_leu##SZ, uint##SZ##_t, <=) ^ total: 10 errors, 0 warnings, 630 lines checked Patch 3/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/5 Checking commit e0008a500fbb (tcg: Tidy tcg-runtime-gvec.c DUP*) 5/5 Checking commit 83eaadd6af23 (tcg: Remove tcg-runtime-gvec.c DO_CMP0) ERROR: spaces required around that '*' (ctx:WxV) #30: FILE: accel/tcg/tcg-runtime-gvec.c:869: +*(TYPE *)(d + i) = -(*(TYPE *)(a + i) OP *(TYPE *)(b + i));\ ^ total: 1 errors, 0 warnings, 23 lines checked Patch 5/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200317190013.25036-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
