Re: [Qemu-devel] [PATCH] USB: add usb network redirection support

[Hans de Goede]

Hi,

On 07/18/2011 04:33 PM, Gerd Hoffmann wrote:

On 07/18/11 09:13, Hans de Goede wrote:

This patch adds support for a usb-redir device, which takes a chardev
as a communication channel to an actual usbdevice using the usbredir protocol.

Compiling the usb-redir device requires usbredir-0.3 to be installed for
the usbredir protocol parser, usbredir-0.3 also contains a server for
redirecting usb traffic from an actual usb device. You can get the 0.3
release of usbredir here:
http://people.fedoraproject.org/~jwrdegoede/usbredir-0.3.tar.bz2
(getting a more formal site for it is a WIP)


Looks good overall. scripts/checkpatch.pl has a bunch of codestyle complains 
which need to be fixed.


Sorry, I should have though of running checkpatch before submitting myself,
new version coming up.

Regards,

Hans

Re: [Qemu-devel] [PATCH] USB: add usb network redirection support

[Hans de Goede]

Hi,

Note that using this with devices where a lot of data is send to the device
(ie a usb stick and writing to it a lot) may lead to increased latencies, due
to the long missing flowcontrol support in chardev in one direction.

For those interested, my personal tree contains Amit's flowcontrol patches
ported to the latest qemu-git + a version of the usb-redir patch with
flowcontrol support:
http://cgit.freedesktop.org/~jwrdegoede/qemu/log/?h=usbredir

Regards,

Hans

Re: [Qemu-devel] [PATCH] USB: add usb network redirection support

[Hans de Goede]

p.s.

For people wishing to give this a try, usbredir-0.3 needs a
libusb-1.0.9 git snapshot (a 1.0.9 release is longer
overdue).

In the mean time grab the usbredir branch from my libusb repo
and use that:
http://cgit.freedesktop.org/~jwrdegoede/libusb/log/?h=usbredir

Regards,

Hans

Re: [Qemu-devel] [PATCH] USB: add usb network redirection support

[Gerd Hoffmann]

On 07/18/11 09:13, Hans de Goede wrote:

This patch adds support for a usb-redir device, which takes a chardev
as a communication channel to an actual usbdevice using the usbredir protocol.

Compiling the usb-redir device requires usbredir-0.3 to be installed for
the usbredir protocol parser, usbredir-0.3 also contains a server for
redirecting usb traffic from an actual usb device. You can get the 0.3
release of usbredir here:
http://people.fedoraproject.org/~jwrdegoede/usbredir-0.3.tar.bz2
(getting a more formal site for it is a WIP)


Looks good overall.  scripts/checkpatch.pl has a bunch of codestyle 
complains which need to be fixed.


cheers,
  Gerd