Re: [Qemu-devel] [PATCH] e1000: disable debug by default

2017-03-28 Thread Jason Wang 



On 2017年03月22日 11:07, Jason Wang wrote:

Disable debug output by default, the information were not needed for
release.

Cc: Peter Maydell 
Cc: Stefan Hajnoczi 
Cc: Leonid Bloch 
Cc: Dmitry Fleytman 
Cc: qemu-sta...@nongnu.org
Signed-off-by: Jason Wang 
---
  hw/net/e1000.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 9324949..f2e5072 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -40,7 +40,7 @@
  
  static const uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
  
-#define E1000_DEBUG

+/* #define E1000_DEBUG */
  
  #ifdef E1000_DEBUG

  enum {


Applied, thanks.

Re: [Qemu-devel] [PATCH] e1000: disable debug by default

2017-03-23 Thread Stefan Hajnoczi 
On Wed, Mar 22, 2017 at 11:07:32AM +0800, Jason Wang wrote:
> Disable debug output by default, the information were not needed for
> release.
> 
> Cc: Peter Maydell 
> Cc: Stefan Hajnoczi 
> Cc: Leonid Bloch 
> Cc: Dmitry Fleytman 
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Jason Wang 
> ---
>  hw/net/e1000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature

Re: [Qemu-devel] [PATCH] e1000: disable debug by default

2017-03-22 Thread Philippe Mathieu-Daudé 

On 03/22/2017 12:07 AM, Jason Wang wrote:

Disable debug output by default, the information were not needed for
release.

Cc: Peter Maydell 
Cc: Stefan Hajnoczi 
Cc: Leonid Bloch 
Cc: Dmitry Fleytman 
Cc: qemu-sta...@nongnu.org
Signed-off-by: Jason Wang 


Reviewed-by: Philippe Mathieu-Daudé 


---
 hw/net/e1000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 9324949..f2e5072 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -40,7 +40,7 @@

 static const uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};

-#define E1000_DEBUG
+/* #define E1000_DEBUG */

 #ifdef E1000_DEBUG
 enum {