Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed

2011-08-03 Thread Gerd Hoffmann

On 07/21/11 20:52, Michael Walle wrote:

The QEMU keyboard and mouse reports themselves as full speed devices,
though they are actually low speed devices. Until this is fixed, claim that
we are supporting full speed devices.

Signed-off-by: Michael Wallemich...@walle.cc


For both master+stable:

Acked-by: Gerd Hoffmann kra...@redhat.com

cheers,
  Gerd



Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed

2011-08-03 Thread Edgar E. Iglesias
On Wed, Aug 03, 2011 at 03:17:07PM +0200, Gerd Hoffmann wrote:
 On 07/21/11 20:52, Michael Walle wrote:
 The QEMU keyboard and mouse reports themselves as full speed devices,
 though they are actually low speed devices. Until this is fixed, claim that
 we are supporting full speed devices.
 
 Signed-off-by: Michael Wallemich...@walle.cc
 
 For both master+stable:
 
 Acked-by: Gerd Hoffmann kra...@redhat.com


Thanks, I've applied it to both master and stable-0.15.

Cheers



Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed

2011-07-26 Thread Michael Walle

Hi Anthony,

could you please apply this patch to the 0.15 (and master) branch.


Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle:
 The QEMU keyboard and mouse reports themselves as full speed devices,
 though they are actually low speed devices. Until this is fixed, claim that
 we are supporting full speed devices.
 
 Signed-off-by: Michael Walle mich...@walle.cc
 ---
  hw/milkymist-softusb.c |6 --
  1 files changed, 4 insertions(+), 2 deletions(-)
 
 diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c
 index ce2bfc6..abf7b59 100644
 --- a/hw/milkymist-softusb.c
 +++ b/hw/milkymist-softusb.c
 @@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev)
  usb_bus_new(s-usbbus, softusb_bus_ops, NULL);
 
  /* our two ports */
 +/* FIXME: claim to support full speed devices. qemu mouse and keyboard
 + * report themselves as full speed devices. */
  usb_register_port(s-usbbus, s-usbport[0], NULL, 0, softusb_ops,
 -USB_SPEED_MASK_LOW);
 +USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
  usb_register_port(s-usbbus, s-usbport[1], NULL, 1, softusb_ops,
 -USB_SPEED_MASK_LOW);
 +USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
 
  /* and finally create an usb keyboard */
  s-usbdev = usb_create_simple(s-usbbus, usb-kbd);


-- 
Michael