Re: [Qemu-devel] [PATCH] net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'
On 2018年01月12日 04:02, Thomas Huth wrote: It does not make much sense to limit these commands to the legacy 'vlan' concept only, they should work with the modern netdevs, too. So now it is possible to use this command with one, two or three parameters. With one parameter, the command installs a hostfwd rule on the default "user" network: hostfwd_add tcp:... With two parameters, the command installs a hostfwd rule on a netdev (that's the new way of using this command): hostfwd_add netdev_id tcp:... With three parameters, the command installs a rule on a 'vlan' (aka hub): hostfwd_add hub_id name tcp:... Same applies to the hostfwd_remove command now. Signed-off-by: Thomas Huth Applied. Thanks
Re: [Qemu-devel] [PATCH] net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'
On Fri, 01/12 07:23, Thomas Huth wrote: > On 11.01.2018 21:41, no-re...@patchew.org wrote: > > Hi, > > > > This series failed build test on ppc host. Please find the details below. > [...] > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > > Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path > > 'dtc' > > Submodule 'pixman' (git://anongit.freedesktop.org/pixman) registered for > > path 'pixman' > > Submodule 'roms/SLOF' (git://git.qemu-project.org/SLOF.git) registered for > > path 'roms/SLOF' > > Submodule 'roms/ipxe' (git://git.qemu-project.org/ipxe.git) registered for > > path 'roms/ipxe' > > Submodule 'roms/openbios' (git://git.qemu-project.org/openbios.git) > > registered for path 'roms/openbios' > > Submodule 'roms/openhackware' (git://git.qemu-project.org/openhackware.git) > > registered for path 'roms/openhackware' > > Submodule 'roms/qemu-palcode' (git://github.com/rth7680/qemu-palcode.git) > > registered for path 'roms/qemu-palcode' > > Submodule 'roms/seabios' (git://git.qemu-project.org/seabios.git/) > > registered for path 'roms/seabios' > > Submodule 'roms/sgabios' (git://git.qemu-project.org/sgabios.git) > > registered for path 'roms/sgabios' > > Submodule 'roms/u-boot' (git://git.qemu-project.org/u-boot.git) registered > > for path 'roms/u-boot' > > Submodule 'roms/vgabios' (git://git.qemu-project.org/vgabios.git/) > > registered for path 'roms/vgabios' > > Cloning into 'dtc'... > > Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' > > fatal: remote error: access denied or repository not exported: /pixman > > Cloning into 'pixman'... > > Clone of 'git://anongit.freedesktop.org/pixman' into submodule path > > 'pixman' failed > > Hi Fam, > > why is patchew still trying to clone pixman? I thought we only use the > system pixman library nowadays? There is a bug in patchew tester that the git cache repo is not updated, so every time it starts from a very old commit. Will fix it soon. Fam
Re: [Qemu-devel] [PATCH] net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'
On 11.01.2018 21:41, no-re...@patchew.org wrote: > Hi, > > This series failed build test on ppc host. Please find the details below. [...] > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' > Submodule 'pixman' (git://anongit.freedesktop.org/pixman) registered for path > 'pixman' > Submodule 'roms/SLOF' (git://git.qemu-project.org/SLOF.git) registered for > path 'roms/SLOF' > Submodule 'roms/ipxe' (git://git.qemu-project.org/ipxe.git) registered for > path 'roms/ipxe' > Submodule 'roms/openbios' (git://git.qemu-project.org/openbios.git) > registered for path 'roms/openbios' > Submodule 'roms/openhackware' (git://git.qemu-project.org/openhackware.git) > registered for path 'roms/openhackware' > Submodule 'roms/qemu-palcode' (git://github.com/rth7680/qemu-palcode.git) > registered for path 'roms/qemu-palcode' > Submodule 'roms/seabios' (git://git.qemu-project.org/seabios.git/) registered > for path 'roms/seabios' > Submodule 'roms/sgabios' (git://git.qemu-project.org/sgabios.git) registered > for path 'roms/sgabios' > Submodule 'roms/u-boot' (git://git.qemu-project.org/u-boot.git) registered > for path 'roms/u-boot' > Submodule 'roms/vgabios' (git://git.qemu-project.org/vgabios.git/) registered > for path 'roms/vgabios' > Cloning into 'dtc'... > Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' > fatal: remote error: access denied or repository not exported: /pixman > Cloning into 'pixman'... > Clone of 'git://anongit.freedesktop.org/pixman' into submodule path 'pixman' > failed Hi Fam, why is patchew still trying to clone pixman? I thought we only use the system pixman library nowadays? Thomas
Re: [Qemu-devel] [PATCH] net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'
Hi, This series failed build test on ppc host. Please find the details below. Message-id: 1515700960-26388-1-git-send-email-th...@redhat.com Subject: [Qemu-devel] [PATCH] net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove' Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e echo "=== ENV ===" env echo "=== PACKAGES ===" rpm -qa echo "=== TEST BEGIN ===" INSTALL=$PWD/install BUILD=$PWD/build mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --prefix=$INSTALL make -j100 # XXX: we need reliable clean up # make check -j100 V=1 make install === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Submodule 'pixman' (git://anongit.freedesktop.org/pixman) registered for path 'pixman' Submodule 'roms/SLOF' (git://git.qemu-project.org/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (git://git.qemu-project.org/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (git://git.qemu-project.org/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (git://git.qemu-project.org/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (git://github.com/rth7680/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (git://git.qemu-project.org/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/sgabios' (git://git.qemu-project.org/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/u-boot' (git://git.qemu-project.org/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/vgabios' (git://git.qemu-project.org/vgabios.git/) registered for path 'roms/vgabios' Cloning into 'dtc'... Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' fatal: remote error: access denied or repository not exported: /pixman Cloning into 'pixman'... Clone of 'git://anongit.freedesktop.org/pixman' into submodule path 'pixman' failed Traceback (most recent call last): File "/home/patchew/patchew/patchew-cli", line 504, in test_one git_clone_repo(clone, r["repo"], r["head"], logf) File "/home/patchew/patchew/patchew-cli", line 50, in git_clone_repo stderr=logf, stdout=logf) File "/usr/lib64/python3.4/subprocess.py", line 558, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['git', 'clone', '-q', '--recursive', '/home/patchew/.cache/patchew-git-cache/httpsgithubcompatchewprojectqemu-3c8cf5a9c21ff8782164d1def7f44bd888713384', '/var/tmp/patchew-tester-tmp-obuk0xh7/src']' returned non-zero exit status 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org
Re: [Qemu-devel] [PATCH] net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1515700960-26388-1-git-send-email-th...@redhat.com Subject: [Qemu-devel] [PATCH] net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove' === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' cc59c7d510 net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove' === OUTPUT BEGIN === Checking PATCH 1/1: net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'... ERROR: consider using qemu_strtol in preference to strtol #71: FILE: net/slirp.c:414: +nc = net_hub_find_client_by_name(strtol(hub_id, NULL, 0), name); total: 1 errors, 0 warnings, 73 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org
