Re: [Qemu-devel] [PATCH] ppc: remove unused variables

2012-02-11 Thread Blue Swirl
On Mon, Feb 6, 2012 at 15:57, Alexander Graf ag...@suse.de wrote:

 On 06.02.2012, at 16:21, Andreas Färber wrote:

 Am 04.02.2012 12:49, schrieb Blue Swirl:
 Fix this error:
 /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
 /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set
 but not used [-Werror=unused-but-set-variable]

 Signed-off-by: Blue Swirl blauwir...@gmail.com

 Tested-by: Andreas Färber afaer...@suse.de

 Yes, Blue, can you push it please?

Pushed.



 Alex




Re: [Qemu-devel] [PATCH] ppc: remove unused variables

2012-02-06 Thread Andreas Färber
Am 04.02.2012 12:49, schrieb Blue Swirl:
 Fix this error:
 /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
 /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set
 but not used [-Werror=unused-but-set-variable]
 
 Signed-off-by: Blue Swirl blauwir...@gmail.com

Tested-by: Andreas Färber afaer...@suse.de

Alex?

Andreas

 ---
  target-ppc/helper.c |3 ---
  1 files changed, 0 insertions(+), 3 deletions(-)
 
 diff --git a/target-ppc/helper.c b/target-ppc/helper.c
 index e56fac8..928fbcf 100644
 --- a/target-ppc/helper.c
 +++ b/target-ppc/helper.c
 @@ -1293,11 +1293,8 @@ void booke206_flush_tlb(CPUState *env, int
 flags, const int check_iprot)
 
  target_phys_addr_t booke206_tlb_to_page_size(CPUState *env, ppcmas_tlb_t 
 *tlb)
  {
 -uint32_t tlbncfg;
 -int tlbn = booke206_tlbm_to_tlbn(env, tlb);
  int tlbm_size;
 
 -tlbncfg = env-spr[SPR_BOOKE_TLB0CFG + tlbn];
  tlbm_size = (tlb-mas1  MAS1_TSIZE_MASK)  MAS1_TSIZE_SHIFT;
 
  return 1024ULL  tlbm_size;

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



Re: [Qemu-devel] [PATCH] ppc: remove unused variables

2012-02-06 Thread Alexander Graf

On 06.02.2012, at 16:21, Andreas Färber wrote:

 Am 04.02.2012 12:49, schrieb Blue Swirl:
 Fix this error:
 /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
 /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set
 but not used [-Werror=unused-but-set-variable]
 
 Signed-off-by: Blue Swirl blauwir...@gmail.com
 
 Tested-by: Andreas Färber afaer...@suse.de

Yes, Blue, can you push it please?


Alex