Re: [Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check

2013-10-02 Thread Stefan Hajnoczi 
On Mon, Sep 30, 2013 at 08:59:28AM +0200, Max Reitz wrote:
> If an inactive L1 table is loaded from disk, its entries are in big
> endian and have to be converted to host byte order before using them.
> 
> Signed-off-by: Max Reitz 
> ---
>  block/qcow2-refcount.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

Re: [Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check

2013-09-30 Thread Kevin Wolf 
Am 30.09.2013 um 08:59 hat Max Reitz geschrieben:
> If an inactive L1 table is loaded from disk, its entries are in big
> endian and have to be converted to host byte order before using them.
> 
> Signed-off-by: Max Reitz 

Reviewed-by: Kevin Wolf 

Sounds like there's yet a test case missing? (But it requires the
runtime options for enabling these checks, obviously)

Kevin

Re: [Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check

2013-09-30 Thread Max Reitz 

On 2013-09-30 10:06, Kevin Wolf wrote:

Am 30.09.2013 um 08:59 hat Max Reitz geschrieben:

If an inactive L1 table is loaded from disk, its entries are in big
endian and have to be converted to host byte order before using them.

Signed-off-by: Max Reitz 

Reviewed-by: Kevin Wolf 

Sounds like there's yet a test case missing? (But it requires the
runtime options for enabling these checks, obviously)


Yes to both. For now, I just couldn't write such a test case.

Max