Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
On Feb 25, 2016 4:09 AM, "Michael Roth" wrote: > > Quoting Leonid Bloch (2016-01-11 03:12:41) > > With automatically generated GUID, on minor version changes, an error > > occurred, stating that there is a problem with the installer. > > Now, a notification is shown, warning the user that another version of > > this product is already installed, and that configuration or removal of > > the existing version is possible through Add/Remove Programs on the > > Control Panel (expected behavior). > > > > Signed-off-by: Leonid Bloch > > Thanks, applied to qga tree: > > https://github.com/mdroth/qemu/commits/qga Thanks, Michael. > > > --- > > qga/installer/qemu-ga.wxs | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs > > index 9473875..7f92891 100644 > > --- a/qga/installer/qemu-ga.wxs > > +++ b/qga/installer/qemu-ga.wxs > > @@ -41,7 +41,7 @@ > > > > > Name="QEMU guest agent" > > -Id="*" > > +Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}" > > UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}" > > Manufacturer="$(env.QEMU_GA_MANUFACTURER)" > > Version="$(env.QEMU_GA_VERSION)" > > -- > > 2.4.3 > > >
Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
Quoting Leonid Bloch (2016-01-11 03:12:41) > With automatically generated GUID, on minor version changes, an error > occurred, stating that there is a problem with the installer. > Now, a notification is shown, warning the user that another version of > this product is already installed, and that configuration or removal of > the existing version is possible through Add/Remove Programs on the > Control Panel (expected behavior). > > Signed-off-by: Leonid Bloch Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga > --- > qga/installer/qemu-ga.wxs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs > index 9473875..7f92891 100644 > --- a/qga/installer/qemu-ga.wxs > +++ b/qga/installer/qemu-ga.wxs > @@ -41,7 +41,7 @@ > > Name="QEMU guest agent" > -Id="*" > +Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}" > UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}" > Manufacturer="$(env.QEMU_GA_MANUFACTURER)" > Version="$(env.QEMU_GA_VERSION)" > -- > 2.4.3 >
Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
Quoting Leonid Bloch (2016-01-11 03:12:41) > With automatically generated GUID, on minor version changes, an error > occurred, stating that there is a problem with the installer. > Now, a notification is shown, warning the user that another version of > this product is already installed, and that configuration or removal of > the existing version is possible through Add/Remove Programs on the > Control Panel (expected behavior). > > Signed-off-by: Leonid Bloch Reviewed-by: Michael Roth > --- > qga/installer/qemu-ga.wxs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs > index 9473875..7f92891 100644 > --- a/qga/installer/qemu-ga.wxs > +++ b/qga/installer/qemu-ga.wxs > @@ -41,7 +41,7 @@ > > Name="QEMU guest agent" > -Id="*" > +Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}" > UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}" > Manufacturer="$(env.QEMU_GA_MANUFACTURER)" > Version="$(env.QEMU_GA_VERSION)" > -- > 2.4.3 >
Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
ping http://patchwork.ozlabs.org/patch/565712 On Mon, Jan 11, 2016 at 11:12 AM, Leonid Bloch wrote: > With automatically generated GUID, on minor version changes, an error > occurred, stating that there is a problem with the installer. > Now, a notification is shown, warning the user that another version of > this product is already installed, and that configuration or removal of > the existing version is possible through Add/Remove Programs on the > Control Panel (expected behavior). > > Signed-off-by: Leonid Bloch > --- > qga/installer/qemu-ga.wxs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs > index 9473875..7f92891 100644 > --- a/qga/installer/qemu-ga.wxs > +++ b/qga/installer/qemu-ga.wxs > @@ -41,7 +41,7 @@ > > Name="QEMU guest agent" > -Id="*" > +Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}" > UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}" > Manufacturer="$(env.QEMU_GA_MANUFACTURER)" > Version="$(env.QEMU_GA_VERSION)" > -- > 2.4.3 > >