Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks

[Maciej W. Rozycki]

On Wed, 3 Dec 2014, Leon Alrae wrote:

> > -env->hflags |= MIPS_HFLAG_DM | MIPS_HFLAG_64 | MIPS_HFLAG_CP0;
> > +if (env->insn_flags & ISA_MIPS3)
> > +env->hflags |= MIPS_HFLAG_64;
> 
> According to the CODING_STYLE braces are required even for a single
> statement "if" block. This also applies in other places in this patch.

 These slipped through somehow, I must have forgotten to run checkpatch 
on this change.  Resending an updated version right away, thanks for 
catching this up and for your review.

  Maciej

Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks

[Leon Alrae]

On 19/11/2014 14:20, Maciej W. Rozycki wrote:
> -env->hflags |= MIPS_HFLAG_DM | MIPS_HFLAG_64 | MIPS_HFLAG_CP0;
> +if (env->insn_flags & ISA_MIPS3)
> +env->hflags |= MIPS_HFLAG_64;

According to the CODING_STYLE braces are required even for a single
statement "if" block. This also applies in other places in this patch.

Otherwise,

Reviewed-by: Leon Alrae