Re: [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug

2019-06-18 Thread David Gibson
On Mon, Jun 17, 2019 at 04:10:33PM +0200, Greg Kurz wrote:
> So that no one is tempted to drop that code, which is never called
> for cold plugged CPUs.
> 
> Signed-off-by: Greg Kurz 

Applied, thanks.

> ---
>  hw/intc/xics.c |1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
> index 8535e583dd41..faa976e2f8a8 100644
> --- a/hw/intc/xics.c
> +++ b/hw/intc/xics.c
> @@ -363,6 +363,7 @@ static void icp_realize(DeviceState *dev, Error **errp)
>  return;
>  }
>  
> +/* Connect the presenter to the VCPU (required for CPU hotplug) */
>  if (kvm_irqchip_in_kernel()) {
>  icp_kvm_realize(dev, );
>  if (err) {
> 

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature


Re: [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug

2019-06-17 Thread Cédric Le Goater
On 17/06/2019 16:10, Greg Kurz wrote:
> So that no one is tempted to drop that code, which is never called
> for cold plugged CPUs.
> 
> Signed-off-by: Greg Kurz 


Reviewed-by: Cédric Le Goater 

Thanks,

C.