Re: [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings
On (Mon) 30 May 2011 [15:56:28], Christophe Fergeau wrote: > On Mon, May 30, 2011 at 04:23:43PM +0530, Amit Shah wrote: > > You should keep From: as the same person, keep his Signed-off-by, add > > your Signed-off-by and mention what you have changed in the series. > > Hans's patches didn't have a S-o-b. I can resend the same patches again > with my S-o-b (I'm fine with doing this without Hans's since I came up with > exactly the same patches independently from Hans) and detailing the changes > from the initial patch. Does that sound good? Yes, that's fine. Amit
Re: [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings
On Mon, May 30, 2011 at 04:23:43PM +0530, Amit Shah wrote: > You should keep From: as the same person, keep his Signed-off-by, add > your Signed-off-by and mention what you have changed in the series. Hans's patches didn't have a S-o-b. I can resend the same patches again with my S-o-b (I'm fine with doing this without Hans's since I came up with exactly the same patches independently from Hans) and detailing the changes from the initial patch. Does that sound good? Christophe pgpmNHpihEPbk.pgp Description: PGP signature
Re: [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings
On (Mon) 30 May 2011 [12:28:01], Christophe Fergeau wrote: > Hi, > > Here are Hans's patches split and with the various issues that were pointed > out fixed. I'm not sure how I'm supposed to handle acks, original author, > ... when reworking patches this way, let me know if I should proceed > differently. You should keep From: as the same person, keep his Signed-off-by, add your Signed-off-by and mention what you have changed in the series. Thanks for re-sending this, btw. Amit
