Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication
Am 28.05.2013 um 17:11 hat Stefan Hajnoczi geschrieben: > Tests 030 and 041 are written in Python and use the iotests.py module. Push > common code down into iotests.py. My 'drive-backup' series takes advantage > will take advantage of this - kwolf pointed out that earlier revisions were > duplicating too much code. > > I decided to split this into a separate patch series and send it before the > next 'drive-backup' revision. > > Stefan Hajnoczi (4): > qemu-iotests: make assert_no_active_block_jobs() common > qemu-iotests: make cancel_and_wait() common > qemu-iotests: make compare_images() common > qemu-iotests: make create_image() common > > tests/qemu-iotests/030| 99 --- > tests/qemu-iotests/041| 181 > +++--- > tests/qemu-iotests/iotests.py | 38 + > 3 files changed, 135 insertions(+), 183 deletions(-) Thanks, applied to the block branch. Kevin
Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication
Am 28.05.2013 um 17:11 hat Stefan Hajnoczi geschrieben: > Tests 030 and 041 are written in Python and use the iotests.py module. Push > common code down into iotests.py. My 'drive-backup' series takes advantage > will take advantage of this - kwolf pointed out that earlier revisions were > duplicating too much code. > > I decided to split this into a separate patch series and send it before the > next 'drive-backup' revision. > > Stefan Hajnoczi (4): > qemu-iotests: make assert_no_active_block_jobs() common > qemu-iotests: make cancel_and_wait() common > qemu-iotests: make compare_images() common > qemu-iotests: make create_image() common > > tests/qemu-iotests/030| 99 --- > tests/qemu-iotests/041| 181 > +++--- > tests/qemu-iotests/iotests.py | 38 + > 3 files changed, 135 insertions(+), 183 deletions(-) Looks correct, but I had a question/comment about patch 2. Kevin
Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication
On Wed, May 29, 2013 at 01:29:34PM +0800, Fam Zheng wrote: > On Tue, 05/28 17:11, Stefan Hajnoczi wrote: > > Tests 030 and 041 are written in Python and use the iotests.py module. Push > > common code down into iotests.py. My 'drive-backup' series takes advantage > > will take advantage of this - kwolf pointed out that earlier revisions were > Do you mean s/takes advantage will take advantage/will take advantage/? Yes :)
Re: [Qemu-devel] [PATCH 0/4] qemu-iotests: reduce iotests.py code duplication
On Tue, 05/28 17:11, Stefan Hajnoczi wrote: > Tests 030 and 041 are written in Python and use the iotests.py module. Push > common code down into iotests.py. My 'drive-backup' series takes advantage > will take advantage of this - kwolf pointed out that earlier revisions were Do you mean s/takes advantage will take advantage/will take advantage/? > duplicating too much code. > > I decided to split this into a separate patch series and send it before the > next 'drive-backup' revision. > > Stefan Hajnoczi (4): > qemu-iotests: make assert_no_active_block_jobs() common > qemu-iotests: make cancel_and_wait() common > qemu-iotests: make compare_images() common > qemu-iotests: make create_image() common > > tests/qemu-iotests/030| 99 --- > tests/qemu-iotests/041| 181 > +++--- > tests/qemu-iotests/iotests.py | 38 + > 3 files changed, 135 insertions(+), 183 deletions(-) > > -- > 1.8.1.4 > > -- Fam
