Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions
On 3/12/2014 5:40 PM, Richard Henderson wrote: On 03/10/2014 12:04 PM, Tom Musta wrote: This patch series addresses concerns raised by Richard Henderson regarding redundant copies of Advanced Encryption Standard (AES) data and code (see http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html). The patches declare commonly used AES tables in the include/qemu/aes.h header file and define the tables in util/aes.c, thus eliminating redundant copies. Minor refactorization of the i386 and ARM instruction models are made to utilize this common support. The newly added PowerPC instructions are completely rewritten and look much more like the i386 equivalents; a substantial amount of code is eliminated. Tom Musta (6): util: Add S-Box and InvS-Box Arrays to Common AES Utils util: Add AES ShiftRows and InvShiftRows Tables util: Add InvMixColumns target-i386: Use Common ShiftRows and InvShiftRows Tables target-arm: Use Common Tables in AES Instructions target-ppc: Refactor AES Instructions Other than the one nit, Reviewed-by: Richard Henderson r...@twiddle.net r~ Thanks. I will rework the nit and republish a V2.
Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions
On 03/10/2014 12:04 PM, Tom Musta wrote: This patch series addresses concerns raised by Richard Henderson regarding redundant copies of Advanced Encryption Standard (AES) data and code (see http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html). The patches declare commonly used AES tables in the include/qemu/aes.h header file and define the tables in util/aes.c, thus eliminating redundant copies. Minor refactorization of the i386 and ARM instruction models are made to utilize this common support. The newly added PowerPC instructions are completely rewritten and look much more like the i386 equivalents; a substantial amount of code is eliminated. Tom Musta (6): util: Add S-Box and InvS-Box Arrays to Common AES Utils util: Add AES ShiftRows and InvShiftRows Tables util: Add InvMixColumns target-i386: Use Common ShiftRows and InvShiftRows Tables target-arm: Use Common Tables in AES Instructions target-ppc: Refactor AES Instructions Other than the one nit, Reviewed-by: Richard Henderson r...@twiddle.net r~
