Re: [Qemu-devel] [PATCH 0/9] usb: mtp: a bunch of fixes
On Fri, Apr 25, 2014 at 12:48:05PM +0200, Gerd Hoffmann wrote: Hi, Here is a bunch of incremental fixes for the just merged usb mtp device, coming from patch review by Peter and Stefan. cheers, Gerd Gerd Hoffmann (9): usb: mtp: replace debug printfs with trace points usb: mtp: fix usb_mtp_add_u64 usb: mtp: fix version (is decimal not bcd) usb: mtp: fix serial (must be exact 32 chars) usb: mtp: fix error path memory leak usb: mtp: fix possible buffer overflow usb: mtp: avoid empty description string usb: mtp: drop data-out hexdump usb: mtp: reply INCOMPLETE_TRANSFER on read errors hw/usb/dev-mtp.c | 29 + trace-events | 3 +++ 2 files changed, 20 insertions(+), 12 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Re: [Qemu-devel] [PATCH 0/9] usb: mtp: a bunch of fixes
On Friday 25 April 2014 12:48:05 Gerd Hoffmann wrote: Hi, Here is a bunch of incremental fixes for the just merged usb mtp device, coming from patch review by Peter and Stefan. cheers, Gerd Gerd Hoffmann (9): usb: mtp: replace debug printfs with trace points usb: mtp: fix usb_mtp_add_u64 usb: mtp: fix version (is decimal not bcd) usb: mtp: fix serial (must be exact 32 chars) usb: mtp: fix error path memory leak usb: mtp: fix possible buffer overflow usb: mtp: avoid empty description string usb: mtp: drop data-out hexdump usb: mtp: reply INCOMPLETE_TRANSFER on read errors hw/usb/dev-mtp.c | 29 + trace-events | 3 +++ 2 files changed, 20 insertions(+), 12 deletions(-) For patches 1-5 and 7-8: Reviewed-by: Peter Wu pe...@lekensteyn.nl Patch 6 and 9 have some comments. Kind regards, Peter