Re: [Qemu-devel] [PATCH 01/27] block/qapi: Introduce BlockdevCreateOptions

[Max Reitz]

On 2018-02-08 20:23, Kevin Wolf wrote:
> This creates a BlockdevCreateOptions union type that will contain all of
> the options for image creation. We'll start out with an empty struct
> type BlockdevCreateDummy for all drivers.
> 
> Signed-off-by: Kevin Wolf 
> ---
>  qapi/block-core.json | 61 
> 
>  1 file changed, 61 insertions(+)

With the commit message fixed:

Reviewed-by: Max Reitz 



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 01/27] block/qapi: Introduce BlockdevCreateOptions

[Eric Blake]

On 02/08/2018 01:23 PM, Kevin Wolf wrote:

This creates a BlockdevCreateOptions union type that will contain all of
the options for image creation. We'll start out with an empty struct
type BlockdevCreateDummy for all drivers.


Name here...



Signed-off-by: Kevin Wolf 
---
  qapi/block-core.json | 61 
  1 file changed, 61 insertions(+)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 8225308904..b59b1430bb 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3338,6 +3338,67 @@
  { 'command': 'blockdev-del', 'data': { 'node-name': 'str' } }
  
  ##

+# @BlockdevCreateNotSupported:


...should match what you use here.

With that obvious fix,
Reviewed-by: Eric Blake 

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org