Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues
On Jun 11, 2019 4:18 PM, "Aleksandar Markovic" wrote: > > > On Jun 11, 2019 11:51 AM, "Peter Maydell" wrote: > > > > On Mon, 10 Jun 2019 at 22:41, Aleksandar Markovic > > wrote: > > > > > > > > > On Jun 10, 2019 5:25 PM, "Peter Maydell" wrote: > > > > > > > > The docs/specs/index.rst has a couple of minor issues which > > > > we didn't notice because we weren't building the manual: > > > > * the ToC entry for the new PPC XIVE docs points to > > > >a nonexistent file > > > > * the initial comment needs to be marked by '..', not '.', > > > >or it will appear in the output > > > > * the title doesn't match the capitialization used by > > > >the existing interop or devel manuals, and uses > > > >'full-system emulation' rather than the 'system emulation' > > > >that the interop manual title uses > > > > > > > > Fix these minor issues before we start trying to build the manual. > > > > > > > > Signed-off-by: Peter Maydell > > > > --- > > > > > > Acked-by: Aleksandar Markovic > > > > Hi Aleksandar; I'm just wondering what you were meaning > > with this acked-by tag. Generally acked-by means (to me, > > and I think usually with qemu) "this patch touches an > > area that I maintain, I haven't reviewed it but I'm OK with > > it". But this series isn't mips-related, so maybe you > > meant reviewed-by instead ? > > > > (Acked-by is a bit of an odd tag because it's less > > clear what it means than reviewed-by or signed-off-by, > > so it's not very surprising if you've picked up a > > different opinion on what it's for.) > > > > Hello, Peter. > > My intented meaning (of my Acked-by) is: > > “I agree that this patch is valuable in general, I took a look at the code changes and they look good to me implementation-wise, but I am not a reviewer nor an expert in rst and related areas, so I am not comfortable “reviewing-it-by” - however as a potential user/writer of rst files, I want to acknowledge the significance and the rightness of the patch by “acking-it-by”.” > > I am not sure how it fits in other definitions, but I am comfortable with your changing my “Acked-by” to “Reviewed-by”, leaving it as is, or changing it to nothing- whatever you deem being suitable. > > The same applies to the other patch of this series, of course. > > Yours, > Aleksandar > > > thanks > > -- PMM Peter, hi again. While the content of this patch seems definitely unrelated to mips, we in mips are very interested in QEMU documention framework extended and improved, since we plan (in a mid-term) a major overhaul of both external and internal mips-related QEMU documentation. That is why I am closely observing activities in that area, and most probably the missing context that left you wandering why I participate in the discussions on these patches at all. Hopefully this explanations removes some of your dilemmas. Best regards, Aleksandar
Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues
On Jun 11, 2019 11:51 AM, "Peter Maydell" wrote: > > On Mon, 10 Jun 2019 at 22:41, Aleksandar Markovic > wrote: > > > > > > On Jun 10, 2019 5:25 PM, "Peter Maydell" wrote: > > > > > > The docs/specs/index.rst has a couple of minor issues which > > > we didn't notice because we weren't building the manual: > > > * the ToC entry for the new PPC XIVE docs points to > > >a nonexistent file > > > * the initial comment needs to be marked by '..', not '.', > > >or it will appear in the output > > > * the title doesn't match the capitialization used by > > >the existing interop or devel manuals, and uses > > >'full-system emulation' rather than the 'system emulation' > > >that the interop manual title uses > > > > > > Fix these minor issues before we start trying to build the manual. > > > > > > Signed-off-by: Peter Maydell > > > --- > > > > Acked-by: Aleksandar Markovic > > Hi Aleksandar; I'm just wondering what you were meaning > with this acked-by tag. Generally acked-by means (to me, > and I think usually with qemu) "this patch touches an > area that I maintain, I haven't reviewed it but I'm OK with > it". But this series isn't mips-related, so maybe you > meant reviewed-by instead ? > > (Acked-by is a bit of an odd tag because it's less > clear what it means than reviewed-by or signed-off-by, > so it's not very surprising if you've picked up a > different opinion on what it's for.) > Hello, Peter. My intented meaning (of my Acked-by) is: “I agree that this patch is valuable in general, I took a look at the code changes and they look good to me implementation-wise, but I am not a reviewer nor an expert in rst and related areas, so I am not comfortable “reviewing-it-by” - however as a potential user/writer of rst files, I want to acknowledge the significance and the rightness of the patch by “acking-it-by”.” I am not sure how it fits in other definitions, but I am comfortable with your changing my “Acked-by” to “Reviewed-by”, leaving it as is, or changing it to nothing- whatever you deem being suitable. The same applies to the other patch of this series, of course. Yours, Aleksandar > thanks > -- PMM
Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues
On Mon, 10 Jun 2019 at 22:41, Aleksandar Markovic wrote: > > > On Jun 10, 2019 5:25 PM, "Peter Maydell" wrote: > > > > The docs/specs/index.rst has a couple of minor issues which > > we didn't notice because we weren't building the manual: > > * the ToC entry for the new PPC XIVE docs points to > >a nonexistent file > > * the initial comment needs to be marked by '..', not '.', > >or it will appear in the output > > * the title doesn't match the capitialization used by > >the existing interop or devel manuals, and uses > >'full-system emulation' rather than the 'system emulation' > >that the interop manual title uses > > > > Fix these minor issues before we start trying to build the manual. > > > > Signed-off-by: Peter Maydell > > --- > > Acked-by: Aleksandar Markovic Hi Aleksandar; I'm just wondering what you were meaning with this acked-by tag. Generally acked-by means (to me, and I think usually with qemu) "this patch touches an area that I maintain, I haven't reviewed it but I'm OK with it". But this series isn't mips-related, so maybe you meant reviewed-by instead ? (Acked-by is a bit of an odd tag because it's less clear what it means than reviewed-by or signed-off-by, so it's not very surprising if you've picked up a different opinion on what it's for.) thanks -- PMM
Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues
On Jun 10, 2019 5:25 PM, "Peter Maydell" wrote: > > The docs/specs/index.rst has a couple of minor issues which > we didn't notice because we weren't building the manual: > * the ToC entry for the new PPC XIVE docs points to >a nonexistent file > * the initial comment needs to be marked by '..', not '.', >or it will appear in the output > * the title doesn't match the capitialization used by >the existing interop or devel manuals, and uses >'full-system emulation' rather than the 'system emulation' >that the interop manual title uses > > Fix these minor issues before we start trying to build the manual. > > Signed-off-by: Peter Maydell > --- Acked-by: Aleksandar Markovic > docs/specs/index.rst | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/docs/specs/index.rst b/docs/specs/index.rst > index 2e927519c2e..40adb97c5eb 100644 > --- a/docs/specs/index.rst > +++ b/docs/specs/index.rst > @@ -1,8 +1,8 @@ > -. This is the top level page for the 'specs' manual > +.. This is the top level page for the 'specs' manual > > > -QEMU full-system emulation guest hardware specifications > - > +QEMU System Emulation Guest Hardware Specifications > +=== > > > Contents: > @@ -10,4 +10,5 @@ Contents: > .. toctree:: > :maxdepth: 2 > > - xive > + ppc-xive > + ppc-spapr-xive > -- > 2.20.1 > >
Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues
On 10/06/2019 17:24, Peter Maydell wrote: > The docs/specs/index.rst has a couple of minor issues which > we didn't notice because we weren't building the manual: > * the ToC entry for the new PPC XIVE docs points to >a nonexistent file > * the initial comment needs to be marked by '..', not '.', >or it will appear in the output > * the title doesn't match the capitialization used by >the existing interop or devel manuals, and uses >'full-system emulation' rather than the 'system emulation' >that the interop manual title uses > > Fix these minor issues before we start trying to build the manual. I only tested the pdf generation of each file with rst2pdf :/ > Signed-off-by: Peter Maydell Reviewed-by: Cédric Le Goater Thanks, C. > --- > docs/specs/index.rst | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/docs/specs/index.rst b/docs/specs/index.rst > index 2e927519c2e..40adb97c5eb 100644 > --- a/docs/specs/index.rst > +++ b/docs/specs/index.rst > @@ -1,8 +1,8 @@ > -. This is the top level page for the 'specs' manual > +.. This is the top level page for the 'specs' manual > > > -QEMU full-system emulation guest hardware specifications > - > +QEMU System Emulation Guest Hardware Specifications > +=== > > > Contents: > @@ -10,4 +10,5 @@ Contents: > .. toctree:: > :maxdepth: 2 > > - xive > + ppc-xive > + ppc-spapr-xive >
