Re: [Qemu-devel] [PATCH 1/4 v3] block: add image fragmentation statistics to qemu-img
Am 15.03.2012 13:13, schrieb Dong Xu Wang: From: Dong Xu Wang wdon...@linux.vnet.ibm.com Discussion can be found at: http://patchwork.ozlabs.org/patch/128730/ This patch add image fragmentation statistics while using qemu-img check. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Thanks, applied all to the block branch. Please make the subject line prefix more specific in future commits, I changed it for this series. For example, don't write block: foo in qed or block: Add bar to qemu-img, but qed: foo and qemu-img: Add bar. The block: prefix is reserved for changes that are purely in the generic block layer (mainly block.c, blockdev.c). Kevin
Re: [Qemu-devel] [PATCH 1/4 v3] block: add image fragmentation statistics to qemu-img
On Thu, Mar 15, 2012 at 12:45 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Thu, Mar 15, 2012 at 08:13:31PM +0800, Dong Xu Wang wrote: From: Dong Xu Wang wdon...@linux.vnet.ibm.com Discussion can be found at: http://patchwork.ozlabs.org/patch/128730/ This patch add image fragmentation statistics while using qemu-img check. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block.h | 7 +++ qemu-img.c | 9 - 2 files changed, 15 insertions(+), 1 deletions(-) A minor comment that doesn't require resending: Please avoid introducing whitespace or reformatting changes in a patch that makes other code changes. Patch 1 changes whitespace in a place that is not touched by the rest of your patch, so that change is not essential and it's best to leave it out. Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Ping? Stefan
Re: [Qemu-devel] [PATCH 1/4 v3] block: add image fragmentation statistics to qemu-img
On Thu, Mar 15, 2012 at 12:13 PM, Dong Xu Wang wdon...@linux.vnet.ibm.com wrote: From: Dong Xu Wang wdon...@linux.vnet.ibm.com Discussion can be found at: http://patchwork.ozlabs.org/patch/128730/ This patch add image fragmentation statistics while using qemu-img check. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block.h | 7 +++ qemu-img.c | 9 - 2 files changed, 15 insertions(+), 1 deletions(-) In the future please send a 0/4 email when sending a patch series: git format-patch --cover-letter ... The cover letter introduces the patch series and also acts as the single place where reviewers can reply to say they are happy with the series. Kevin: my Reviewed-by: applies to the whole series. Stefan
Re: [Qemu-devel] [PATCH 1/4 v3] block: add image fragmentation statistics to qemu-img
On Thu, Mar 15, 2012 at 08:13:31PM +0800, Dong Xu Wang wrote: From: Dong Xu Wang wdon...@linux.vnet.ibm.com Discussion can be found at: http://patchwork.ozlabs.org/patch/128730/ This patch add image fragmentation statistics while using qemu-img check. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block.h|7 +++ qemu-img.c |9 - 2 files changed, 15 insertions(+), 1 deletions(-) A minor comment that doesn't require resending: Please avoid introducing whitespace or reformatting changes in a patch that makes other code changes. Patch 1 changes whitespace in a place that is not touched by the rest of your patch, so that change is not essential and it's best to leave it out. Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
