Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style
On 4 June 2016 at 23:33, Richard Henderson wrote: > On 06/04/2016 11:34 AM, Michael Rolnik wrote: >> >> understood. but I am totally lost now. what should I do now. >> I've sent a set of patches last Friday, they should include all the fixes. > > > For the next round: > > git format-patch --cover-letter --subject-prefix='PATCH v4' master I recommend also -o my-patch-set-4 which will create a subdirectory 'my-patch-set-4' to put the patches in; otherwise you'll end up with patches for multiple versions all in the current working directory... > Edit -cover-letter.patch to describe the patch set and changes since v3. > > git send-email --to=qemu-devel@nongnu.org --cc=r...@twiddle.net 00* ...and this wildcard will send them all at once by mistake. thanks -- PMM
Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style
On 06/02/2016 01:07 PM, Michael Rolnik wrote: Signed-off-by: Michael Rolnik --- target-avr/cpu-qom.h| 38 + target-avr/cpu.c| 100 +--- target-avr/cpu.h| 74 target-avr/gdbstub.c| 10 + target-avr/helper.c | 52 ++- target-avr/translate-inst.c | 54 +++- target-avr/translate-inst.h | 20 + target-avr/translate.c | 27 +++- target-avr/translate.h | 5 +-- 9 files changed, 134 insertions(+), 246 deletions(-) As Peter mentioned, this needs to be folded back into the earlier patches. r~
Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style
On 06/04/2016 11:34 AM, Michael Rolnik wrote: understood. but I am totally lost now. what should I do now. I've sent a set of patches last Friday, they should include all the fixes. For the next round: git format-patch --cover-letter --subject-prefix='PATCH v4' master Edit -cover-letter.patch to describe the patch set and changes since v3. git send-email --to=qemu-devel@nongnu.org --cc=r...@twiddle.net 00* You must have gone through an extra step before in order to get in-reply-to field set to make the patch sets nest like they did. Whatever that step was, please don't do it again. r~
Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style
understood. but I am totally lost now. what should I do now. I've sent a set of patches last Friday, they should include all the fixes. Michael On Sat, Jun 4, 2016 at 8:41 PM, Richard Henderson wrote: > On 06/02/2016 04:10 PM, Peter Maydell wrote: > >> PS: it would be good if you could provide a cover letter when >> you send out the next round of these patches; that provides >> a handy way to deal with the series as a whole (for both >> automated tools and people), so we tend to prefer multi-patch >> sets to have one. >> > > In addition, use --subject-prefix="PATCH vN" so that we know which patch > set is newest. > > Also, do not send follow-up patch sets as replies to earlier patch sets. > Doing this means that patch sets get lost. > > > r~ > -- Best Regards, Michael Rolnik
Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style
On 06/02/2016 04:10 PM, Peter Maydell wrote: PS: it would be good if you could provide a cover letter when you send out the next round of these patches; that provides a handy way to deal with the series as a whole (for both automated tools and people), so we tend to prefer multi-patch sets to have one. In addition, use --subject-prefix="PATCH vN" so that we know which patch set is newest. Also, do not send follow-up patch sets as replies to earlier patch sets. Doing this means that patch sets get lost. r~
Re: [Qemu-devel] [PATCH 10/10] target-avr: fixing code style
On 2 June 2016 at 21:07, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > target-avr/cpu-qom.h| 38 + > target-avr/cpu.c| 100 > +--- > target-avr/cpu.h| 74 > target-avr/gdbstub.c| 10 + > target-avr/helper.c | 52 ++- > target-avr/translate-inst.c | 54 +++- > target-avr/translate-inst.h | 20 + > target-avr/translate.c | 27 +++- > target-avr/translate.h | 5 +-- > 9 files changed, 134 insertions(+), 246 deletions(-) Rather than fixing up code style issues in the preceding patches, I think you would be better to just fold these changes into those patches so that the code is right the first time. PS: it would be good if you could provide a cover letter when you send out the next round of these patches; that provides a handy way to deal with the series as a whole (for both automated tools and people), so we tend to prefer multi-patch sets to have one. thanks -- PMM
