Re: [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking

2010-11-22 Thread Christoph Hellwig
On Thu, Nov 18, 2010 at 03:47:32PM +0100, Hannes Reinecke wrote:
 
 scsi_req_parse() already provides for a data direction setting,
 so we should be using it to check for correct direction.

Instead of just a debug printf that almost no one compiles in shouldn't
we reject the incorrect commands?




Re: [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking

2010-11-22 Thread Hannes Reinecke
On 11/22/2010 12:20 PM, Christoph Hellwig wrote:
 On Thu, Nov 18, 2010 at 03:47:32PM +0100, Hannes Reinecke wrote:

 scsi_req_parse() already provides for a data direction setting,
 so we should be using it to check for correct direction.
 
 Instead of just a debug printf that almost no one compiles in shouldn't
 we reject the incorrect commands?
 
Good point. Will be fixing it up for the next version.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke   zSeries  Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)