Re: [Qemu-devel] [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu

2011-02-24 Thread Peter Maydell
On 24 February 2011 10:33, Juan Quintela  wrote:
> +# shared-obj-y has the object that are shared by qemu binary and tools
> +
> +shared-obj-y  = qemu-error.o $(block-obj-y) $(qobject-obj-y) $(oslib-obj-y)
> +shared-obj-y += qemu-timer-common.o

I don't feel very strongly about this, but:
It seems a bit odd to have a shared-obj-y variable that isn't actually
a list of shared objects (ie .so files, DLLs). Maybe there's a better name?

-- PMM



Re: [Qemu-devel] [PATCH 2/2] build: create shared-obj-y for tools/qemu-softmmu

2011-02-24 Thread Markus Armbruster
Peter Maydell  writes:

> On 24 February 2011 10:33, Juan Quintela  wrote:
>> +# shared-obj-y has the object that are shared by qemu binary and tools
>> +
>> +shared-obj-y  = qemu-error.o $(block-obj-y) $(qobject-obj-y) $(oslib-obj-y)
>> +shared-obj-y += qemu-timer-common.o
>
> I don't feel very strongly about this, but:
> It seems a bit odd to have a shared-obj-y variable that isn't actually
> a list of shared objects (ie .so files, DLLs). Maybe there's a better name?

common-obj-y?