Re: [Qemu-devel] [PATCH V6 11/29] qapi event: convert STOP

2014-06-17 Thread Eric Blake 
On 06/17/2014 03:17 AM, Paolo Bonzini wrote:
> Il 13/06/2014 22:29, Eric Blake ha scritto:
>>> > +#
>>> > +# Emitted when the virtual machine is stopped
>>> > +#
>>> > +# Since: 2.1
>> 0.14.0
> 
> 0.12.0, actually:
> 
> $ git describe --contains b1a15e7eaafba8f26e2263b1a9b6e6d40e585e72
> v0.12.0-rc0~187

But nothing else in qapi-schema.json mentions anything earlier than
0.14.  True, QMP was first started in the 0.12 timeframe, but upstream
libvirt refuses to use QMP for anything earlier than qemu 0.15, unless
libvirt was able to probe that enough additional functionality of QMP
was backported to make it useful (thus it supports RHEL 6's qemu 0.12+).

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH V6 11/29] qapi event: convert STOP

2014-06-17 Thread Paolo Bonzini 

Il 13/06/2014 22:29, Eric Blake ha scritto:

> +#
> +# Emitted when the virtual machine is stopped
> +#
> +# Since: 2.1

0.14.0


0.12.0, actually:

$ git describe --contains b1a15e7eaafba8f26e2263b1a9b6e6d40e585e72
v0.12.0-rc0~187

Paolo

Re: [Qemu-devel] [PATCH V6 11/29] qapi event: convert STOP

2014-06-13 Thread Eric Blake 
On 06/05/2014 06:22 AM, Wenchao Xia wrote:
> Signed-off-by: Wenchao Xia 
> ---
>  cpus.c  |5 +++--
>  docs/qmp/qmp-events.txt |   12 
>  qapi-event.json |9 +
>  3 files changed, 12 insertions(+), 14 deletions(-)
> 

> @@ -530,7 +531,7 @@ static int do_vm_stop(RunState state)
>  pause_all_vcpus();
>  runstate_set(state);
>  vm_state_notify(0, state);
> -monitor_protocol_event(QEVENT_STOP, NULL);
> +qapi_event_send_stop(NULL);

Same comments from earlier about not needing errp argument

> +++ b/qapi-event.json
> @@ -29,3 +29,12 @@
>  # Since: 2.1
>  ##
>  { 'event': 'RESET' }
> +
> +##
> +# @STOP
> +#
> +# Emitted when the virtual machine is stopped
> +#
> +# Since: 2.1

0.14.0

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature