Re: [Qemu-devel] [PATCH moxie 5/5] Add top level changes for moxie port

2013-02-14 Thread Peter Maydell 
On 13 February 2013 22:28, Anthony Green gr...@moxielogic.com wrote:
 Signed-off-by: Anthony Green gr...@moxielogic.com
 ---
[snip]
  extern const uint32_t arch_type;
 --
 1.8.1.2

 [green@localhost qemu]$ cat 0005-Add-top-level-changes-for-moxie.patch
 From 43eb752f105a3c1554234acb54df4e3954d97946 Mon Sep 17 00:00:00 2001
 From: Anthony Green gr...@moxielogic.com
 Date: Wed, 13 Feb 2013 17:07:14 -0500
 Subject: [PATCH 5/5] Add top level changes for moxie


There's something weird going on with whatever you're
using to create these patch emails. Can you redo your next
series in the standard '0/0 cover letter + each patch mail
as a followup to the cover letter' format, please? git
format-patch and git send-email should be able to generate
these for you.

thanks
-- PMM

Re: [Qemu-devel] [PATCH moxie 5/5] Add top level changes for moxie port

2013-02-14 Thread Max Filippov 
On Thu, Feb 14, 2013 at 1:56 PM, Peter Maydell peter.mayd...@linaro.org wrote:
On 13 February 2013 22:28, Anthony Green gr...@moxielogic.com wrote:
 Signed-off-by: Anthony Green gr...@moxielogic.com

[...]

 There's something weird going on with whatever you're
 using to create these patch emails. Can you redo your next
 series in the standard '0/0 cover letter + each patch mail
 as a followup to the cover letter' format, please? git

There's also a lot of coding standard violations, can you run
your patches through scripts/checkpatch.pl and fix its findings?

-- 
Thanks.
-- Max