Re: [Qemu-devel] [PATCH v1 2/2] vhost-user: add reply for set_mem_table
On 2015/2/10 14:35, Gonglei wrote: > On 2015/2/10 13:48, linhaifeng wrote: >> From: Linhaifeng >> >> If u64 is not 0 we should return -1 to tell qemu not going on. >> >> Remove some unnecessary '\n' in error_report. > Hi, haifeng: > > You'd better split a single patch to do this work, > and using '--cover' argument for patch series when git format-patch . :) > good idea! > Regards, > -Gonglei >> >> Signed-off-by: Linhaifeng >> --- >> hw/virtio/vhost-user.c | 33 ++--- >> 1 file changed, 22 insertions(+), 11 deletions(-) > > > > . > -- Regards, Haifeng
Re: [Qemu-devel] [PATCH v1 2/2] vhost-user: add reply for set_mem_table
On 2015/2/10 13:48, linhaifeng wrote: > From: Linhaifeng > > If u64 is not 0 we should return -1 to tell qemu not going on. > > Remove some unnecessary '\n' in error_report. Hi, haifeng: You'd better split a single patch to do this work, and using '--cover' argument for patch series when git format-patch . :) Regards, -Gonglei > > Signed-off-by: Linhaifeng > --- > hw/virtio/vhost-user.c | 33 ++--- > 1 file changed, 22 insertions(+), 11 deletions(-)
