Re: [Qemu-devel] [PATCH v2] configure: Relax check for libseccomp
On 4/4/19 8:39 PM, Helge Deller wrote: > All major distributions do support libseccomp version >= 2.3.0, so there > is no need to special-case on various architectures any longer. > > Signed-off-by: Helge Deller > > diff --git a/configure b/configure > index 1c563a7027..8fe4fc84d8 100755 > --- a/configure > +++ b/configure > @@ -2377,36 +2369,16 @@ fi > ## > # libseccomp check > > -libseccomp_minver="2.2.0" > if test "$seccomp" != "no" ; then > -case "$cpu" in > -i386|x86_64|mips) > -;; > -arm|aarch64) > -libseccomp_minver="2.2.3" > -;; > -ppc|ppc64|s390x) > -libseccomp_minver="2.3.0" > -;; > -*) > -libseccomp_minver="" > -;; > -esac > - > -if test "$libseccomp_minver" != "" && > - $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then > +libseccomp_minver="2.3.0" > +if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then > seccomp_cflags="$($pkg_config --cflags libseccomp)" > seccomp_libs="$($pkg_config --libs libseccomp)" > seccomp="yes" > else > if test "$seccomp" = "yes" ; then > -if test "$libseccomp_minver" != "" ; then > -feature_not_found "libseccomp" \ > -"Install libseccomp devel >= $libseccomp_minver" > -else > -feature_not_found "libseccomp" \ > -"libseccomp is not supported for host cpu $cpu" > -fi > +feature_not_found "libseccomp" \ > + "Install libseccomp devel >= $libseccomp_minver" > fi > seccomp="no" > fi > Reviewed-by: Philippe Mathieu-Daudé
Re: [Qemu-devel] [PATCH v2] configure: Relax check for libseccomp
On 04/04/2019 - 22:01:38, Thomas Huth wrote: > On 04/04/2019 20.39, Helge Deller wrote: > > All major distributions do support libseccomp version >= 2.3.0, so there > > is no need to special-case on various architectures any longer. > > > > Signed-off-by: Helge Deller > > > > diff --git a/configure b/configure > > index 1c563a7027..8fe4fc84d8 100755 > > --- a/configure > > +++ b/configure > > @@ -2377,36 +2369,16 @@ fi > > ## > > # libseccomp check > > > > -libseccomp_minver="2.2.0" > > if test "$seccomp" != "no" ; then > > -case "$cpu" in > > -i386|x86_64|mips) > > -;; > > -arm|aarch64) > > -libseccomp_minver="2.2.3" > > -;; > > -ppc|ppc64|s390x) > > -libseccomp_minver="2.3.0" > > -;; > > -*) > > -libseccomp_minver="" > > -;; > > -esac > > - > > -if test "$libseccomp_minver" != "" && > > - $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then > > +libseccomp_minver="2.3.0" > > +if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then > > seccomp_cflags="$($pkg_config --cflags libseccomp)" > > seccomp_libs="$($pkg_config --libs libseccomp)" > > seccomp="yes" > > else > > if test "$seccomp" = "yes" ; then > > -if test "$libseccomp_minver" != "" ; then > > -feature_not_found "libseccomp" \ > > -"Install libseccomp devel >= $libseccomp_minver" > > -else > > -feature_not_found "libseccomp" \ > > -"libseccomp is not supported for host cpu $cpu" > > -fi > > +feature_not_found "libseccomp" \ > > + "Install libseccomp devel >= $libseccomp_minver" > > fi > > seccomp="no" > > fi > > Reviewed-by: Thomas Huth Acked-by: Eduardo Otubo -- Eduardo Otubo Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn, Handelsregister: Amtsgericht München, HRB 153243, Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander signature.asc Description: PGP signature
Re: [Qemu-devel] [PATCH v2] configure: Relax check for libseccomp
On Thu, Apr 04, 2019 at 08:39:23PM +0200, Helge Deller wrote: > All major distributions do support libseccomp version >= 2.3.0, so there > is no need to special-case on various architectures any longer. > > Signed-off-by: Helge Deller Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
Re: [Qemu-devel] [PATCH v2] configure: Relax check for libseccomp
On 04/04/2019 20.39, Helge Deller wrote: > All major distributions do support libseccomp version >= 2.3.0, so there > is no need to special-case on various architectures any longer. > > Signed-off-by: Helge Deller > > diff --git a/configure b/configure > index 1c563a7027..8fe4fc84d8 100755 > --- a/configure > +++ b/configure > @@ -2377,36 +2369,16 @@ fi > ## > # libseccomp check > > -libseccomp_minver="2.2.0" > if test "$seccomp" != "no" ; then > -case "$cpu" in > -i386|x86_64|mips) > -;; > -arm|aarch64) > -libseccomp_minver="2.2.3" > -;; > -ppc|ppc64|s390x) > -libseccomp_minver="2.3.0" > -;; > -*) > -libseccomp_minver="" > -;; > -esac > - > -if test "$libseccomp_minver" != "" && > - $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then > +libseccomp_minver="2.3.0" > +if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then > seccomp_cflags="$($pkg_config --cflags libseccomp)" > seccomp_libs="$($pkg_config --libs libseccomp)" > seccomp="yes" > else > if test "$seccomp" = "yes" ; then > -if test "$libseccomp_minver" != "" ; then > -feature_not_found "libseccomp" \ > -"Install libseccomp devel >= $libseccomp_minver" > -else > -feature_not_found "libseccomp" \ > -"libseccomp is not supported for host cpu $cpu" > -fi > +feature_not_found "libseccomp" \ > + "Install libseccomp devel >= $libseccomp_minver" > fi > seccomp="no" > fi Reviewed-by: Thomas Huth
