Re: [Qemu-devel] [PATCH v2] hw/misc: add missing includes

2017-06-27 Thread Michael Tokarev
Applied to -trivial, thanks!

/mjt



Re: [Qemu-devel] [PATCH v2] hw/misc: add missing includes

2017-06-09 Thread Eric Blake
On 06/09/2017 10:06 AM, Philippe Mathieu-Daudé wrote:
> inlined create_unimplemented_device() calls sysbus_mmio_map_overlap().
> 
> Signed-off-by: Philippe Mathieu-Daudé 
> ---
> 
> v2: Addressed review feedback from Eric Blake
> 
>  include/hw/misc/unimp.h | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Eric Blake 

> 
> diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h
> index 3462d85836..52e068ec3e 100644
> --- a/include/hw/misc/unimp.h
> +++ b/include/hw/misc/unimp.h
> @@ -8,6 +8,8 @@
>  #ifndef HW_MISC_UNIMP_H
>  #define HW_MISC_UNIMP_H
>  
> +#include "hw/sysbus.h"
> +
>  #define TYPE_UNIMPLEMENTED_DEVICE "unimplemented-device"
>  
>  /**
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature


Re: [Qemu-devel] [PATCH v2] hw/misc: add missing includes

2017-06-09 Thread Philippe Mathieu-Daudé
I intended to send those 3 patches as separate since unrelated, but 
failed again, sorry :S


On 06/09/2017 12:06 PM, Philippe Mathieu-Daudé wrote:

inlined create_unimplemented_device() calls sysbus_mmio_map_overlap().

Signed-off-by: Philippe Mathieu-Daudé 
---

v2: Addressed review feedback from Eric Blake

 include/hw/misc/unimp.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h
index 3462d85836..52e068ec3e 100644
--- a/include/hw/misc/unimp.h
+++ b/include/hw/misc/unimp.h
@@ -8,6 +8,8 @@
 #ifndef HW_MISC_UNIMP_H
 #define HW_MISC_UNIMP_H

+#include "hw/sysbus.h"
+
 #define TYPE_UNIMPLEMENTED_DEVICE "unimplemented-device"

 /**