Re: [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock
On 15.07.2014 17:17, Paolo Bonzini wrote: Il 15/07/2014 16:44, Stefan Hajnoczi ha scritto: v2: * Leave BH scheduled so that the code can be simplified [Paolo] These patches convert thread-pool.c from EventNotifier to QEMUBH. They then solve the deadlock when nested aio_poll() calls are made. Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of the nested aio_poll() deadlock ever having been reported, so maybe we can defer to QEMU 2.2. It was reported as a hang in block_commit. Marcin, can you please test these patches? Sorry for late answer - yes, it seems to fix block_commit hang when using thread-pool. -- mg
Re: [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock
On Tue, Jul 15, 2014 at 04:44:24PM +0200, Stefan Hajnoczi wrote: > v2: > * Leave BH scheduled so that the code can be simplified [Paolo] > > These patches convert thread-pool.c from EventNotifier to QEMUBH. They then > solve the deadlock when nested aio_poll() calls are made. > > Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of > the nested aio_poll() deadlock ever having been reported, so maybe we can > defer > to QEMU 2.2. > > Stefan Hajnoczi (2): > thread-pool: avoid per-thread-pool EventNotifier > thread-pool: avoid deadlock in nested aio_poll() calls > > thread-pool.c | 27 ++- > 1 file changed, 14 insertions(+), 13 deletions(-) Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan pgpLNakuwXeT9.pgp Description: PGP signature
Re: [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock
W dniu 2014-07-15 17:17, Paolo Bonzini pisze: Il 15/07/2014 16:44, Stefan Hajnoczi ha scritto: v2: * Leave BH scheduled so that the code can be simplified [Paolo] These patches convert thread-pool.c from EventNotifier to QEMUBH. They then solve the deadlock when nested aio_poll() calls are made. Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of the nested aio_poll() deadlock ever having been reported, so maybe we can defer to QEMU 2.2. It was reported as a hang in block_commit. Marcin, can you please test these patches? I try to test it tomorrow. The same hang was also in linux-aio however (I was able to reproduce it). -- mg
Re: [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock
Il 15/07/2014 16:44, Stefan Hajnoczi ha scritto: v2: * Leave BH scheduled so that the code can be simplified [Paolo] These patches convert thread-pool.c from EventNotifier to QEMUBH. They then solve the deadlock when nested aio_poll() calls are made. Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of the nested aio_poll() deadlock ever having been reported, so maybe we can defer to QEMU 2.2. It was reported as a hang in block_commit. Marcin, can you please test these patches? Paolo
