Re: [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug

2011-07-28 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes:

 Hello,

 This series is on top of the other balloon series for which I sent a
 pull request on Tuesday.

 This series fixes memleak on exit, unregisters the savevm section on
 unplug, disallows negative values as ballooning targets and doesn't
 allow multiple balloon device registrations.

 v2 contains small tweaks suggested:
  - Error is shown by balloon.c instead of virtio-balloon.c in patch 1
(mst)
  - Filter out negative input in do_balloon() and add qerror message
(Markus)
  - Separate out savevm section unregistering from memleak fix

Reviewed-by: Markus Armbruster arm...@redhat.com



Re: [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 11:47:11AM +0530, Amit Shah wrote:
 Hello,
 
 This series is on top of the other balloon series for which I sent a
 pull request on Tuesday.
 
 This series fixes memleak on exit, unregisters the savevm section on
 unplug, disallows negative values as ballooning targets and doesn't
 allow multiple balloon device registrations.
 
 v2 contains small tweaks suggested:
  - Error is shown by balloon.c instead of virtio-balloon.c in patch 1
(mst)
  - Filter out negative input in do_balloon() and add qerror message
(Markus)
  - Separate out savevm section unregistering from memleak fix
 
 
 Amit Shah (5):
   balloon: Don't allow multiple balloon handler registrations
   virtio-balloon: Check if balloon registration failed
   balloon: Ignore negative balloon values
   virtio-balloon: Add exit handler, fix memleaks
   virtio-balloon: Unregister savevm section on device unplug


Acked-by: Michael S. Tsirkin m...@redhat.com

  balloon.c   |   20 +---
  balloon.h   |4 ++--
  hw/virtio-balloon.c |   18 +-
  hw/virtio-pci.c |   14 +-
  hw/virtio.h |1 +
  5 files changed, 50 insertions(+), 7 deletions(-)
 
 -- 
 1.7.6