Re: [Qemu-devel] [PATCH v2 1/4] targphys.h: Define TARGET_PRI*PHYS format specifier macros

2012-06-25 Thread Andreas Färber
Am 25.06.2012 17:52, schrieb Peter Maydell:
 Define a set of TARGET_PRI*PHYS format specifier macros for working
 with target_phys_addr_t types. These follow the standard pattern
 for such macros, and are more flexible than TARGET_FMT_plx, which
 does not allow specification of field widths.
 
 Suggested-by: Andreas Färber afaer...@suse.de
 Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Acked-by: Andreas Färber afaer...@suse.de

Since this version uses a TARGET_ prefix we elegantly workaround the
need for #undef Eric had pointed out in v1.

/-F

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



Re: [Qemu-devel] [PATCH v2 1/4] targphys.h: Define TARGET_PRI*PHYS format specifier macros

2012-06-25 Thread Eric Blake
On 06/25/2012 10:40 AM, Andreas Färber wrote:
 Am 25.06.2012 17:52, schrieb Peter Maydell:
 Define a set of TARGET_PRI*PHYS format specifier macros for working
 with target_phys_addr_t types. These follow the standard pattern
 for such macros, and are more flexible than TARGET_FMT_plx, which
 does not allow specification of field widths.

 Suggested-by: Andreas Färber afaer...@suse.de
 Signed-off-by: Peter Maydell peter.mayd...@linaro.org
 
 Acked-by: Andreas Färber afaer...@suse.de
 
 Since this version uses a TARGET_ prefix we elegantly workaround the
 need for #undef Eric had pointed out in v1.

Agreed - no POSIX collision in this series.

-- 
Eric Blake   ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org





signature.asc
Description: OpenPGP digital signature