Re: [Qemu-devel] [PATCH v2 19/20] arm: add Faraday FTKBC010 support for A369
2013/1/28 Andreas Färber > Am 28.01.2013 07:05, schrieb Kuo-Jung Su: > > Sorry, > > the description was directly copied from the introduction of its > datasheet, > > it appears to be ambigous in this case. > > I thought so for the "high quality" ethernet adapter. ;) The commit > message is supposed to describe the code in technical terms, not > advertise represented hardware products with marketing speech please. > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg > Sorry, that's my bad. It would never happen again. -- Best wishes, Kuo-Jung Su
Re: [Qemu-devel] [PATCH v2 19/20] arm: add Faraday FTKBC010 support for A369
Am 28.01.2013 07:05, schrieb Kuo-Jung Su: > Sorry, > the description was directly copied from the introduction of its datasheet, > it appears to be ambigous in this case. I thought so for the "high quality" ethernet adapter. ;) The commit message is supposed to describe the code in technical terms, not advertise represented hardware products with marketing speech please. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Re: [Qemu-devel] [PATCH v2 19/20] arm: add Faraday FTKBC010 support for A369
Sorry, the description was directly copied from the introduction of its datasheet, it appears to be ambigous in this case. In A369, the FTKBC010 is configured as a keypad controller, not a PS2 keyboard. it acts like some dedicated gpio buttons on the board. In other word: 1. There is no PS2 port on A369. 2. The keypad buttons monitored by FTKBC010 are some hard wired buttons on the board. So it's not appropriate to use existing PS2 keyboard emulation here. Best Wishes Dante Su 2013/1/26 Paul Brook > > From: Kuo-Jung Su > > > > Faraday keyboard/mouse controller (FTKBC010) is compliant with the > > IBM PS/2 interface. > > Your description doesn't appear to match the code at all. Surely if this > were > true then you should be using the existing PS2 keyboard emulation. > > Paul > -- Best wishes, Kuo-Jung Su
Re: [Qemu-devel] [PATCH v2 19/20] arm: add Faraday FTKBC010 support for A369
> From: Kuo-Jung Su > > Faraday keyboard/mouse controller (FTKBC010) is compliant with the > IBM PS/2 interface. Your description doesn't appear to match the code at all. Surely if this were true then you should be using the existing PS2 keyboard emulation. Paul
