Re: [Qemu-devel] [PATCH v2 2/7] Add the additional parent parameter to memory region init calls
Am 23.07.2013 12:00, schrieb Peter Maydell: > On 23 July 2013 10:43, Andreas Färber wrote: >> Am 23.07.2013 11:33, schrieb Mian M. Hamayun: >>> From: "Mian M. Hamayun" >>> >>> The memory region init calls require an additional parent parameter, so >>> introduce a null parent parameter to make it happy. >>> >>> Signed-off-by: Mian M. Hamayun >> >> This is not OK for something labelled "PATCH". Patch series need to be >> bisectable, not fixing up earlier patch series that have not been >> applied yet. > > I have a rebased version of John's mach-virt patch which includes > these fixes; I haven't sent it out yet because I've still been > pondering whether the "create device tree nodes for everything" > code can be made less ugly... I'd also appreciate if you would update cpu/a57core.c wrt the container MemoryRegion and QOM realize (still a SysBus initfn here) - that was the intent of my a15mpcore patches I cc'ed all aarch64 people on. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Re: [Qemu-devel] [PATCH v2 2/7] Add the additional parent parameter to memory region init calls
On 23 July 2013 10:43, Andreas Färber wrote: > Am 23.07.2013 11:33, schrieb Mian M. Hamayun: >> From: "Mian M. Hamayun" >> >> The memory region init calls require an additional parent parameter, so >> introduce a null parent parameter to make it happy. >> >> Signed-off-by: Mian M. Hamayun > > This is not OK for something labelled "PATCH". Patch series need to be > bisectable, not fixing up earlier patch series that have not been > applied yet. I have a rebased version of John's mach-virt patch which includes these fixes; I haven't sent it out yet because I've still been pondering whether the "create device tree nodes for everything" code can be made less ugly... -- PMM
Re: [Qemu-devel] [PATCH v2 2/7] Add the additional parent parameter to memory region init calls
Am 23.07.2013 11:33, schrieb Mian M. Hamayun: > From: "Mian M. Hamayun" > > The memory region init calls require an additional parent parameter, so > introduce a null parent parameter to make it happy. > > Signed-off-by: Mian M. Hamayun This is not OK for something labelled "PATCH". Patch series need to be bisectable, not fixing up earlier patch series that have not been applied yet. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
