Re: [Qemu-devel] [PATCH v23 03/32] qapi: output def_value_str when query command line options
I'll update. All patch series could also be available from: https://github.com/chunyanliu/qemu/commits/QemuOpts On 3/22/2014 at 07:27 AM, in message 532ccadc.40...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 03/21/2014 04:12 AM, Chunyan Liu wrote: Change qapi interfaces to output the newly added def_value_str when querying command line options. Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- qapi-schema.json | 6 +- qmp-commands.hx| 2 ++ util/qemu-config.c | 4 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index b68cd44..cf9174e 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4088,12 +4088,16 @@ # # @help: #optional human readable text string, not suitable for parsing. # +# @default: #optional string representation of the default used +# if the option is omitted. (since 2.0) We've missed 2.0; this needs to be 2.1 now. However, I'm okay if you keep my Reviewed-by with just that change. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org
Re: [Qemu-devel] [PATCH v23 03/32] qapi: output def_value_str when query command line options
On 03/21/2014 04:12 AM, Chunyan Liu wrote: Change qapi interfaces to output the newly added def_value_str when querying command line options. Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- qapi-schema.json | 6 +- qmp-commands.hx| 2 ++ util/qemu-config.c | 4 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index b68cd44..cf9174e 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4088,12 +4088,16 @@ # # @help: #optional human readable text string, not suitable for parsing. # +# @default: #optional string representation of the default used +# if the option is omitted. (since 2.0) We've missed 2.0; this needs to be 2.1 now. However, I'm okay if you keep my Reviewed-by with just that change. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
