Re: [Qemu-devel] [PATCH v3 0/4] timers thread-safe stuff
On Wed, Sep 18, 2013 at 9:54 PM, Stefan Hajnoczi wrote: > On Tue, Aug 27, 2013 at 11:20:59AM +0800, Liu Ping Fan wrote: >> Saw the Alex's patches has been merged, rebase mine onto his. >> >> v3: >> 1. rename seqlock_read_check as seqlock_read_retry >> 2. Document timerlist were protected by BQL, and discard private lock >> around "qemu_event_wait(tl->ev)". >> >> v2: >> 1. fix comment in commit and code >> 2. fix race issue for qemu_clock_enable(foo,disable) >> >> >> Liu Ping Fan (2): >> timer: protect timers_state's clock with seqlock >> timer: make qemu_clock_enable sync between disable and timer's cb >> >> Paolo Bonzini (2): >> seqlock: introduce read-write seqlock >> qemu-thread: add QemuEvent >> >> cpus.c | 36 +++--- >> include/qemu/seqlock.h | 72 +++ >> include/qemu/thread-posix.h | 8 +++ >> include/qemu/thread-win32.h | 4 ++ >> include/qemu/thread.h | 7 +++ >> include/qemu/timer.h| 4 ++ >> qemu-timer.c| 20 +++- >> util/qemu-thread-posix.c| 116 >> >> util/qemu-thread-win32.c| 26 ++ >> 9 files changed, 286 insertions(+), 7 deletions(-) >> create mode 100644 include/qemu/seqlock.h > > Ping Fan: Can you send a final version that addresses Alex's request for > documentation? > > Otherwise we're ready to go. > Sorry, miss this letter, will update it immediately. Thx, Pingfan
Re: [Qemu-devel] [PATCH v3 0/4] timers thread-safe stuff
On Tue, Aug 27, 2013 at 11:20:59AM +0800, Liu Ping Fan wrote: > Saw the Alex's patches has been merged, rebase mine onto his. > > v3: > 1. rename seqlock_read_check as seqlock_read_retry > 2. Document timerlist were protected by BQL, and discard private lock > around "qemu_event_wait(tl->ev)". > > v2: > 1. fix comment in commit and code > 2. fix race issue for qemu_clock_enable(foo,disable) > > > Liu Ping Fan (2): > timer: protect timers_state's clock with seqlock > timer: make qemu_clock_enable sync between disable and timer's cb > > Paolo Bonzini (2): > seqlock: introduce read-write seqlock > qemu-thread: add QemuEvent > > cpus.c | 36 +++--- > include/qemu/seqlock.h | 72 +++ > include/qemu/thread-posix.h | 8 +++ > include/qemu/thread-win32.h | 4 ++ > include/qemu/thread.h | 7 +++ > include/qemu/timer.h| 4 ++ > qemu-timer.c| 20 +++- > util/qemu-thread-posix.c| 116 > > util/qemu-thread-win32.c| 26 ++ > 9 files changed, 286 insertions(+), 7 deletions(-) > create mode 100644 include/qemu/seqlock.h Ping Fan: Can you send a final version that addresses Alex's request for documentation? Otherwise we're ready to go. Stefan
Re: [Qemu-devel] [PATCH v3 0/4] timers thread-safe stuff
On Thu, Sep 12, 2013 at 01:19:47PM +0200, Paolo Bonzini wrote: > Il 27/08/2013 05:20, Liu Ping Fan ha scritto: > > Saw the Alex's patches has been merged, rebase mine onto his. > > > > v3: > > 1. rename seqlock_read_check as seqlock_read_retry > > 2. Document timerlist were protected by BQL, and discard private lock > > around "qemu_event_wait(tl->ev)". > > > > v2: > > 1. fix comment in commit and code > > 2. fix race issue for qemu_clock_enable(foo,disable) > > > > > > Liu Ping Fan (2): > > timer: protect timers_state's clock with seqlock > > timer: make qemu_clock_enable sync between disable and timer's cb > > > > Paolo Bonzini (2): > > seqlock: introduce read-write seqlock > > qemu-thread: add QemuEvent > > > > cpus.c | 36 +++--- > > include/qemu/seqlock.h | 72 +++ > > include/qemu/thread-posix.h | 8 +++ > > include/qemu/thread-win32.h | 4 ++ > > include/qemu/thread.h | 7 +++ > > include/qemu/timer.h| 4 ++ > > qemu-timer.c| 20 +++- > > util/qemu-thread-posix.c| 116 > > > > util/qemu-thread-win32.c| 26 ++ > > 9 files changed, 286 insertions(+), 7 deletions(-) > > create mode 100644 include/qemu/seqlock.h > > > > Stefan, could you pick up these four patches as well? This week Kevin is merging patches into the block tree. If it's still on the list next week I'll pick these patches up. Stefan
Re: [Qemu-devel] [PATCH v3 0/4] timers thread-safe stuff
Il 27/08/2013 05:20, Liu Ping Fan ha scritto: > Saw the Alex's patches has been merged, rebase mine onto his. > > v3: > 1. rename seqlock_read_check as seqlock_read_retry > 2. Document timerlist were protected by BQL, and discard private lock > around "qemu_event_wait(tl->ev)". > > v2: > 1. fix comment in commit and code > 2. fix race issue for qemu_clock_enable(foo,disable) > > > Liu Ping Fan (2): > timer: protect timers_state's clock with seqlock > timer: make qemu_clock_enable sync between disable and timer's cb > > Paolo Bonzini (2): > seqlock: introduce read-write seqlock > qemu-thread: add QemuEvent > > cpus.c | 36 +++--- > include/qemu/seqlock.h | 72 +++ > include/qemu/thread-posix.h | 8 +++ > include/qemu/thread-win32.h | 4 ++ > include/qemu/thread.h | 7 +++ > include/qemu/timer.h| 4 ++ > qemu-timer.c| 20 +++- > util/qemu-thread-posix.c| 116 > > util/qemu-thread-win32.c| 26 ++ > 9 files changed, 286 insertions(+), 7 deletions(-) > create mode 100644 include/qemu/seqlock.h > Stefan, could you pick up these four patches as well? Paolo
