Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event

2012-02-22 Thread Kevin Wolf 
Am 22.02.2012 13:53, schrieb Luiz Capitulino:
> On Mon, 20 Feb 2012 09:28:15 +0100
> Markus Armbruster  wrote:
> 
>> Luiz Capitulino  writes:
>>
>>> The event name changed, which caused the subject to change too, hope this
>>> won't cause confusion.
>>>
>>> v3
>>>
>>> o Rename the event to DEVICE_TRAY_MOVED
>>> o Rename the 'ejected' event data to 'tray-open'
>>> o Only call bdrv_eject() if the tray state changed
>>> o Drop ide_tray_state_post_load()
>>
>> Reviewed-by: Markus Armbruster 
> 
> Kevin, I'd like to get your ack before applying it to the qmp branch.

Acked-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event

2012-02-22 Thread Luiz Capitulino 
On Mon, 20 Feb 2012 09:28:15 +0100
Markus Armbruster  wrote:

> Luiz Capitulino  writes:
> 
> > The event name changed, which caused the subject to change too, hope this
> > won't cause confusion.
> >
> > v3
> >
> > o Rename the event to DEVICE_TRAY_MOVED
> > o Rename the 'ejected' event data to 'tray-open'
> > o Only call bdrv_eject() if the tray state changed
> > o Drop ide_tray_state_post_load()
> 
> Reviewed-by: Markus Armbruster 

Kevin, I'd like to get your ack before applying it to the qmp branch.

Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event

2012-02-20 Thread Markus Armbruster 
Luiz Capitulino  writes:

> The event name changed, which caused the subject to change too, hope this
> won't cause confusion.
>
> v3
>
> o Rename the event to DEVICE_TRAY_MOVED
> o Rename the 'ejected' event data to 'tray-open'
> o Only call bdrv_eject() if the tray state changed
> o Drop ide_tray_state_post_load()

Reviewed-by: Markus Armbruster