Re: [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf

2014-09-26 Thread Kevin Wolf 
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
 This is consistent with how VirtIOFOOConf variables are named
 elsewhere, and makes blk available for BlockBackend variables.
 
 Signed-off-by: Markus Armbruster arm...@redhat.com

Reviewed-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf

2014-09-20 Thread Max Reitz 

On 16.09.2014 20:12, Markus Armbruster wrote:

This is consistent with how VirtIOFOOConf variables are named
elsewhere, and makes blk available for BlockBackend variables.

Signed-off-by: Markus Armbruster arm...@redhat.com
---
  hw/block/dataplane/virtio-blk.c | 33 +-
  hw/block/dataplane/virtio-blk.h |  2 +-
  hw/block/virtio-blk.c   | 52 -
  include/hw/virtio/virtio-blk.h  |  2 +-
  4 files changed, 45 insertions(+), 44 deletions(-)


Reviewed-by: Max Reitz mre...@redhat.com

Re: [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf

2014-09-18 Thread Markus Armbruster 
Benoît Canet benoit.ca...@nodalink.com writes:

 -if (size % dev-blk.conf.logical_block_size) {
 +if (size % dev-conf.conf.logical_block_size) {

 This look strange (conf.conf)

Yeah, it does.  I picked conf anyway, for consistency with the existing
similar members of sibling structs VirtIOSCSICommon and VirtIORNG.

 Anyway this seems correct.

 Reviewed-by: Benoit Canet benoit.ca...@nodalink.com

Thanks!

Re: [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf

2014-09-17 Thread Benoît Canet 
 -if (size % dev-blk.conf.logical_block_size) {
 +if (size % dev-conf.conf.logical_block_size) {

This look strange (conf.conf)

Anyway this seems correct.

Reviewed-by: Benoit Canet benoit.ca...@nodalink.com