Re: [Qemu-devel] [PATCH v3 4/4] machine: remove iommu property

[Jan Kiszka]

On 2016-06-15 00:03, Paolo Bonzini wrote:
> 
> 
> On 14/06/2016 20:38, Eduardo Habkost wrote:
>> On Mon, Jun 13, 2016 at 05:37:00PM +0300, Marcel Apfelbaum wrote:
>>> Since iommu devices can be created with '-device' there is
>>> no need to keep iommu as machine and mch property.
>>>
>>> Signed-off-by: Marcel Apfelbaum 
>>
>> On the one hand, the option is present since v2.2.0. On the other
>> hand, it is present only in q35, and the property really doesn't
>> belong to TYPE_MACHINE (so even if we decide to keep it for a few
>> releases, property registration needs to be moved to
>> pc_q35_machine_options().
>>
>> What kind of usage the existing code has, currently? Development
>> and debugging only, or is there any chance somebody might be
>> using it in production?
> 
> Definitely development and debugging only.  Someone might be using it in
> automated tests, but that's pretty much it.

Agreed.

Even we didn't recommended the IOMMU and therefore also this switch to
Jailhouse users trying things out under QEMU (because we also need IR
which isn't mainline yet).

Jan




signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3 4/4] machine: remove iommu property

[Paolo Bonzini]

On 14/06/2016 20:38, Eduardo Habkost wrote:
> On Mon, Jun 13, 2016 at 05:37:00PM +0300, Marcel Apfelbaum wrote:
>> Since iommu devices can be created with '-device' there is
>> no need to keep iommu as machine and mch property.
>>
>> Signed-off-by: Marcel Apfelbaum 
> 
> On the one hand, the option is present since v2.2.0. On the other
> hand, it is present only in q35, and the property really doesn't
> belong to TYPE_MACHINE (so even if we decide to keep it for a few
> releases, property registration needs to be moved to
> pc_q35_machine_options().
> 
> What kind of usage the existing code has, currently? Development
> and debugging only, or is there any chance somebody might be
> using it in production?

Definitely development and debugging only.  Someone might be using it in
automated tests, but that's pretty much it.

Paolo

Re: [Qemu-devel] [PATCH v3 4/4] machine: remove iommu property

[Eduardo Habkost]

On Mon, Jun 13, 2016 at 05:37:00PM +0300, Marcel Apfelbaum wrote:
> Since iommu devices can be created with '-device' there is
> no need to keep iommu as machine and mch property.
> 
> Signed-off-by: Marcel Apfelbaum 

On the one hand, the option is present since v2.2.0. On the other
hand, it is present only in q35, and the property really doesn't
belong to TYPE_MACHINE (so even if we decide to keep it for a few
releases, property registration needs to be moved to
pc_q35_machine_options().

What kind of usage the existing code has, currently? Development
and debugging only, or is there any chance somebody might be
using it in production?

-- 
Eduardo