Re: [Qemu-devel] [PATCH v3 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test

2012-07-30 Thread Stefan Hajnoczi
On Fri, Jul 27, 2012 at 2:30 PM, Kevin Wolf kw...@redhat.com wrote:
 Am 27.07.2012 10:05, schrieb Stefan Hajnoczi:
 This tests establishes the basic post-conditions of the qcow2 lazy
 refcounts features:

   1. If the image was closed normally, it is marked clean.

   2. If an allocating write was performed and the image was not closed
  normally, then it is marked dirty.

  a. Written data can be read back successfully.
  b. The image file can be repaired and will be marked clean again.
  c. The image file is automatically repaired when opened read/write.

 Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

 Thanks, applied all patches for now. But can you please respin this
 single patch to make it work with -nocache?

Sure.

Stefan



Re: [Qemu-devel] [PATCH v3 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test

2012-07-27 Thread Kevin Wolf
Am 27.07.2012 10:05, schrieb Stefan Hajnoczi:
 This tests establishes the basic post-conditions of the qcow2 lazy
 refcounts features:
 
   1. If the image was closed normally, it is marked clean.
 
   2. If an allocating write was performed and the image was not closed
  normally, then it is marked dirty.
 
  a. Written data can be read back successfully.
  b. The image file can be repaired and will be marked clean again.
  c. The image file is automatically repaired when opened read/write.
 
 Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

Thanks, applied all patches for now. But can you please respin this
single patch to make it work with -nocache? I don't really mind how you
do it, options include skipping the test, overriding the cache option,
possibly inserting some 'flush' qemu-io commands etc. It just shouldn't
fail (even more so because -nocache is the option I use the most with
qemu-iotests).

Kevin