Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory
Michael Tokarev writes: > 03.11.2014 10:56, Markus Armbruster wrote: >> Michael Tokarev writes: > [] >>> I'm not sure this qualifies as -trivial really. Yes the change >>> does not affect anything but the `info' command, and is rather >>> simple, but... I'm not sure. >> >> Fortunately, monitor.c got a maintainer. Luiz, would you be willing to >> shepherd this patch? > > He already replied to that, that's why the whole thing has been Cc'd > to -trivial: > > """I can, but I don't have bandwidth for another pull request for v2.2 unless > it's a fix for a blocker. This means you have two options, wait for v2.3 > or find another tree to merge this.""" > > (http://patchwork.ozlabs.org/patch/400457/) Right, I had already forgotten. It's a bug fix for "info numa". Whether the fix is important enough to justify another pull for 2.2 is for Luiz to decide. Whether it's trivial enough for you to take it via -trivial is for you to decide. If you both say no, it goes into 2.3 via Luiz. Not exactly terrible.
Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory
03.11.2014 10:56, Markus Armbruster wrote: > Michael Tokarev writes: [] >> I'm not sure this qualifies as -trivial really. Yes the change >> does not affect anything but the `info' command, and is rather >> simple, but... I'm not sure. > > Fortunately, monitor.c got a maintainer. Luiz, would you be willing to > shepherd this patch? He already replied to that, that's why the whole thing has been Cc'd to -trivial: """I can, but I don't have bandwidth for another pull request for v2.2 unless it's a fix for a blocker. This means you have two options, wait for v2.3 or find another tree to merge this.""" (http://patchwork.ozlabs.org/patch/400457/) Thanks, /mjt
Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory
Hi Michael, Can you help applying this patch to -trivial branch? It has been reviewed, and it mainly fix bug for hmp command of 'info numa'. Which i don't know if it should go qemu-stable, for this is not a blocker. Maybe go trivial branch is a better choice. Thanks, zhanghailiang On 2014/10/27 20:46, Luiz Capitulino wrote: On Mon, 27 Oct 2014 17:40:11 +0800 zhanghailiang wrote: Hi Luiz, Can you apply this to your qmp branch? It has been reviewd;) I can, but I don't have bandwidth for another pull request for v2.2 unless it's a fix for a blocker. This means you have two options, wait for v2.3 or find another tree to merge this. Thanks, zhanghailiang On 2014/10/23 8:32, zhanghailiang wrote: Hi, Ping... This patch has been reviewed, please pick up, Thanks. Best Regargs, zhanghailiang On 2014/10/17 17:02, Gonglei wrote: On 2014/10/17 16:50, zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command "info numa". Reviewed-by: Igor Mammedov Signed-off-by: zhanghailiang --- v6: - remove unnecessary 'di' variable (GongLei) v5: - reword the subject (Igor Mammedov) - turn query_numa_node_mem to void (Igor Mammedov) v4: - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov) - rewrite numa_stat_memory_devices and this will also fix compile error for targets that don't support memory hotplug v3: - cold-plugged memory should not be excluded (Igor Mammedov) v2: - Don't modify the numa_info.node_mem directly when treating hotplug memory, fix the "info numa" instead (Igor Mammedov) Thanks for review!;) --- include/sysemu/sysemu.h | 1 + monitor.c | 6 +- numa.c | 38 ++ 3 files changed, 44 insertions(+), 1 deletion(-) Reviewed-by: Gonglei Best regards, -Gonglei . .
Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory
On 2014/10/27 20:46, Luiz Capitulino wrote: On Mon, 27 Oct 2014 17:40:11 +0800 zhanghailiang wrote: Hi Luiz, Can you apply this to your qmp branch? It has been reviewd;) I can, but I don't have bandwidth for another pull request for v2.2 unless it's a fix for a blocker. This means you have two options, wait for v2.3 or find another tree to merge this. OK, i will wait for v2.3, thanks;) Thanks, zhanghailiang On 2014/10/23 8:32, zhanghailiang wrote: Hi, Ping... This patch has been reviewed, please pick up, Thanks. Best Regargs, zhanghailiang On 2014/10/17 17:02, Gonglei wrote: On 2014/10/17 16:50, zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command "info numa". Reviewed-by: Igor Mammedov Signed-off-by: zhanghailiang --- v6: - remove unnecessary 'di' variable (GongLei) v5: - reword the subject (Igor Mammedov) - turn query_numa_node_mem to void (Igor Mammedov) v4: - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov) - rewrite numa_stat_memory_devices and this will also fix compile error for targets that don't support memory hotplug v3: - cold-plugged memory should not be excluded (Igor Mammedov) v2: - Don't modify the numa_info.node_mem directly when treating hotplug memory, fix the "info numa" instead (Igor Mammedov) Thanks for review!;) --- include/sysemu/sysemu.h | 1 + monitor.c | 6 +- numa.c | 38 ++ 3 files changed, 44 insertions(+), 1 deletion(-) Reviewed-by: Gonglei Best regards, -Gonglei . .
Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory
On Mon, 27 Oct 2014 17:40:11 +0800 zhanghailiang wrote: > Hi Luiz, > > Can you apply this to your qmp branch? > It has been reviewd;) I can, but I don't have bandwidth for another pull request for v2.2 unless it's a fix for a blocker. This means you have two options, wait for v2.3 or find another tree to merge this. > > Thanks, > zhanghailiang > > On 2014/10/23 8:32, zhanghailiang wrote: > > Hi, > > > > Ping... > > This patch has been reviewed, please pick up, Thanks. > > > > Best Regargs, > > zhanghailiang > > > > On 2014/10/17 17:02, Gonglei wrote: > >> On 2014/10/17 16:50, zhanghailiang wrote: > >> > >>> When do memory hotplug, if there is numa node, we should add > >>> the memory size to the corresponding node memory size. > >>> > >>> For now, it mainly affects the result of hmp command "info numa". > >>> > >>> Reviewed-by: Igor Mammedov > >>> Signed-off-by: zhanghailiang > >>> --- > >>> v6: > >>> - remove unnecessary 'di' variable (GongLei) > >>> v5: > >>> - reword the subject (Igor Mammedov) > >>> - turn query_numa_node_mem to void (Igor Mammedov) > >>> v4: > >>> - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov) > >>> - rewrite numa_stat_memory_devices and this will also fix compile error > >>> for > >>>targets that don't support memory hotplug > >>> v3: > >>> - cold-plugged memory should not be excluded (Igor Mammedov) > >>> v2: > >>> - Don't modify the numa_info.node_mem directly when treating hotplug > >>> memory, > >>>fix the "info numa" instead (Igor Mammedov) > >>> > >>> Thanks for review!;) > >>> --- > >>> > >>> include/sysemu/sysemu.h | 1 + > >>> monitor.c | 6 +- > >>> numa.c | 38 ++ > >>> 3 files changed, 44 insertions(+), 1 deletion(-) > >>> > >> > >> Reviewed-by: Gonglei > >> > >> Best regards, > >> -Gonglei > >> > >> > >> . > >> > > > > > > > > > > > >
Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory
Hi Luiz, Can you apply this to your qmp branch? It has been reviewd;) Thanks, zhanghailiang On 2014/10/23 8:32, zhanghailiang wrote: Hi, Ping... This patch has been reviewed, please pick up, Thanks. Best Regargs, zhanghailiang On 2014/10/17 17:02, Gonglei wrote: On 2014/10/17 16:50, zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command "info numa". Reviewed-by: Igor Mammedov Signed-off-by: zhanghailiang --- v6: - remove unnecessary 'di' variable (GongLei) v5: - reword the subject (Igor Mammedov) - turn query_numa_node_mem to void (Igor Mammedov) v4: - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov) - rewrite numa_stat_memory_devices and this will also fix compile error for targets that don't support memory hotplug v3: - cold-plugged memory should not be excluded (Igor Mammedov) v2: - Don't modify the numa_info.node_mem directly when treating hotplug memory, fix the "info numa" instead (Igor Mammedov) Thanks for review!;) --- include/sysemu/sysemu.h | 1 + monitor.c | 6 +- numa.c | 38 ++ 3 files changed, 44 insertions(+), 1 deletion(-) Reviewed-by: Gonglei Best regards, -Gonglei .
Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory
Hi, Ping... This patch has been reviewed, please pick up, Thanks. Best Regargs, zhanghailiang On 2014/10/17 17:02, Gonglei wrote: On 2014/10/17 16:50, zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command "info numa". Reviewed-by: Igor Mammedov Signed-off-by: zhanghailiang --- v6: - remove unnecessary 'di' variable (GongLei) v5: - reword the subject (Igor Mammedov) - turn query_numa_node_mem to void (Igor Mammedov) v4: - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov) - rewrite numa_stat_memory_devices and this will also fix compile error for targets that don't support memory hotplug v3: - cold-plugged memory should not be excluded (Igor Mammedov) v2: - Don't modify the numa_info.node_mem directly when treating hotplug memory, fix the "info numa" instead (Igor Mammedov) Thanks for review!;) --- include/sysemu/sysemu.h | 1 + monitor.c | 6 +- numa.c | 38 ++ 3 files changed, 44 insertions(+), 1 deletion(-) Reviewed-by: Gonglei Best regards, -Gonglei .
Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory
On 2014/10/17 16:50, zhanghailiang wrote: > When do memory hotplug, if there is numa node, we should add > the memory size to the corresponding node memory size. > > For now, it mainly affects the result of hmp command "info numa". > > Reviewed-by: Igor Mammedov > Signed-off-by: zhanghailiang > --- > v6: > - remove unnecessary 'di' variable (GongLei) > v5: > - reword the subject (Igor Mammedov) > - turn query_numa_node_mem to void (Igor Mammedov) > v4: > - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov) > - rewrite numa_stat_memory_devices and this will also fix compile error for > targets that don't support memory hotplug > v3: > - cold-plugged memory should not be excluded (Igor Mammedov) > v2: > - Don't modify the numa_info.node_mem directly when treating hotplug memory, > fix the "info numa" instead (Igor Mammedov) > > Thanks for review!;) > --- > > include/sysemu/sysemu.h | 1 + > monitor.c | 6 +- > numa.c | 38 ++ > 3 files changed, 44 insertions(+), 1 deletion(-) > Reviewed-by: Gonglei Best regards, -Gonglei
