Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes
On 10/13/2016 11:59 PM, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Checking PATCH 13/15: nbd: Improve server handling of shutdown requests... > ERROR: return of an errno should typically be -ve (return -ESHUTDOWN) > #63: FILE: nbd/client.c:38: > +return ESHUTDOWN; > > total: 1 errors, 0 warnings, 95 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. False positive; although we COULD rewrite the function to do: ret = ESHUTDOWN; return ret; (and so on for all the cases in the switch), to hide the fact that we intentionally want to return a positive errno value, if it bothers anyone enough to ask me to do so. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes Type: series Message-id: 1476392335-9256-1-git-send-email-ebl...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3e3cab6 nbd: Implement NBD_CMD_WRITE_ZEROES on client 6127973 nbd: Implement NBD_CMD_WRITE_ZEROES on server dbe675e nbd: Improve server handling of shutdown requests d86be2e nbd: Support shorter handshake 598c0b0 nbd: Less allocation during NBD_OPT_LIST 71d9fb4 nbd: Let client skip portions of server reply 4554cca nbd: Let server know when client gives up negotiation c33b361 nbd: Share common option-sending code in client 9e216fe nbd: Send message along with server NBD_REP_ERR errors 761e798 nbd: Share common reply-sending code in server dd5e949 nbd: Rename struct nbd_request and nbd_reply 45a155f nbd: Rename NbdClientSession to NBDClientSession 00f1816 nbd: Rename NBDRequest to NBDRequestData bcd4778 nbd: Treat flags vs. command type as separate fields fde7920 nbd: Add qemu-nbd -D for human-readable description === OUTPUT BEGIN === Checking PATCH 1/15: nbd: Add qemu-nbd -D for human-readable description... Checking PATCH 2/15: nbd: Treat flags vs. command type as separate fields... Checking PATCH 3/15: nbd: Rename NBDRequest to NBDRequestData... Checking PATCH 4/15: nbd: Rename NbdClientSession to NBDClientSession... Checking PATCH 5/15: nbd: Rename struct nbd_request and nbd_reply... Checking PATCH 6/15: nbd: Share common reply-sending code in server... Checking PATCH 7/15: nbd: Send message along with server NBD_REP_ERR errors... Checking PATCH 8/15: nbd: Share common option-sending code in client... Checking PATCH 9/15: nbd: Let server know when client gives up negotiation... Checking PATCH 10/15: nbd: Let client skip portions of server reply... Checking PATCH 11/15: nbd: Less allocation during NBD_OPT_LIST... Checking PATCH 12/15: nbd: Support shorter handshake... Checking PATCH 13/15: nbd: Improve server handling of shutdown requests... ERROR: return of an errno should typically be -ve (return -ESHUTDOWN) #63: FILE: nbd/client.c:38: +return ESHUTDOWN; total: 1 errors, 0 warnings, 95 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 14/15: nbd: Implement NBD_CMD_WRITE_ZEROES on server... Checking PATCH 15/15: nbd: Implement NBD_CMD_WRITE_ZEROES on client... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org
Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes
On 10/13/2016 07:00 PM, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > /tmp/qemu-test/src/nbd/client.c: In function 'nbd_errno_to_system_errno': > /tmp/qemu-test/src/nbd/client.c:38:16: error: 'ESHUTDOWN' undeclared (first > use in this function) > return ESHUTDOWN; > ^ Oh fun, I get to work around a missing errno value on mingw. I'll come up with something to squash in to 13/15. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1476392335-9256-1-git-send-email-ebl...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=16 make docker-test-quick@centos6 make docker-test-mingw@fedora === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1476399422-8028-1-git-send-email-js...@redhat.com -> patchew/1476399422-8028-1-git-send-email-js...@redhat.com Switched to a new branch 'test' 3e3cab6 nbd: Implement NBD_CMD_WRITE_ZEROES on client 6127973 nbd: Implement NBD_CMD_WRITE_ZEROES on server dbe675e nbd: Improve server handling of shutdown requests d86be2e nbd: Support shorter handshake 598c0b0 nbd: Less allocation during NBD_OPT_LIST 71d9fb4 nbd: Let client skip portions of server reply 4554cca nbd: Let server know when client gives up negotiation c33b361 nbd: Share common option-sending code in client 9e216fe nbd: Send message along with server NBD_REP_ERR errors 761e798 nbd: Share common reply-sending code in server dd5e949 nbd: Rename struct nbd_request and nbd_reply 45a155f nbd: Rename NbdClientSession to NBDClientSession 00f1816 nbd: Rename NBDRequest to NBDRequestData bcd4778 nbd: Treat flags vs. command type as separate fields fde7920 nbd: Add qemu-nbd -D for human-readable description === OUTPUT BEGIN === Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into 'dtc'... Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' BUILD centos6 ARCHIVE qemu.tgz ARCHIVE dtc.tgz COPYRUNNER RUN test-quick in centos6 Packages installed: SDL-devel-1.2.14-7.el6_7.1.x86_64 ccache-3.1.6-2.el6.x86_64 epel-release-6-8.noarch gcc-4.4.7-17.el6.x86_64 git-1.7.1-4.el6_7.1.x86_64 glib2-devel-2.28.8-5.el6.x86_64 libfdt-devel-1.4.0-1.el6.x86_64 make-3.81-23.el6.x86_64 package g++ is not installed pixman-devel-0.32.8-1.el6.x86_64 tar-1.23-15.el6_8.x86_64 zlib-devel-1.2.3-29.el6.x86_64 Environment variables: PACKAGES=libfdt-devel ccache tar git make gcc g++ zlib-devel glib2-devel SDL-devel pixman-devel epel-release HOSTNAME=29f210180aca TERM=xterm MAKEFLAGS= -j16 HISTSIZE=1000 J=16 USER=root CCACHE_DIR=/var/tmp/ccache EXTRA_CONFIGURE_OPTS= V= SHOW_ENV=1 MAIL=/var/spool/mail/root PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD=/ LANG=en_US.UTF-8 TARGET_LIST= HISTCONTROL=ignoredups SHLVL=1 HOME=/root TEST_DIR=/tmp/qemu-test LOGNAME=root LESSOPEN=||/usr/bin/lesspipe.sh %s FEATURES= dtc DEBUG= G_BROKEN_FILENAMES=1 CCACHE_HASHDIR= _=/usr/bin/env Configure options: --enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/var/tmp/qemu-build/install No C++ compiler available; disabling C++ specific optional code Install prefix/var/tmp/qemu-build/install BIOS directory/var/tmp/qemu-build/install/share/qemu binary directory /var/tmp/qemu-build/install/bin library directory /var/tmp/qemu-build/install/lib module directory /var/tmp/qemu-build/install/lib/qemu libexec directory /var/tmp/qemu-build/install/libexec include directory /var/tmp/qemu-build/install/include config directory /var/tmp/qemu-build/install/etc local state directory /var/tmp/qemu-build/install/var Manual directory /var/tmp/qemu-build/install/share/man ELF interp prefix /usr/gnemul/qemu-%M Source path /tmp/qemu-test/src C compilercc Host C compiler cc C++ compiler Objective-C compiler cc ARFLAGS rv CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g QEMU_CFLAGS -I/usr/include/pixman-1-pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fPIE -DPIE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g make make install install pythonpython -B smbd /usr/sbin/smbd module supportno host CPU x86_64 host big endian no target list x86_64-softmmu aarch64-softmmu tcg debug enabled no gprof enabled no sparse enabledno strip binariesyes profiler no static build no pixmansystem SDL support yes (1.2.14) GTK support no GTK GL supportno VTE support no TLS priority
