Re: [Qemu-devel] [PATCH v6 3/8] linux-user/strace: Improve settimeofday()
Le 10/09/2019 à 10:30, Laurent Vivier a écrit :
> Le 08/09/2019 à 08:15, Philippe Mathieu-Daudé a écrit :
>> Signed-off-by: Philippe Mathieu-Daudé
>> Tested-By: Guido Günther
>> Reviewed-by: Laurent Vivier
>> ---
>> linux-user/strace.c| 13 +
>> linux-user/strace.list | 2 +-
>> 2 files changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/linux-user/strace.c b/linux-user/strace.c
>> index 5ee9d62c25..dcf843b360 100644
>> --- a/linux-user/strace.c
>> +++ b/linux-user/strace.c
>> @@ -1584,6 +1584,19 @@ print_futimesat(const struct syscallname *name,
>> }
>> #endif
>>
>> +#ifdef TARGET_NR_settimeofday
>> +static void
>> +print_settimeofday(const struct syscallname *name,
>> +abi_long arg0, abi_long arg1, abi_long arg2,
>> +abi_long arg3, abi_long arg4, abi_long arg5)
>> +{
>> +print_syscall_prologue(name);
>> +print_timeval(arg0, 0);
>> +print_timezone(arg1, 1);
>> +print_syscall_epilogue(name);
>> +}
>> +#endif
>> +
>> #ifdef TARGET_NR_link
>> static void
>> print_link(const struct syscallname *name,
>> diff --git a/linux-user/strace.list b/linux-user/strace.list
>> index 63a946642d..1ff9168369 100644
>> --- a/linux-user/strace.list
>> +++ b/linux-user/strace.list
>> @@ -1345,7 +1345,7 @@
>> { TARGET_NR_set_tid_address, "set_tid_address" , NULL, NULL, NULL },
>> #endif
>> #ifdef TARGET_NR_settimeofday
>> -{ TARGET_NR_settimeofday, "settimeofday" , NULL, NULL, NULL },
>> +{ TARGET_NR_settimeofday, "settimeofday" , NULL, print_settimeofday, NULL },
>> #endif
>> #ifdef TARGET_NR_setuid
>> { TARGET_NR_setuid, "setuid" , NULL, NULL, NULL },
>>
>
> Applied to my linux-user branch.
Unapplied as it depends on the previous one.
Thanks,
Laurent
Re: [Qemu-devel] [PATCH v6 3/8] linux-user/strace: Improve settimeofday()
Le 08/09/2019 à 08:15, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé
> Tested-By: Guido Günther
> Reviewed-by: Laurent Vivier
> ---
> linux-user/strace.c| 13 +
> linux-user/strace.list | 2 +-
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 5ee9d62c25..dcf843b360 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -1584,6 +1584,19 @@ print_futimesat(const struct syscallname *name,
> }
> #endif
>
> +#ifdef TARGET_NR_settimeofday
> +static void
> +print_settimeofday(const struct syscallname *name,
> +abi_long arg0, abi_long arg1, abi_long arg2,
> +abi_long arg3, abi_long arg4, abi_long arg5)
> +{
> +print_syscall_prologue(name);
> +print_timeval(arg0, 0);
> +print_timezone(arg1, 1);
> +print_syscall_epilogue(name);
> +}
> +#endif
> +
> #ifdef TARGET_NR_link
> static void
> print_link(const struct syscallname *name,
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index 63a946642d..1ff9168369 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -1345,7 +1345,7 @@
> { TARGET_NR_set_tid_address, "set_tid_address" , NULL, NULL, NULL },
> #endif
> #ifdef TARGET_NR_settimeofday
> -{ TARGET_NR_settimeofday, "settimeofday" , NULL, NULL, NULL },
> +{ TARGET_NR_settimeofday, "settimeofday" , NULL, print_settimeofday, NULL },
> #endif
> #ifdef TARGET_NR_setuid
> { TARGET_NR_setuid, "setuid" , NULL, NULL, NULL },
>
Applied to my linux-user branch.
Thanks,
Laurent
