Re: [Qemu-devel] [PULL 0/1] seccomp branch queue
On 12/04/2019 - 12:52:48, Peter Maydell wrote: > On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo wrote: > > > > The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949: > > > > Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100) > > > > are available in the Git repository at: > > > > https://github.com/otubo/qemu.git tags/pull-seccomp-20190412 > > > > for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c: > > > > configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200) > > > > > > pull-seccomp-20190412 > > > > > > Helge Deller (1): > > configure: Relax check for libseccomp > > Is this really release critical? If you're sending pull > requests for rc3/rc4 it is extremely helpful if you can > give the justification for why they need to go into this > release. (As it happens we're going to need an rc4, but > I want to keep the set of changes in it to a minimum.) > This is not critical. I'll send again after the current release. -- Eduardo Otubo Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn, Handelsregister: Amtsgericht München, HRB 153243, Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander signature.asc Description: PGP signature
Re: [Qemu-devel] [PULL 0/1] seccomp branch queue
On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo wrote: > > The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949: > > Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100) > > are available in the Git repository at: > > https://github.com/otubo/qemu.git tags/pull-seccomp-20190412 > > for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c: > > configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200) > > > pull-seccomp-20190412 > > > Helge Deller (1): > configure: Relax check for libseccomp Is this really release critical? If you're sending pull requests for rc3/rc4 it is extremely helpful if you can give the justification for why they need to go into this release. (As it happens we're going to need an rc4, but I want to keep the set of changes in it to a minimum.) thanks -- PMM
Re: [Qemu-devel] [PULL 0/1] seccomp branch queue
On 21/03/2019 - 09:30:24, Peter Maydell wrote: > On Wed, 20 Mar 2019 at 15:11, Eduardo Otubo wrote: > > > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > > > are available in the Git repository at: > > > > https://github.com/otubo/qemu.git tags/pull-seccomp-20190320 > > > > for you to fetch changes up to a25f1f63814c8ac5347a4d744c5bbad2702ef51c: > > > > seccomp: don't kill process for resource control syscalls (2019-03-20 > > 16:05:02 +0100) > > > > > > pull-seccomp-20190320 > > > > > > Daniel P. Berrangé (1): > > seccomp: don't kill process for resource control syscalls > > Hi; I'm afraid this doesn't build on all platforms: > > On PPC64 and also on my x86-64 box: > /home/pm215/qemu/qemu-seccomp.c: In function ‘seccomp_start’: > /home/pm215/qemu/qemu-seccomp.c:181:9: error: implicit declaration of > function ‘qemu_seccomp_get_kill_action’ > [-Werror=implicit-function-declaration] > action = qemu_seccomp_get_kill_action(blacklist[i].set); > ^ > /home/pm215/qemu/qemu-seccomp.c:181:9: error: nested extern > declaration of ‘qemu_seccomp_get_kill_action’ [-Werror=nested-externs] > /home/pm215/qemu/qemu-seccomp.c: At top level: > /home/pm215/qemu/qemu-seccomp.c:124:17: error: > ‘qemu_seccomp_get_action’ defined but not used > [-Werror=unused-function] > static uint32_t qemu_seccomp_get_action(int set) > ^ > > I think this will fail to build anywhere where > CONFIG_SECCOMP is set, or am I missing something ? No, actually I messed up the patch while applying. I changed the name of the function declaration based on some reviews and forgot to change when it is called. I'll fix that and send again. Sorry for the trouble. -- Eduardo Otubo signature.asc Description: PGP signature
Re: [Qemu-devel] [PULL 0/1] seccomp branch queue
On Wed, 20 Mar 2019 at 15:11, Eduardo Otubo wrote: > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > are available in the Git repository at: > > https://github.com/otubo/qemu.git tags/pull-seccomp-20190320 > > for you to fetch changes up to a25f1f63814c8ac5347a4d744c5bbad2702ef51c: > > seccomp: don't kill process for resource control syscalls (2019-03-20 > 16:05:02 +0100) > > > pull-seccomp-20190320 > > > Daniel P. Berrangé (1): > seccomp: don't kill process for resource control syscalls Hi; I'm afraid this doesn't build on all platforms: On PPC64 and also on my x86-64 box: /home/pm215/qemu/qemu-seccomp.c: In function ‘seccomp_start’: /home/pm215/qemu/qemu-seccomp.c:181:9: error: implicit declaration of function ‘qemu_seccomp_get_kill_action’ [-Werror=implicit-function-declaration] action = qemu_seccomp_get_kill_action(blacklist[i].set); ^ /home/pm215/qemu/qemu-seccomp.c:181:9: error: nested extern declaration of ‘qemu_seccomp_get_kill_action’ [-Werror=nested-externs] /home/pm215/qemu/qemu-seccomp.c: At top level: /home/pm215/qemu/qemu-seccomp.c:124:17: error: ‘qemu_seccomp_get_action’ defined but not used [-Werror=unused-function] static uint32_t qemu_seccomp_get_action(int set) ^ I think this will fail to build anywhere where CONFIG_SECCOMP is set, or am I missing something ? thanks -- PMM
Re: [Qemu-devel] [PULL 0/1] seccomp branch queue
On 26 September 2018 at 14:24, Eduardo Otubo wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository at: > > https://github.com/otubo/qemu.git tags/pull-seccomp-20180926 > > for you to fetch changes up to 5780760f5ea6163939a5dabe7427318b4f07d1a2: > > seccomp: check TSYNC host capability (2018-09-26 15:07:35 +0200) > > > pull-seccomp-20180926 > > > Marc-André Lureau (1): > seccomp: check TSYNC host capability Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 0/1] seccomp branch queue
On 25/09/2018 - 10:25:47, Peter Maydell wrote: > On 14 September 2018 at 14:06, Eduardo Otubo wrote: > > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > > > Merge remote-tracking branch > > 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 > > 16:44:20 +0100) > > > > are available in the Git repository at: > > > > https://github.com/otubo/qemu.git tags/pull-seccomp-20180914 > > > > for you to fetch changes up to d3228ed3829981047138bbaff332026f9d64f337: > > > > seccomp: check TSYNC host capability (2018-09-14 15:01:55 +0200) > > > > > > pull-seccomp-20180914 > > > > > > Marc-André Lureau (1): > > seccomp: check TSYNC host capability > > > > qemu-seccomp.c | 19 ++- > > vl.c | 4 ++-- > > 2 files changed, 20 insertions(+), 3 deletions(-) > > Hi. This pullreq is OK content-wise (it passed my build tests), but the > patch is missing your Signed-off-by: line as the maintainer. Could you > add that and respin, please? > Guess I forgot to do that this time. I'll send it right away. Sorry about that. -- Eduardo Otubo signature.asc Description: PGP signature
Re: [Qemu-devel] [PULL 0/1] seccomp branch queue
On 14 September 2018 at 14:06, Eduardo Otubo wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository at: > > https://github.com/otubo/qemu.git tags/pull-seccomp-20180914 > > for you to fetch changes up to d3228ed3829981047138bbaff332026f9d64f337: > > seccomp: check TSYNC host capability (2018-09-14 15:01:55 +0200) > > > pull-seccomp-20180914 > > > Marc-André Lureau (1): > seccomp: check TSYNC host capability > > qemu-seccomp.c | 19 ++- > vl.c | 4 ++-- > 2 files changed, 20 insertions(+), 3 deletions(-) Hi. This pullreq is OK content-wise (it passed my build tests), but the patch is missing your Signed-off-by: line as the maintainer. Could you add that and respin, please? thanks -- PMM
Re: [Qemu-devel] [PULL 0/1] seccomp branch queue
On 12 July 2018 at 14:25, Eduardo Otubo wrote: > The following changes since commit c447afd5783b9237fa51b7a85777007d8d568bfc: > > Update version for v3.0.0-rc0 release (2018-07-10 18:19:50 +0100) > > are available in the Git repository at: > > https://github.com/otubo/qemu.git tags/pull-seccomp-20180712 > > for you to fetch changes up to 056de1e894155fbb99e7b43c1c4382d4920cf437: > > seccomp: allow sched_setscheduler() with SCHED_IDLE policy (2018-07-12 > 14:52:39 +0200) > > > pull-seccomp-20180712 > > > Marc-André Lureau (1): > seccomp: allow sched_setscheduler() with SCHED_IDLE policy > > qemu-seccomp.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Applied, thanks. -- PMM