Re: [Qemu-devel] [PULL 0/8] Block patches
On 24.06.19 15:15, Pino Toscano wrote: > On Monday, 24 June 2019 14:20:11 CEST Max Reitz wrote: >> On 23.06.19 19:18, Peter Maydell wrote: >>> On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote: The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-06-18 17:00:52 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-2019-06-21 for you to fetch changes up to e2a76186f7948b8b75d1b2b52638de7c2f7f7472: iotests: Fix 205 for concurrent runs (2019-06-21 14:40:28 +0200) Block patches: - The SSH block driver now uses libssh instead of libssh2 - The VMDK block driver gets read-only support for the seSparse subformat - Various fixes >>> >>> Hi; this failed to build on my s390 box: >>> >>> /home/linux1/qemu/block/ssh.c: In function ‘check_host_key_knownhosts’: >>> /home/linux1/qemu/block/ssh.c:367:27: error: implicit declaration of >>> function ‘ssh_get_fingerprint_hash’ >>> [-Werror=implicit-function-declaration] >>> fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1, >>>^ >>> /home/linux1/qemu/block/ssh.c:367:13: error: nested extern declaration >>> of ‘ssh_get_fingerprint_hash’ [-Werror=nested-externs] >>> fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1, >>> ^ >>> /home/linux1/qemu/block/ssh.c:367:25: error: assignment makes pointer >>> from integer without a cast [-Werror=int-conversion] >>> fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1, >>> ^ >>> >>> It looks like that function was introduced in libssh 0.8.3, and this box >>> has 0.6.3. (configure has correctly not defined HAVE_LIBSSH_0_8 >>> but this usage is inside a bit of code that's compiled even when >>> that is not defined.) > > Oops, sorry, I did not test the latest versions with that old libssh. > >> Pino, would you be OK with dropping that piece of code for pre-0.8 and >> just replacing it with the else-error_setg()? > > Some the variables in check_host_key_knownhosts must be moved within > the HAVE_LIBSSH_0_8 block now; attached fixup patch, please squash with > my patch (I can submit a v12, if needed/wanted). Thanks, I’ve squashed it in and sent a v2 for this pull request. Max signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PULL 0/8] Block patches
On Monday, 24 June 2019 14:20:11 CEST Max Reitz wrote:
> On 23.06.19 19:18, Peter Maydell wrote:
> > On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote:
> >>
> >> The following changes since commit
> >> 33d609990621dea6c7d056c86f707b8811320ac1:
> >>
> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into
> >> staging (2019-06-18 17:00:52 +0100)
> >>
> >> are available in the Git repository at:
> >>
> >> https://github.com/XanClic/qemu.git tags/pull-block-2019-06-21
> >>
> >> for you to fetch changes up to e2a76186f7948b8b75d1b2b52638de7c2f7f7472:
> >>
> >> iotests: Fix 205 for concurrent runs (2019-06-21 14:40:28 +0200)
> >>
> >>
> >> Block patches:
> >> - The SSH block driver now uses libssh instead of libssh2
> >> - The VMDK block driver gets read-only support for the seSparse
> >> subformat
> >> - Various fixes
> >>
> >
> > Hi; this failed to build on my s390 box:
> >
> > /home/linux1/qemu/block/ssh.c: In function ‘check_host_key_knownhosts’:
> > /home/linux1/qemu/block/ssh.c:367:27: error: implicit declaration of
> > function ‘ssh_get_fingerprint_hash’
> > [-Werror=implicit-function-declaration]
> > fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1,
> >^
> > /home/linux1/qemu/block/ssh.c:367:13: error: nested extern declaration
> > of ‘ssh_get_fingerprint_hash’ [-Werror=nested-externs]
> > fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1,
> > ^
> > /home/linux1/qemu/block/ssh.c:367:25: error: assignment makes pointer
> > from integer without a cast [-Werror=int-conversion]
> > fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1,
> > ^
> >
> > It looks like that function was introduced in libssh 0.8.3, and this box
> > has 0.6.3. (configure has correctly not defined HAVE_LIBSSH_0_8
> > but this usage is inside a bit of code that's compiled even when
> > that is not defined.)
Oops, sorry, I did not test the latest versions with that old libssh.
> Pino, would you be OK with dropping that piece of code for pre-0.8 and
> just replacing it with the else-error_setg()?
Some the variables in check_host_key_knownhosts must be moved within
the HAVE_LIBSSH_0_8 block now; attached fixup patch, please squash with
my patch (I can submit a v12, if needed/wanted).
--
Pino Toscanodiff --git a/block/ssh.c b/block/ssh.c
index 048d0cc924..501933b855 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -277,14 +277,14 @@ static void ssh_parse_filename(const char *filename, QDict *options,
static int check_host_key_knownhosts(BDRVSSHState *s, Error **errp)
{
int ret;
+#ifdef HAVE_LIBSSH_0_8
+enum ssh_known_hosts_e state;
int r;
ssh_key pubkey;
enum ssh_keytypes_e pubkey_type;
unsigned char *server_hash = NULL;
size_t server_hash_len;
char *fingerprint = NULL;
-#ifdef HAVE_LIBSSH_0_8
-enum ssh_known_hosts_e state;
state = ssh_session_is_known_server(s->session);
trace_ssh_server_status(state);
@@ -356,30 +356,9 @@ static int check_host_key_knownhosts(BDRVSSHState *s, Error **errp)
break;
case SSH_SERVER_KNOWN_CHANGED:
ret = -EINVAL;
-r = ssh_get_publickey(s->session, &pubkey);
-if (r == 0) {
-r = ssh_get_publickey_hash(pubkey, SSH_PUBLICKEY_HASH_SHA1,
- &server_hash, &server_hash_len);
-pubkey_type = ssh_key_type(pubkey);
-ssh_key_free(pubkey);
-}
-if (r == 0) {
-fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1,
- server_hash,
- server_hash_len);
-ssh_clean_pubkey_hash(&server_hash);
-}
-if (fingerprint) {
-error_setg(errp,
- "host key (%s key with fingerprint %s) does not match "
- "the one in known_hosts; this may be a possible attack",
- ssh_key_type_to_char(pubkey_type), fingerprint);
-ssh_string_free_char(fingerprint);
-} else {
-error_setg(errp,
- "host key does not match the one in known_hosts; this "
- "may be a possible attack");
-}
+error_setg(errp,
+ "host key does not match the one in known_hosts; this "
+ "may be a possible attack");
goto out;
case SSH_SERVER_FOUND_OTHER:
ret = -EINVAL;
signature.asc
Description: This is a digitally signed message part.
Re: [Qemu-devel] [PULL 0/8] Block patches
On 23.06.19 19:18, Peter Maydell wrote: > On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote: >> >> The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1: >> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into >> staging (2019-06-18 17:00:52 +0100) >> >> are available in the Git repository at: >> >> https://github.com/XanClic/qemu.git tags/pull-block-2019-06-21 >> >> for you to fetch changes up to e2a76186f7948b8b75d1b2b52638de7c2f7f7472: >> >> iotests: Fix 205 for concurrent runs (2019-06-21 14:40:28 +0200) >> >> >> Block patches: >> - The SSH block driver now uses libssh instead of libssh2 >> - The VMDK block driver gets read-only support for the seSparse >> subformat >> - Various fixes >> > > Hi; this failed to build on my s390 box: > > /home/linux1/qemu/block/ssh.c: In function ‘check_host_key_knownhosts’: > /home/linux1/qemu/block/ssh.c:367:27: error: implicit declaration of > function ‘ssh_get_fingerprint_hash’ > [-Werror=implicit-function-declaration] > fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1, >^ > /home/linux1/qemu/block/ssh.c:367:13: error: nested extern declaration > of ‘ssh_get_fingerprint_hash’ [-Werror=nested-externs] > fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1, > ^ > /home/linux1/qemu/block/ssh.c:367:25: error: assignment makes pointer > from integer without a cast [-Werror=int-conversion] > fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1, > ^ > > It looks like that function was introduced in libssh 0.8.3, and this box > has 0.6.3. (configure has correctly not defined HAVE_LIBSSH_0_8 > but this usage is inside a bit of code that's compiled even when > that is not defined.) Pino, would you be OK with dropping that piece of code for pre-0.8 and just replacing it with the else-error_setg()? Max signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PULL 0/8] Block patches
On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote: > > The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2019-06-18 17:00:52 +0100) > > are available in the Git repository at: > > https://github.com/XanClic/qemu.git tags/pull-block-2019-06-21 > > for you to fetch changes up to e2a76186f7948b8b75d1b2b52638de7c2f7f7472: > > iotests: Fix 205 for concurrent runs (2019-06-21 14:40:28 +0200) > > > Block patches: > - The SSH block driver now uses libssh instead of libssh2 > - The VMDK block driver gets read-only support for the seSparse > subformat > - Various fixes > Hi; this failed to build on my s390 box: /home/linux1/qemu/block/ssh.c: In function ‘check_host_key_knownhosts’: /home/linux1/qemu/block/ssh.c:367:27: error: implicit declaration of function ‘ssh_get_fingerprint_hash’ [-Werror=implicit-function-declaration] fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1, ^ /home/linux1/qemu/block/ssh.c:367:13: error: nested extern declaration of ‘ssh_get_fingerprint_hash’ [-Werror=nested-externs] fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1, ^ /home/linux1/qemu/block/ssh.c:367:25: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] fingerprint = ssh_get_fingerprint_hash(SSH_PUBLICKEY_HASH_SHA1, ^ It looks like that function was introduced in libssh 0.8.3, and this box has 0.6.3. (configure has correctly not defined HAVE_LIBSSH_0_8 but this usage is inside a bit of code that's compiled even when that is not defined.) thanks -- PMM
Re: [Qemu-devel] [PULL 0/8] Block patches
On Fri, 10 May 2019 at 14:02, Stefan Hajnoczi wrote: > > The following changes since commit 812b835fb4d23dd108b2f9802158472d50b73579: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-05-07' > into staging (2019-05-09 16:31:12 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to e84125761f78919fe63616d9888ea45e72dc956f: > > docs: add Security chapter to the documentation (2019-05-10 10:53:52 +0100) > > > Pull request > > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.1 for any user-visible changes. -- PMM
Re: [Qemu-devel] [PULL 0/8] Block patches
On 12 May 2018 at 10:28, Stefan Hajnoczi wrote: > The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging (2018-05-08 17:05:58 +0100) > > are available in the Git repository at: > > git://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to 31be8a2a97ecba7d31a82932286489cac318e9e9: > > block/file-posix: add x-check-page-cache=on|off option (2018-05-11 16:43:05 > +0100) > > > Block pull request > > * Support -drive cache.direct=off live migration for POSIX files > Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 0/8] Block patches
On 14 May 2018 at 14:15, Peter Maydell wrote:
> On 12 May 2018 at 10:28, Stefan Hajnoczi wrote:
>> The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544:
>>
>> Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
>> staging (2018-05-08 17:05:58 +0100)
>>
>> are available in the Git repository at:
>>
>> git://github.com/stefanha/qemu.git tags/block-pull-request
>>
>> for you to fetch changes up to 31be8a2a97ecba7d31a82932286489cac318e9e9:
>>
>> block/file-posix: add x-check-page-cache=on|off option (2018-05-11
>> 16:43:05 +0100)
>>
>>
>> Block pull request
>>
>> * Support -drive cache.direct=off live migration for POSIX files
>>
>>
>
> With this I get test failures for x86-64 Linux host (debug enabled):
>
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> gtester -k --verbose -m=quick tests/test-replication
> TEST: tests/test-replication... (pid=15016)
> /replication/primary/read: OK
> /replication/primary/write: OK
> /replication/primary/start: OK
> /replication/primary/stop: OK
> /replication/primary/do_checkpoint: OK
> /replication/primary/get_error_all: OK
> /replication/secondary/read: **
> ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:119:test_blk_write:
> assertion failed: (async_ret == 0)
> FAIL
> GTester: last random seed: R02Sf99d81651223b2fcdd0d7d601245eba3
> (pid=15131)
> /replication/secondary/write:OK
> /replication/secondary/start:**
> ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:119:test_blk_write:
> assertion failed: (async_ret == 0)
> FAIL
Sorry, this is a false alarm -- this test fails in this obscure way if the
system has run out of disk space and the write returns ENOSPC.
Ideally we should fix the test to print the errno. In the meantime I've
deleted some large log files and will retest the pull :-)
thanks
-- PMM
Re: [Qemu-devel] [PULL 0/8] Block patches
On 12 May 2018 at 10:28, Stefan Hajnoczi wrote:
> The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544:
>
> Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
> staging (2018-05-08 17:05:58 +0100)
>
> are available in the Git repository at:
>
> git://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 31be8a2a97ecba7d31a82932286489cac318e9e9:
>
> block/file-posix: add x-check-page-cache=on|off option (2018-05-11 16:43:05
> +0100)
>
>
> Block pull request
>
> * Support -drive cache.direct=off live migration for POSIX files
>
>
With this I get test failures for x86-64 Linux host (debug enabled):
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
gtester -k --verbose -m=quick tests/test-replication
TEST: tests/test-replication... (pid=15016)
/replication/primary/read: OK
/replication/primary/write: OK
/replication/primary/start: OK
/replication/primary/stop: OK
/replication/primary/do_checkpoint: OK
/replication/primary/get_error_all: OK
/replication/secondary/read: **
ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:119:test_blk_write:
assertion failed: (async_ret == 0)
FAIL
GTester: last random seed: R02Sf99d81651223b2fcdd0d7d601245eba3
(pid=15131)
/replication/secondary/write:OK
/replication/secondary/start:**
ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:119:test_blk_write:
assertion failed: (async_ret == 0)
FAIL
GTester: last random seed: R02S3e753c59c58d385aa2ea07c974c2e384
(pid=15309)
/replication/secondary/stop: **
ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:119:test_blk_write:
assertion failed: (async_ret == 0)
FAIL
GTester: last random seed: R02Sb6a8459edfa78efa369da3920846afa7
(pid=15439)
/replication/secondary/do_checkpoint:**
ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:119:test_blk_write:
assertion failed: (async_ret == 0)
FAIL
GTester: last random seed: R02S4b2e6aa4e33bba4c5bdea0b9073ee966
(pid=15580)
/replication/secondary/get_error_all:OK
FAIL: tests/test-replication
/home/petmay01/linaro/qemu-for-merges/tests/Makefile.include:892:
recipe for target 'check-tests/test-replication' failed
thanks
-- PMM
Re: [Qemu-devel] [PULL 0/8] Block patches
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180512092824.13848-1-stefa...@redhat.com
Subject: [Qemu-devel] [PULL 0/8] Block patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20180512092824.13848-1-stefa...@redhat.com
-> patchew/20180512092824.13848-1-stefa...@redhat.com
t [tag update]
patchew/cover.1526081108.git.alistair.fran...@wdc.com ->
patchew/cover.1526081108.git.alistair.fran...@wdc.com
Switched to a new branch 'test'
a35067253e block/file-posix: add x-check-page-cache=on|off option
c6c991d81f block/file-posix: implement bdrv_co_invalidate_cache() on Linux
3b9d04939d checkpatch: reduce MAINTAINERS update message frequency
92c27dd7e6 checkpatch: emit a warning on file add/move/delete
82e1381f3f checkpatch: ignore email headers better
63d8deac11 checkpatch: check utf-8 content from a commit log when it's missing
from charset
7ecaae4f83 checkpatch: add a --strict check for utf-8 in commit logs
ca525fa2f4 blockjob: drop block_job_pause/resume_all()
=== OUTPUT BEGIN ===
Checking PATCH 1/8: blockjob: drop block_job_pause/resume_all()...
Checking PATCH 2/8: checkpatch: add a --strict check for utf-8 in commit logs...
WARNING: line over 80 characters
#109: FILE: scripts/checkpatch.pl:1420:
+ WARN("8-bit UTF-8 used in possible commit log\n" .
$herecurr);
total: 0 errors, 1 warnings, 66 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/8: checkpatch: check utf-8 content from a commit log when it's
missing from charset...
Checking PATCH 4/8: checkpatch: ignore email headers better...
Checking PATCH 5/8: checkpatch: emit a warning on file add/move/delete...
WARNING: line over 80 characters
#51: FILE: scripts/checkpatch.pl:1397:
+($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/
&&
ERROR: line over 90 characters
#54: FILE: scripts/checkpatch.pl:1400:
+ WARN("added, moved or deleted file(s), does MAINTAINERS
need updating?\n" . $herecurr);
total: 1 errors, 1 warnings, 24 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/8: checkpatch: reduce MAINTAINERS update message frequency...
Checking PATCH 7/8: block/file-posix: implement bdrv_co_invalidate_cache() on
Linux...
WARNING: architecture specific defines should be avoided
#52: FILE: block/file-posix.c:2255:
+#if defined(__linux__)
total: 0 errors, 1 warnings, 70 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/8: block/file-posix: add x-check-page-cache=on|off option...
WARNING: line over 80 characters
#47: FILE: block/file-posix.c:423:
+.help = "check that page cache was dropped on live migration
(default: off)"
WARNING: architecture specific defines should be avoided
#120: FILE: block/file-posix.c:2264:
+#if defined(__linux__)
total: 0 errors, 2 warnings, 185 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Re: [Qemu-devel] [PULL 0/8] Block patches
On 18 July 2016 at 17:59, Stefan Hajnoczi wrote: > The following changes since commit 3913d3707e3debfbf0d2d014a1a793394993b088: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160718' > into staging (2016-07-18 11:24:15 +0100) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to e1029ae26d96d5de78c2d9af5eddcea92e73a46a: > > MAINTAINERS: Add include/block/aio.h to block I/O path section (2016-07-18 > 15:10:52 +0100) > > > > This is not quite a v2 because I have added more patches. "linux-aio: share > one LinuxAioState within an AioContext" is now fixed under mingw. > > Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 0/8] Block patches for 2.0.0-rc1
On 19 March 2014 13:11, Kevin Wolf wrote: > The following changes since commit 059b3527f0229f4d60fd77a317503d42abd5e50f: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-2' into staging > (2014-03-18 16:39:29 +) > > are available in the git repository at: > > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to 198fd05c357afff22f0b0e02639937519ed49b1f: > > dataplane: fix implicit IOThread refcount (2014-03-19 09:45:25 +0100) > > > Block patches for 2.0.0-rc1 Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 0/8] Block patches
On 31 January 2014 21:19, Stefan Hajnoczi wrote: > The following changes since commit 89e4a51ca9546a7bbe1998c4e3d4a3ac3a0c19be: > > Merge remote-tracking branch 'stefanha/tags/tracing-pull-request' into > staging (2014-01-31 11:13:08 +) > > are available in the git repository at: > > > git://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to 1b7650ef2f63d53cf89af25a9f323323cf2423a7: > > qemu-iotests: only run 071 on qcow2 (2014-01-31 22:05:03 +0100) Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 0/8] Block patches
On 07/06/2011 09:21 AM, Kevin Wolf wrote: The following changes since commit 9312805d33e8b106bae356d13a8071fb37d75554: pxa2xx_lcd: add proper rotation support (2011-07-04 22:12:21 +0200) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Federico Simoncelli (1): qemu-img: Add cache command line option Johannes Stezenbach (1): block/raw-posix: Linux compat-ioctl warning workaround Kevin Wolf (3): Documentation: Remove outdated host_device note ide: Ignore reads during PIO in and writes during PIO out ide: Initialise buffers with zeros Luiz Capitulino (2): block: drive_init(): Simplify interface type setting block: drive_init(): Improve CHS setting error message Markus Armbruster (1): virtio-blk: Turn drive serial into a qdev property block/raw-posix.c| 14 + blockdev.c | 14 +++- hw/ide/core.c| 50 +- hw/s390-virtio-bus.c |4 ++- hw/s390-virtio-bus.h |1 + hw/virtio-blk.c | 29 -- hw/virtio-blk.h |2 + hw/virtio-pci.c |4 ++- hw/virtio-pci.h |1 + hw/virtio.h |3 +- qemu-img-cmds.hx |6 ++-- qemu-img.c | 80 + qemu-img.texi|6 13 files changed, 161 insertions(+), 53 deletions(-)
Re: [Qemu-devel] [PULL 0/8] Block patches
Am 06.07.2011 16:21, schrieb Kevin Wolf: > The following changes since commit 9312805d33e8b106bae356d13a8071fb37d75554: > > pxa2xx_lcd: add proper rotation support (2011-07-04 22:12:21 +0200) > > are available in the git repository at: > git://repo.or.cz/qemu/kevin.git for-anthony > > Federico Simoncelli (1): > qemu-img: Add cache command line option > > Johannes Stezenbach (1): > block/raw-posix: Linux compat-ioctl warning workaround > > Kevin Wolf (3): > Documentation: Remove outdated host_device note > ide: Ignore reads during PIO in and writes during PIO out > ide: Initialise buffers with zeros > > Luiz Capitulino (2): > block: drive_init(): Simplify interface type setting > block: drive_init(): Improve CHS setting error message > > Markus Armbruster (1): > virtio-blk: Turn drive serial into a qdev property > > block/raw-posix.c| 14 + > blockdev.c | 14 +++- > hw/ide/core.c| 50 +- > hw/s390-virtio-bus.c |4 ++- > hw/s390-virtio-bus.h |1 + > hw/virtio-blk.c | 29 -- > hw/virtio-blk.h |2 + > hw/virtio-pci.c |4 ++- > hw/virtio-pci.h |1 + > hw/virtio.h |3 +- > qemu-img-cmds.hx |6 ++-- > qemu-img.c | 80 + > qemu-img.texi|6 > 13 files changed, 161 insertions(+), 53 deletions(-) Ping?
