Re: [Qemu-devel] [PULL 00/21] Block layer patches
On 15 August 2018 at 13:55, Kevin Wolf wrote: > The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866: > > Update version for v3.0.0 release (2018-08-14 16:38:43 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to b5fc2d306664c0c1c6c5cf8e164ffa7b8892283e: > > qapi: block: Remove mentions of error types which were removed (2018-08-15 > 12:50:39 +0200) > > > Block layer patches: > > - Remove deprecated -drive options for geometry/serial/addr > - luks: Allow shared writers if the parents allow them (share-rw=on) > - qemu-img: Fix error when trying to convert to encrypted target image > - mirror: Fail gracefully for source == target > - I/O throttling: Fix behaviour during drain (always ignore the limits) > - bdrv_reopen() related fixes for bs->options/explicit_options content > - Documentation improvements > Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 00/21] Block layer patches
On 18 July 2017 at 15:17, Kevin Wolfwrote: > The following changes since commit 718d7f4f9cf772e5784093d8e6085680a235acdb: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-07-18 13:09:51 +0100) > > are available in the git repository at: > > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to 6e6e55f5c2e5b520d6506c2716287ba3b5d1bbc8: > > qemu-img: Check for backing image if specified during create (2017-07-18 > 15:27:37 +0200) > > > Block layer patches > Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 00/21] Block layer patches
Am 18.07.2017 um 20:57 hat no-re...@patchew.org geschrieben: > ** > ERROR:/tmp/qemu-test/src/tests/test-qga.c:78:fixture_setup: assertion failed > (fixture->fd != -1): (-1 != -1) > GTester: last random seed: R02S1e410abb69660daf8fd594a35e52f43b > make: *** [check-tests/test-qga] Error 1 > make: *** Waiting for unfinished jobs The patches don't touch qga and I can't reproduce the failure, so I assume this was just intermittent failure due to a preexisting problem. Kevin
Re: [Qemu-devel] [PULL 00/21] Block layer patches
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/21] Block layer patches Message-id: 1500387486-5469-1-git-send-email-kw...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 65ef5d7 qemu-img: Check for backing image if specified during create 1ed5939 blockdev: move BDRV_O_NO_BACKING option forward a881ee1 block/vvfat: Fix compiler warning with gcc 7 313dec5 vvfat: initialize memory after allocating it e18cf9f vvfat: correctly parse non-ASCII short and long file names d24fe91 vvfat: add a constant for bootsector name 213812e vvfat: add constants for special values of name[0] 079d39b qemu-iotests: Test unplug of -device without drive 99f1345 qemu-iotests: Test 'info block' 7c33c97 scsi-disk: bdrv_attach_dev() for empty CD-ROM 1529192 ide: bdrv_attach_dev() for empty CD-ROM 48dd434 block: List anonymous device BBs in query-block 9b5bf99 block/qapi: Use blk_all_next() for query-block 90cf4d0 block: Make blk_all_next() public 7034977 block/qapi: Add qdev device name to query-block 012e33e block: Make blk_get_attached_dev_id() public 49e9e06 block/vpc.c: Handle write failures in get_image_offset() fe47440 block/vmdk: Report failures in vmdk_read_cid() b7a0797 block: remove timer canceling in throttle_config() 8179adf block: add clock_type field to ThrottleGroup be86950 commit: Add NULL check for overlay_bs === OUTPUT BEGIN === Checking PATCH 1/21: commit: Add NULL check for overlay_bs... Checking PATCH 2/21: block: add clock_type field to ThrottleGroup... Checking PATCH 3/21: block: remove timer canceling in throttle_config()... Checking PATCH 4/21: block/vmdk: Report failures in vmdk_read_cid()... Checking PATCH 5/21: block/vpc.c: Handle write failures in get_image_offset()... Checking PATCH 6/21: block: Make blk_get_attached_dev_id() public... Checking PATCH 7/21: block/qapi: Add qdev device name to query-block... Checking PATCH 8/21: block: Make blk_all_next() public... Checking PATCH 9/21: block/qapi: Use blk_all_next() for query-block... Checking PATCH 10/21: block: List anonymous device BBs in query-block... Checking PATCH 11/21: ide: bdrv_attach_dev() for empty CD-ROM... Checking PATCH 12/21: scsi-disk: bdrv_attach_dev() for empty CD-ROM... Checking PATCH 13/21: qemu-iotests: Test 'info block'... Checking PATCH 14/21: qemu-iotests: Test unplug of -device without drive... Checking PATCH 15/21: vvfat: add constants for special values of name[0]... Checking PATCH 16/21: vvfat: add a constant for bootsector name... Checking PATCH 17/21: vvfat: correctly parse non-ASCII short and long file names... Checking PATCH 18/21: vvfat: initialize memory after allocating it... Checking PATCH 19/21: block/vvfat: Fix compiler warning with gcc 7... Checking PATCH 20/21: blockdev: move BDRV_O_NO_BACKING option forward... Checking PATCH 21/21: qemu-img: Check for backing image if specified during create... ERROR: Error messages should not contain newlines #103: FILE: block.c:4432: +"This may become an error in future versions.\n"); total: 1 errors, 0 warnings, 251 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org
Re: [Qemu-devel] [PULL 00/21] Block layer patches
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PULL 00/21] Block layer patches Message-id: 1500387486-5469-1-git-send-email-kw...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-quick@centos6 time make docker-test-build@min-glib time make docker-test-mingw@fedora === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 65ef5d7 qemu-img: Check for backing image if specified during create 1ed5939 blockdev: move BDRV_O_NO_BACKING option forward a881ee1 block/vvfat: Fix compiler warning with gcc 7 313dec5 vvfat: initialize memory after allocating it e18cf9f vvfat: correctly parse non-ASCII short and long file names d24fe91 vvfat: add a constant for bootsector name 213812e vvfat: add constants for special values of name[0] 079d39b qemu-iotests: Test unplug of -device without drive 99f1345 qemu-iotests: Test 'info block' 7c33c97 scsi-disk: bdrv_attach_dev() for empty CD-ROM 1529192 ide: bdrv_attach_dev() for empty CD-ROM 48dd434 block: List anonymous device BBs in query-block 9b5bf99 block/qapi: Use blk_all_next() for query-block 90cf4d0 block: Make blk_all_next() public 7034977 block/qapi: Add qdev device name to query-block 012e33e block: Make blk_get_attached_dev_id() public 49e9e06 block/vpc.c: Handle write failures in get_image_offset() fe47440 block/vmdk: Report failures in vmdk_read_cid() b7a0797 block: remove timer canceling in throttle_config() 8179adf block: add clock_type field to ThrottleGroup be86950 commit: Add NULL check for overlay_bs === OUTPUT BEGIN === Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into '/var/tmp/patchew-tester-tmp-gtvc_24e/src/dtc'... Submodule path 'dtc': checked out '558cd81bdd432769b59bff01240c44f82cfb1a9d' BUILD centos6 make[1]: Entering directory '/var/tmp/patchew-tester-tmp-gtvc_24e/src' ARCHIVE qemu.tgz ARCHIVE dtc.tgz COPYRUNNER RUN test-quick in qemu:centos6 Packages installed: SDL-devel-1.2.14-7.el6_7.1.x86_64 bison-2.4.1-5.el6.x86_64 ccache-3.1.6-2.el6.x86_64 epel-release-6-8.noarch flex-2.5.35-9.el6.x86_64 gcc-4.4.7-18.el6.x86_64 git-1.7.1-8.el6.x86_64 glib2-devel-2.28.8-9.el6.x86_64 libfdt-devel-1.4.0-1.el6.x86_64 make-3.81-23.el6.x86_64 package g++ is not installed pixman-devel-0.32.8-1.el6.x86_64 tar-1.23-15.el6_8.x86_64 zlib-devel-1.2.3-29.el6.x86_64 Environment variables: PACKAGES=libfdt-devel ccache tar git make gcc g++ flex bison zlib-devel glib2-devel SDL-devel pixman-devel epel-release HOSTNAME=6c35b45ac342 TERM=xterm MAKEFLAGS= -j8 HISTSIZE=1000 J=8 USER=root CCACHE_DIR=/var/tmp/ccache EXTRA_CONFIGURE_OPTS= V= SHOW_ENV=1 MAIL=/var/spool/mail/root PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD=/ LANG=en_US.UTF-8 TARGET_LIST= HISTCONTROL=ignoredups SHLVL=1 HOME=/root TEST_DIR=/tmp/qemu-test LOGNAME=root LESSOPEN=||/usr/bin/lesspipe.sh %s FEATURES= dtc DEBUG= G_BROKEN_FILENAMES=1 CCACHE_HASHDIR= _=/usr/bin/env Configure options: --enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/var/tmp/qemu-build/install No C++ compiler available; disabling C++ specific optional code Install prefix/var/tmp/qemu-build/install BIOS directory/var/tmp/qemu-build/install/share/qemu binary directory /var/tmp/qemu-build/install/bin library directory /var/tmp/qemu-build/install/lib module directory /var/tmp/qemu-build/install/lib/qemu libexec directory /var/tmp/qemu-build/install/libexec include directory /var/tmp/qemu-build/install/include config directory /var/tmp/qemu-build/install/etc local state directory /var/tmp/qemu-build/install/var Manual directory /var/tmp/qemu-build/install/share/man ELF interp prefix /usr/gnemul/qemu-%M Source path /tmp/qemu-test/src C compilercc Host C compiler cc C++ compiler Objective-C compiler cc ARFLAGS rv CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g QEMU_CFLAGS -I/usr/include/pixman-1 -I$(SRC_PATH)/dtc/libfdt -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g make make install install pythonpython -B smbd /usr/sbin/smbd
Re: [Qemu-devel] [PULL 00/21] Block layer patches
On 7 January 2016 at 22:57, Max Reitzwrote: > Kevin is on PTO this week, so I am filling in for him. > > > The following changes since commit a7e00e2536941a6e570b45b7ab4afec4505ff67e: > > petalogix-ml605: Set the MicroBlaze CPU version to 8.10.a (2016-01-07 > 14:57:26 +0100) > > are available in the git repository at: > > git://github.com/XanClic/qemu.git tags/pull-block-for-peter-2016-01-07 > > for you to fetch changes up to 94ca2c7395ef3eebb829227210c6757eba5b00d3: > > iotests: Add test cases for blockdev-mirror (2016-01-07 21:30:18 +0100) > > > Block patches from 2015-12-23 until 2016-01-07. > > > Applied, thanks. -- PMM