Re: [Qemu-devel] [RESEND PATCH v3 0/8] libqos: use standard virtio headers
On Mon, May 09, 2016 at 01:47:33PM +0100, Stefan Hajnoczi wrote: > v2: > * Fix missing s/X/(1u << X)/ conversion in Patch 3 [Marc] > > This patch series eliminates code duplication in libqos virtio. > include/standard-headers/ contains the Linux virtio header files so we don't > need to define our own version of the structs and constants. > > Stefan Hajnoczi (8): > libqos: use virtio_ids.h for device ID definitions > libqos: drop duplicated PCI vendor ID definition > libqos: drop duplicated virtio_config.h definitions > libqos: drop duplicated virtio_ring.h bit definitions > libqos: drop duplicated virtio_vring.h structs > libqos: drop duplicated virtio_blk.h definitions > libqos: drop duplicated virtio_scsi.h definitions > libqos: drop duplicated virtio_pci.h definitions > > tests/libqos/virtio-mmio.c | 5 +-- > tests/libqos/virtio-pci.c | 50 ++- > tests/libqos/virtio-pci.h | 17 - > tests/libqos/virtio.c | 42 +++--- > tests/libqos/virtio.h | 73 --- > tests/virtio-blk-test.c| 86 > -- > tests/virtio-net-test.c| 10 +++--- > tests/virtio-scsi-test.c | 53 +++- > 8 files changed, 123 insertions(+), 213 deletions(-) > > -- > 2.5.5 > Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan signature.asc Description: PGP signature
Re: [Qemu-devel] [RESEND PATCH v3 0/8] libqos: use standard virtio headers
On Mon, Jun 13, 2016 at 05:40:42PM -0400, John Snow wrote: > On 05/09/2016 08:47 AM, Stefan Hajnoczi wrote: > > v2: > > * Fix missing s/X/(1u << X)/ conversion in Patch 3 [Marc] > > > > This patch series eliminates code duplication in libqos virtio. > > include/standard-headers/ contains the Linux virtio header files so we don't > > need to define our own version of the structs and constants. > > > > Stefan Hajnoczi (8): > > libqos: use virtio_ids.h for device ID definitions > > libqos: drop duplicated PCI vendor ID definition > > libqos: drop duplicated virtio_config.h definitions > > libqos: drop duplicated virtio_ring.h bit definitions > > libqos: drop duplicated virtio_vring.h structs > > libqos: drop duplicated virtio_blk.h definitions > > libqos: drop duplicated virtio_scsi.h definitions > > libqos: drop duplicated virtio_pci.h definitions > > > > tests/libqos/virtio-mmio.c | 5 +-- > > tests/libqos/virtio-pci.c | 50 ++- > > tests/libqos/virtio-pci.h | 17 - > > tests/libqos/virtio.c | 42 +++--- > > tests/libqos/virtio.h | 73 --- > > tests/virtio-blk-test.c| 86 > > -- > > tests/virtio-net-test.c| 10 +++--- > > tests/virtio-scsi-test.c | 53 +++- > > 8 files changed, 123 insertions(+), 213 deletions(-) > > > > Did this fall through the cracks because of a lack of ACKs? I'll push it through my block tree. The effort behind this series, vhost-vsock testing, has stalled so I didn't revisit this yet. signature.asc Description: PGP signature
Re: [Qemu-devel] [RESEND PATCH v3 0/8] libqos: use standard virtio headers
On 05/09/2016 08:47 AM, Stefan Hajnoczi wrote: > v2: > * Fix missing s/X/(1u << X)/ conversion in Patch 3 [Marc] > > This patch series eliminates code duplication in libqos virtio. > include/standard-headers/ contains the Linux virtio header files so we don't > need to define our own version of the structs and constants. > > Stefan Hajnoczi (8): > libqos: use virtio_ids.h for device ID definitions > libqos: drop duplicated PCI vendor ID definition > libqos: drop duplicated virtio_config.h definitions > libqos: drop duplicated virtio_ring.h bit definitions > libqos: drop duplicated virtio_vring.h structs > libqos: drop duplicated virtio_blk.h definitions > libqos: drop duplicated virtio_scsi.h definitions > libqos: drop duplicated virtio_pci.h definitions > > tests/libqos/virtio-mmio.c | 5 +-- > tests/libqos/virtio-pci.c | 50 ++- > tests/libqos/virtio-pci.h | 17 - > tests/libqos/virtio.c | 42 +++--- > tests/libqos/virtio.h | 73 --- > tests/virtio-blk-test.c| 86 > -- > tests/virtio-net-test.c| 10 +++--- > tests/virtio-scsi-test.c | 53 +++- > 8 files changed, 123 insertions(+), 213 deletions(-) > Did this fall through the cracks because of a lack of ACKs? --js
Re: [Qemu-devel] [RESEND PATCH v3 0/8] libqos: use standard virtio headers
On 10/05/2016 11:59, Stefan Hajnoczi wrote: > > I still dream of having qtests written in Python; I agree that for now > > this makes sense. > > Is there any particular Python feature that you miss? I would like to use QMP more and to autodiscover buses (so that every SCSI test can be run on both virtio-scsi and LSI SAS, just by writing a "driver" for LSI SAS), and I would like to write that code in anything but C. :) > Writing low-level device tests in C seems okay to me. Yes, it's fine---but writing tests that also interact with the monitor is a bit worse, similar to how qemu-iotests is part shell and part Python. > The problem is that the longer we wait, the harder it becomes to move to > Python. We'd need all the PCI, virtio, etc frameworks ported to Python. True... but I can still dream. ;) Paolo signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [RESEND PATCH v3 0/8] libqos: use standard virtio headers
On Mon, May 09, 2016 at 03:57:13PM +0200, Paolo Bonzini wrote: > > > On 09/05/2016 14:47, Stefan Hajnoczi wrote: > > v2: > > * Fix missing s/X/(1u << X)/ conversion in Patch 3 [Marc] > > > > This patch series eliminates code duplication in libqos virtio. > > include/standard-headers/ contains the Linux virtio header files so we don't > > need to define our own version of the structs and constants. > > I still dream of having qtests written in Python; I agree that for now > this makes sense. Is there any particular Python feature that you miss? Writing low-level device tests in C seems okay to me. The problem is that the longer we wait, the harder it becomes to move to Python. We'd need all the PCI, virtio, etc frameworks ported to Python. Stefan signature.asc Description: PGP signature
Re: [Qemu-devel] [RESEND PATCH v3 0/8] libqos: use standard virtio headers
On 09/05/2016 14:47, Stefan Hajnoczi wrote: > v2: > * Fix missing s/X/(1u << X)/ conversion in Patch 3 [Marc] > > This patch series eliminates code duplication in libqos virtio. > include/standard-headers/ contains the Linux virtio header files so we don't > need to define our own version of the structs and constants. I still dream of having qtests written in Python; I agree that for now this makes sense. Paolo
