Re: [Qemu-devel] [RFC PATCH 07/13] tests/tcg/xtensa: enable system tests
On Tue, Dec 11, 2018 at 3:58 AM Alex Bennée wrote: > I could certainly add a rule like: > > gdb-%: % > gdb --args $(QEMU) $(QEMU_OPTS) $< Thanks (: > > and a way to run tests on Tensilica ISS, it would be nice to keep it. > > I can restore some xtensa specific rules: > > xt-run-%: % > xt-run --xtensa-core=DC_B_232L --exit_with_target_code $< The idea in the original makefile was that 'make check XT=' runs the same suite on the ISS that 'make check' runs on QEMU. > What are EXTFLAGS used for? To pass additional flags to the current emulator. Usually -d something for QEMU. Also now that I'm looking at the following, it seems to me that CC would be more appropriate there than HOST_CC: > +linker.ld: linker.ld.S > + $(HOST_CC) $(XTENSA_INC) -E -P $< -o $@ -- Thanks. -- Max
Re: [Qemu-devel] [RFC PATCH 07/13] tests/tcg/xtensa: enable system tests
Max Filippov writes: > On Mon, Dec 10, 2018 at 7:28 AM Alex Bennée wrote: >> >> Signed-off-by: Alex Bennée >> --- >> tests/tcg/xtensa/Makefile| 93 >> tests/tcg/xtensa/Makefile.softmmu-target | 43 +++ >> 2 files changed, 43 insertions(+), 93 deletions(-) >> delete mode 100644 tests/tcg/xtensa/Makefile > > That Makefile provides a few nice goals for guest and host debugging I could certainly add a rule like: gdb-%: % gdb --args $(QEMU) $(QEMU_OPTS) $< > and a way to run tests on Tensilica ISS, it would be nice to keep it. I can restore some xtensa specific rules: xt-run-%: % xt-run --xtensa-core=DC_B_232L --exit_with_target_code $< What are EXTFLAGS used for? -- Alex Bennée
Re: [Qemu-devel] [RFC PATCH 07/13] tests/tcg/xtensa: enable system tests
On Mon, Dec 10, 2018 at 7:28 AM Alex Bennée wrote: > > Signed-off-by: Alex Bennée > --- > tests/tcg/xtensa/Makefile| 93 > tests/tcg/xtensa/Makefile.softmmu-target | 43 +++ > 2 files changed, 43 insertions(+), 93 deletions(-) > delete mode 100644 tests/tcg/xtensa/Makefile That Makefile provides a few nice goals for guest and host debugging and a way to run tests on Tensilica ISS, it would be nice to keep it. -- Thanks. -- Max
